From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE8EE1E47C5 for ; Wed, 7 Jan 2026 01:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767751077; cv=none; b=m6jGzZ5/C1GnkhBDHRbXDAlwH5lay1/eO9dY6KJaDxF7BbUW2YHS33Wid8HlYIPOyNnr7HBIlmsSMNyttVf6M1hMH+Y+974fguT4rzSlWigBfHoZeaNpBMSEodQu98YKjmU4B1PQhZk4DpcsMwr96sdGW3uB53PiowsNN1Ste50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767751077; c=relaxed/simple; bh=avHQJ1ZmX9roX0am14C09/wdnSph7eLjg6ZB5uFDu6g=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=JR3ltKr0GSxGhHMBr1A2Hek4RbhUq2iks2VQqlpI5zvRIhp1HuY3tVVxMLjmW5Fm2b+5DIVBDj7gb0NFGvuVS8+Z/wkbQh7KYleu7uoj3pNMxt7LUomEnsS+dURhD2MNvPAOKf6MK0VDta8rH0JlpIT8pFgOya41AxC1whqNBTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=USWah2Ct; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="USWah2Ct" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-8c305b7c472so108063385a.0 for ; Tue, 06 Jan 2026 17:57:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1767751075; x=1768355875; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=/n4OKQ1p2rLBJccVbmNE8YULKxul1X3u9fZ3VtZZHbA=; b=USWah2CtLDKw0k3hR4eOXFSvC6DC10Q3rovqZX/reRXHjmApVTLRi1QNvqQLteSmvA 9KZvQv7BhEPOOIXLppI1+n3amec2xMRUCmAmLeuzBAJBZ5eaCYt/QvlNVO/c2hLdCLMH cFXvJliwZ6HALb7jiqgz5EJSqNItRenssIj3Z2X6bbMoNejA3egHZdSaW9RcLdPhlVBe t6muC3JmJuZhFUACjFZyzuttD96T2vSGKNivekApDa1ou9femOyJYiCuWr468dZNf4eh 9mQoJzVvb7QQvB1DGw06LqmVBO/J2kWkwLCl0ogVpkEnqvugYwPI9ivsyP8Y1Jxqk4Oc M4xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767751075; x=1768355875; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/n4OKQ1p2rLBJccVbmNE8YULKxul1X3u9fZ3VtZZHbA=; b=sdwBHHdLVJF02AjHSHFnPh7dBKwPXqNMb5OFhXFO4xbIvwRlaSN8JUGaBjAQ8iOEtq hOKHcLPi2cmXsBckGTBUIqI99akGyvE1LH6AdqgJKYHRdeC8lqBf5Z9aWLofIcYIeEq0 E1adiO9iLooLYf6cMGq4pbQwp8B5FDZm4qfPRCFnzSy+8Q6yec6FF25QInETJYjYj5EL 0ZMSQKPEc+byghaN7rHe5nc1XPGtAtFdAA7UxZ4S3SvARv99CNsTCsZEa09k8W93ttmj uaqBi9mKNnT74yc9xL97V18BJXu7Z/dwpgEo9zNbmVq6gUtRqK2r6durgos4QfqCuFcm CkKA== X-Forwarded-Encrypted: i=1; AJvYcCXiFU883AEhAiT2aI97gproiztGWHyfHl+qr/SZO7WXJQxNGcKrqpmeGVvJC/GO/vh2u18AJHENb55LY7U=@vger.kernel.org X-Gm-Message-State: AOJu0YzucqfzS9rqHUTJrJEYYbKrWCyhHM/GR09p4nxmD7LLHJjYmf4v OdywfDXT2H629HViyFfWpi++qRo6YXMFAxuR1YQUVlwhqrBkrwgpmnQCcagq9UNsdA== X-Gm-Gg: AY/fxX4p2V7IyM8nG7Nl10faFU1Z/CmtUjj53hs0o+VyN/aRxWgXgJoXPLzUlHXOk5v Iav5eiaYhY5HPRoUluK6WtylJ/2a7ZcD68YmCK2npMlMfvWW7kR+Mv5ZLc5A/um3QLzIio9oDnZ X/jhHrjWk3IHjRXk6whX6QmcdXscKK/kYs9RlYMJa+8oo2DUyoI1nCUoOHhbbHbpBcn1yFCeGqa poHDxJa8jn2qo0zOh5JsiVilNhApY1nSIZZjVbYL5L6mprwbxO0bQPTTS5P2qY7qyiTbAxvrdHz yDAr8IKuhs2qSiHioiyvLJ4BTjGOfgTC2tsafE8JOQrW77yI+rfeGdDuGnTR8TgC9T9iHWkNjrm x5uRnS7su3A9Mf8C4EEU8hc7gZac6vR6S6naqQULERYgWohv6y2FDAyXIT5w2aJ6zKSjPQ4QfmN 9mi+pdR7IK0afn4DV4nhr/zW0l/ArB59+SOf5oqVeBQrJHAZz4Dhz8K0Cc X-Google-Smtp-Source: AGHT+IFnNxiixHbf2mkoJM5V89/G69AA9FcCYBOfPqB4X3HFyfkttxdgFGbnPhtVjSq01FoWHgaj7g== X-Received: by 2002:a05:620a:2584:b0:8b2:db27:425b with SMTP id af79cd13be357-8c3893f5a82mr130279585a.74.1767751074679; Tue, 06 Jan 2026 17:57:54 -0800 (PST) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-890770e8cfasm24888506d6.21.2026.01.06.17.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 17:57:53 -0800 (PST) Date: Tue, 06 Jan 2026 20:57:53 -0500 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260106_1639/pstg-lib:20260106_1639/pstg-pwork:20260106_1639 From: Paul Moore To: Ben Dooks , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Cc: serge@hallyn.com, jmorris@namei.org, paul@paul-moore.co, Ben Dooks Subject: Re: [PATCH] lsm: make keys for static branch static References: <20260106171332.69558-1-ben.dooks@codethink.co.uk> In-Reply-To: <20260106171332.69558-1-ben.dooks@codethink.co.uk> On Jan 6, 2026 Ben Dooks wrote: > > The key use for static-branches are not refrenced by name outside > of the security/security.c file, so make them static. This stops > the sparse warnings about "Should it be static?" such as: > > security/security.c: note: in included file: > ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_0' was not declared. Should it be static? > ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_1' was not declared. Should it be static? > ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_2' was not declared. Should it be static? > ./include/linux/lsm_hook_defs.h:30:1: warning: symbol 'security_hook_active_binder_transaction_0' was not declared. Should it be static? > ... > > Signed-off-by: Ben Dooks > --- > security/security.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged into lsm/dev, thanks. -- paul-moore.com