From: bot+bpf-ci@kernel.org
To: ihor.solodrai@linux.dev,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,eddyz87@gmail.com,martin.lau@linux.dev
Cc: memxor@gmail.com,bpf@vger.kernel.org,linux-kernel@vger.kernel.org,kernel-team@meta.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf v1 1/2] bpf: Fix exception exit lock checking for subprogs
Date: Tue, 17 Mar 2026 01:02:56 +0000 (UTC) [thread overview]
Message-ID: <cbc753d17a4e0037aa7e0711ef6cd3a34e7e82dca5a3ef445b7d78af51e5a1cb@mail.kernel.org> (raw)
In-Reply-To: <20260317001325.318004-1-ihor.solodrai@linux.dev>
[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -20911,7 +20911,8 @@ static int process_bpf_exit_full(struct bpf_verifier_env *env,
> * state when it exits.
> */
> int err = check_resource_leak(env, exception_exit,
> - !env->cur_state->curframe,
> + exception_exit || !env->cur_state->curframe,
> + exception_exit ? "bpf_throw" :
> "BPF_EXIT instruction in main prog");
> if (err)
> return err;
This looks like a bug fix but appears to be missing a Fixes: tag.
The buggy check_lock = !curframe logic was introduced when the
inline code in do_check() was refactored into process_bpf_exit_full()
and check_resource_leak() in commit 2d419c44658f ("bpf: add fsession
support"). Should this have:
Fixes: 2d419c44658f ("bpf: add fsession support")
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/23172639489
next prev parent reply other threads:[~2026-03-17 1:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 0:13 Ihor Solodrai
2026-03-17 0:13 ` [PATCH bpf v1 2/2] selftests/bpf: Add tests for bpf_throw lock leak from subprogs Ihor Solodrai
2026-03-17 1:02 ` bot+bpf-ci [this message]
2026-03-17 1:22 ` [PATCH bpf v1 1/2] bpf: Fix exception exit lock checking for subprogs Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbc753d17a4e0037aa7e0711ef6cd3a34e7e82dca5a3ef445b7d78af51e5a1cb@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®