From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752828AbeCOTTg (ORCPT ); Thu, 15 Mar 2018 15:19:36 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:44459 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbeCOTTe (ORCPT ); Thu, 15 Mar 2018 15:19:34 -0400 Subject: Re: [PATCH v2] net: ethernet: ti: cpsw: add check for in-band mode setting with RGMII PHY interface To: Florian Fainelli , =?UTF-8?B?U1ogTGluICjmnpfkuIo=?= =?UTF-8?B?5pm6KQ==?= , "David S. Miller" CC: Schuyler Patton , Ivan Khoronzhuk , Keerthy , Sekhar Nori , , , References: <20180315165603.30471-1-sz.lin@moxa.com> From: Grygorii Strashko Message-ID: Date: Thu, 15 Mar 2018 14:19:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/15/2018 01:29 PM, Florian Fainelli wrote: > On 03/15/2018 11:18 AM, Grygorii Strashko wrote: >> >> >> On 03/15/2018 12:39 PM, Grygorii Strashko wrote: >>> >>> >>> On 03/15/2018 11:56 AM, SZ Lin (林上智) wrote: >>>> According to AM335x TRM[1] 14.3.6.2, AM437x TRM[2] 15.3.6.2 and >>>> DRA7 TRM[3] 24.11.4.8.7.3.3, in-band mode in EXT_EN(bit18) register >>>> is only >>>> available when PHY is configured in RGMII mode with 10Mbps speed. It >>>> will >>>> cause some networking issues without RGMII mode, such as carrier sense >>>> errors and low throughput. TI also mentioned this issue in their >>>> forum[4]. >>>> >>>> This patch adds the check mechanism for PHY interface with RGMII >>>> interface >>>> type, the in-band mode can only be set in RGMII mode with 10Mbps speed. >>>> >>>> References: >>>> [1]: https://www.ti.com/lit/ug/spruh73p/spruh73p.pdf >>>> [2]: http://www.ti.com/lit/ug/spruhl7h/spruhl7h.pdf >>>> [3]: http://www.ti.com/lit/ug/spruic2b/spruic2b.pdf >>>> [4]: https://e2e.ti.com/support/arm/sitara_arm/f/791/p/640765/2392155 >>>> >>>> Suggested-by: Holsety Chen (陳憲輝) >>>> Signed-off-by: SZ Lin (林上智) >>>> Signed-off-by: Schuyler Patton >>>> --- >>>> Changes from v1: >>>> - Use phy_interface_is_rgmii helper function >>>> - Remove blank line >>>> >>> >>> Reviewed-by: Grygorii Strashko >>> >> >> Also could this be marked as stable material 4.9+? > > This is not how it works for networking changes, just make sure you > provide a "Fixes:" tag, and David would usually take care of queueing > the change to -stable accordingly: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n148 > Sry, I know that, but this patch fixes very old commit [1] and it can't be applied to old Kernels without merge conflicts or build errors:(, so I've manually checked if it can be applied to most recent stable kernels and noted kernel versions here. Also there is dependency from phy_interface_is_rgmii() which was merged in v4.2. [1] commit a81d8762d713 ("drivers: net cpsw: Enable In Band mode in cpsw for 10 mbps") ^ went in v3.13 -- regards, -grygorii