From: Christian Loehle <christian.loehle@arm.com>
To: Ryan Newton <rrnewton@gmail.com>, linux-kernel@vger.kernel.org
Cc: sched-ext@lists.linux.dev, tj@kernel.org, arighi@nvidia.com,
newton@meta.com
Subject: Re: [PATCH v3 0/2] sched_ext: lockless peek operation for DSQs
Date: Mon, 6 Oct 2025 18:20:40 +0100 [thread overview]
Message-ID: <cbc8d5bc-4ae7-4b61-81f4-9629857736f3@arm.com> (raw)
In-Reply-To: <20251006170403.3584204-1-rrnewton@gmail.com>
On 10/6/25 18:04, Ryan Newton wrote:
> This allows sched_ext schedulers an inexpensive operation to peek
> at the first element in a queue (DSQ), without creating an iterator
> and acquiring the lock on that queue.
>
> Note that manual testing has thus far included a modified version of the
> example qmap scheduler that exercises peek, as well as a modified
> modified LAVD (from the SCX repo) that exercises peek. The attached test
> passes >1000 stress tests when run in concurrent VMs, and when run
> sequentially on the host kernel. Presently, tested on the below
> workstation and server processors.
> - AMD Ryzen Threadripper PRO 7975WX 32-Cores
> - AMD EPYC 9D64 88-Core Processor
Is the adapted qmap and lavd available somewhere?
>
> Initial experiments indicate a substantial speedup (on schbench) when
> running an SCX scheduler with per-cpu DSQs and peeking each queue to
> retrieve the task with the minimum vruntime across all the CPUs.
>
> ---
> Changes in v3:
> - inline helpers and simplify
> - coding style tweaks
>
> Changes in v2:
> - make peek() only work for user DSQs and error otherwise
> - added a stress test component to the selftest that performs many peeks
> - responded to review comments from tj@kernel.org and arighi@nvidia.com
> - link: https://lore.kernel.org/lkml/20251003195408.675527-1-rrnewton@gmail.com/
>
> v1 link: https://lore.kernel.org/lkml/20251002025722.3420916-1-rrnewton@gmail.com/
>
> Ryan Newton (2):
> sched_ext: Add lockless peek operation for DSQs
> sched_ext: Add a selftest for scx_bpf_dsq_peek
>
> include/linux/sched/ext.h | 1 +
> kernel/sched/ext.c | 56 +++-
> tools/sched_ext/include/scx/common.bpf.h | 1 +
> tools/sched_ext/include/scx/compat.bpf.h | 19 ++
> tools/testing/selftests/sched_ext/Makefile | 1 +
> .../selftests/sched_ext/peek_dsq.bpf.c | 265 ++++++++++++++++++
> tools/testing/selftests/sched_ext/peek_dsq.c | 230 +++++++++++++++
> 7 files changed, 571 insertions(+), 2 deletions(-)
> create mode 100644 tools/testing/selftests/sched_ext/peek_dsq.bpf.c
> create mode 100644 tools/testing/selftests/sched_ext/peek_dsq.c
>
next prev parent reply other threads:[~2025-10-06 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 17:04 Ryan Newton
2025-10-06 17:04 ` [PATCH v3 1/2] sched_ext: Add " Ryan Newton
2025-10-06 17:26 ` Andrea Righi
2025-10-14 22:27 ` Jake Hillion
2025-10-06 17:04 ` [PATCH v3 2/2] sched_ext: Add a selftest for scx_bpf_dsq_peek Ryan Newton
2025-10-06 17:17 ` Christian Loehle
2025-10-06 17:22 ` Andrea Righi
2025-10-06 19:36 ` Andrea Righi
2025-10-06 17:20 ` Christian Loehle [this message]
2025-10-06 17:34 ` [PATCH v3 0/2] sched_ext: lockless peek operation for DSQs Ryan Newton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbc8d5bc-4ae7-4b61-81f4-9629857736f3@arm.com \
--to=christian.loehle@arm.com \
--cc=arighi@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=newton@meta.com \
--cc=rrnewton@gmail.com \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®