From: Andrew Lunn <andrew@lunn.ch>
To: Suraj Gupta <suraj.gupta2@amd.com>
Cc: radhey.shyam.pandey@amd.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
michal.simek@amd.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@amd.com,
harini.katakam@amd.com
Subject: Re: [LINUX PATCH] net: axienet: Fix axiethernet register description
Date: Sat, 13 Jul 2024 16:54:36 +0200 [thread overview]
Message-ID: <cbd29d03-c9bc-4714-b008-ceef9380c46c@lunn.ch> (raw)
In-Reply-To: <20240713131807.418723-1-suraj.gupta2@amd.com>
On Sat, Jul 13, 2024 at 06:48:07PM +0530, Suraj Gupta wrote:
> Rename axiethernet register description to be inline with product guide
> register names. It also removes obsolete registers and bitmasks. There is
> no functional impact since the modified offsets are only renamed.
>
> Rename XAE_PHYC_OFFSET->XAE_RMFC_OFFSET (Only used in ethtool get_regs)
> XAE_MDIO_* : update documentation comment.
> Remove unused Bit masks for Axi Ethernet PHYC register.
> Remove bit masks for MDIO interface MIS, MIP, MIE, MIC registers.
> Rename XAE_FMI -> XAE_FMC.
Might be too way out there, but why not modify the documentation to
fit Linux? This driver is likely to get bug fixes, and renames like
this make it harder to backport those fixes. Documentation on the
other hand just tends to get erratas, either in a separate document,
or appended to the beginning/end. There is no applying patches to
documentation.
Andrew
next prev parent reply other threads:[~2024-07-13 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-13 13:18 Suraj Gupta
2024-07-13 14:54 ` Andrew Lunn [this message]
2024-07-16 19:40 ` Pandey, Radhey Shyam
2024-07-31 15:47 ` Pandey, Radhey Shyam
2024-07-13 14:55 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbd29d03-c9bc-4714-b008-ceef9380c46c@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=harini.katakam@amd.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=suraj.gupta2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®