From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Will McVicker <willmcvicker@google.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: kernel-team@android.com, linux-samsung-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] clk: samsung: update CPU clk registration
Date: Tue, 26 Oct 2021 17:29:46 +0200 [thread overview]
Message-ID: <cbdbf565-6403-39d3-a4cd-817e515d89a0@canonical.com> (raw)
In-Reply-To: <20211015190515.3760577-1-willmcvicker@google.com>
On 15/10/2021 21:05, Will McVicker wrote:
> Convert the remaining exynos clock drivers to use
> samsung_clk_register_cpu() or if possible use
> samsung_cmu_register_one(). With this we can now make
> exynos_register_cpu_clock() a static function so that future CPU clock
> registration changes will use the samsung common clock driver.
>
> The main benefit of this change is that it standardizes the CPU clock
> registration for the samsung clock drivers.
>
> Signed-off-by: Will McVicker <willmcvicker@google.com>
> ---
> drivers/clk/samsung/clk-cpu.c | 2 +-
> drivers/clk/samsung/clk-cpu.h | 7 ----
> drivers/clk/samsung/clk-exynos3250.c | 54 ++++++++++++++--------------
> drivers/clk/samsung/clk-exynos4.c | 25 +++++++------
> drivers/clk/samsung/clk-exynos5250.c | 13 +++----
> drivers/clk/samsung/clk-exynos5420.c | 27 +++++++++-----
> 6 files changed, 67 insertions(+), 61 deletions(-)
>
Looks good. Tested also on Exynos5422 board:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-10-26 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 19:05 Will McVicker
2021-10-25 16:19 ` Will McVicker
2021-10-26 15:29 ` Krzysztof Kozlowski [this message]
2021-11-19 21:56 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbdbf565-6403-39d3-a4cd-817e515d89a0@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=cw00.choi@samsung.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®