From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC8EC433EF for ; Wed, 13 Jul 2022 11:21:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235136AbiGMLV5 (ORCPT ); Wed, 13 Jul 2022 07:21:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231422AbiGMLVz (ORCPT ); Wed, 13 Jul 2022 07:21:55 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1763B102061; Wed, 13 Jul 2022 04:21:54 -0700 (PDT) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LjZrj1ZQmzhZ99; Wed, 13 Jul 2022 19:19:17 +0800 (CST) Received: from kwepemm600010.china.huawei.com (7.193.23.86) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Jul 2022 19:21:52 +0800 Received: from [10.67.110.237] (10.67.110.237) by kwepemm600010.china.huawei.com (7.193.23.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Jul 2022 19:21:51 +0800 Subject: Re: [PATCH 4/5] ARM: stacktrace: Make stack walk callback consistent with generic code To: Mark Brown CC: , , , , , , , , , , , , , , , , , , , , , , References: <20220712021527.109921-1-lihuafei1@huawei.com> <20220712021527.109921-5-lihuafei1@huawei.com> From: Li Huafei Message-ID: Date: Wed, 13 Jul 2022 19:21:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.67.110.237] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600010.china.huawei.com (7.193.23.86) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/7/12 21:34, Mark Brown wrote: > On Tue, Jul 12, 2022 at 10:15:26AM +0800, Li Huafei wrote: > >> In order to use generic arch_stack_walk() code, make stack walk callback >> consistent with it. > It might be useful to say what the changes are here, if nothing else > that makes it easier to review and confirm that the changes are doing > what you intend them to. See my conversion for arm64 for an example. Thanks for the advice. I've looked at the commit:   baa2cd417053 ("arm64: stacktrace: Make stack walk callback consistent with generic code") The description is very clear. It describes the change in detail and gives a reason for making that change a separate commit. The same description applies to the current changes, so I took the commit message directly, just made the s/arm64/ARM/ changes, and updated to v2: https://lore.kernel.org/lkml/20220713110020.85511-1-lihuafei1@huawei.com/ > The actual changes here seem OK though > > Reviewed-by: Mark Brown Thanks for the review! Thanks, Huafei