From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A827CC433EF for ; Mon, 17 Jan 2022 17:21:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239015AbiAQRVe (ORCPT ); Mon, 17 Jan 2022 12:21:34 -0500 Received: from mout.gmx.net ([212.227.15.19]:49061 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236774AbiAQRUf (ORCPT ); Mon, 17 Jan 2022 12:20:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1642440022; bh=Oe482/0i/WLrNkCXVOSQLDJo+BYQo13yR5t/lqWrnFY=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=hhQgz5JnVrEy6KkiPAOQ4XU4369t4ecgVSovc2DuarSXYrJwOLohxakWYQoa9MyAO 7UMGGbTw/k1PnrWUBKenVa2awlD8UpV9kVP5vPREy7UvtQLzP/PvJRPKkT3MEcGcK6 L20gTP/wOT5RA2lb0Va1WkPNKQW4lkhBx9qUx4ss= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.20.60] ([92.116.167.237]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N4QsO-1m9G7c11GA-011TYV; Mon, 17 Jan 2022 18:20:22 +0100 Message-ID: Date: Mon, 17 Jan 2022 18:19:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer Content-Language: en-US To: Daniel Vetter Cc: Thomas Zimmermann , Linus Torvalds , "airlied@gmail.com" , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , Geert Uytterhoeven References: <97d49bca-f5f7-dba4-b62d-b6fcdd4276ac@suse.de> From: Helge Deller In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:CwGx+k2vKlIe81+Xy61ZTTZRrhgIedfMmfUFL2qQ7R0sD1+/wnC ah3MeIxVHGzgSCh8OpE5dUgC6K7/+7ToA7j98VctdiB/D8IB0ayzF/U2Ct4r6MQAarkjhiu SbPsDSrdQUrmpcvGfjpt0n7Cl3zZC1v/JTRGK3Njn9RBrrm95kWqDkQZwMF94y1FE3j3Nr5 kgZBeadDnK1dAcjHQRoFQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:hCwKHzwCHog=:xmZuXJQ5jSJYoM2b5+kIUO 97PPzM+IuZ6++TkQI3+ctf0LqEkIJG3Lm05TTk/pl7pKhpChd2zKwgsD6OOdBQ9tTpznE+nXw AvKGH0EjE0TUMPPf63ZbOJlzqsu4hZw+zz37UdHQu6XvH1dVH7Avpc5PO8+nmTvsLYmuI0JIo yKxkJAP+ai5xWRM4RxW1tQKXt85YWTwS5F6Z64ryVsMOCACtZ/bfycVOdnxHPraLD3Jf/Z4F+ aA6G8DjENyB8JSpbc6Zfcepp1mwHNsY2t/P1KdXmhV9hBoSpYu/f4tWzmaiHxBVp+fjf5B0/h BkfBuBMRHFR8B5QUzNNP9Lxs40tc+Ke6PcJ3K47hNBvHgebaAZsOPEnJA0dqW3yGHL+tYpL+2 9Y3VZaA6PCizAZ+S9SIIZA7pkd08SRSZDq/kfYs/HTWAzLkm/L2my8oJh0f98FH/TZibZJZgR IcVd+lVque44QxqpLJKOSRfdT5eZFPCcN18FKzdOUTs2zA57gmOep+mMia7T4L+kH8dFtSbju 8qfhQFyRHLeym94vCWRV+WT6L5UK3UBwmNDs7gBGub9U6jv1ZuAq5Vq4tXS8AiGWB/8D/M6C1 hlZUy1FPwl5km0FtDuh608N+7kfuNAU7commey2WD8M/Ft2bzgwJ8RIEYTv9sOgNuSTwguUvC d12vjZbNx3pCiLWPoYFXlnyOv2j+vhFVsvZcVyJE0mV4wgXHRBrLbeFFYL7LGe1kpYvAD7HTZ AHRm7a5bGY4MiqLeujdZMFZWYbJQ/j+qZtbCI3jbOcTWC2+9/7mext0tlXp7xc7xfrWViqUjc rI5IlttD9+hlFDeVxObViKTzUzoJLuyqnPqwx+AYFb8bYzDY4z2YFlv7iGISwztIw6ZmRPv4u fW9tEujxKFaJjWfrZcqYwe/cmG2Mhn2sBjmxEpMsbwIhgqLNMTRNksQ10xYeYenWl7hLMtKF/ iQTfVBuQLqs3Y96Htrxs3NrtsTWqEqtFQUyQ0p8fvYBV6+mXHhzQsWmjMc5wwYgubU9k4GNVv 4dd//vybGO+yMvXoXqosMAbOPGcSI5YgKvggSrta+WK0LRyn5TdKEdk+c0Aqg3ukl18e+npcM Syw2gqkHlkJ0F8= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/17/22 17:38, Daniel Vetter wrote: > On Mon, Jan 17, 2022 at 5:22 PM Helge Deller wrote: >> >> On 1/17/22 16:58, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 17.01.22 um 16:42 schrieb Helge Deller: >>>> [...] >>>>>> c) reintroduce the state where fbcon is fast on fbdev. This is impo= rtant for non-DRM machines, >>>>>> either when run on native hardware or in an emulator. >>>>>> d) not break DRM development >>>>>> >>>>>> Especially regarding c) I complained in [1] and got no feedback. I = really would like to >>>>>> understand where the actual problems were and what's necessary to f= ix them. >>>>>> >>>>>> Helge >>>>>> >>>>>> [1] https://lore.kernel.org/r/feea8303-2b83-fc36-972c-4fc8ad723bde@= gmx.de >>> >>> Seems like few people read linux-fbdev these days. >>> I suggest to partly revert the patch to the point were performance >>> gets better again. >> Yes, *please*! >> That would solve my biggest concern. >> >> As far as I can see that's only 2 commits to be reverted: >> b3ec8cdf457e - "fbdev: Garbage collect fbdev scrolling acceleration, pa= rt 1 (from TODO list)" >> 39aead8373b3 - "fbcon: Disable accelerated scrolling"for-next-next >> >> I think both were not related to any 0-day bug reports (but again, I mi= ght be wrong). > > syzbot, not 0day, and there's like a sea of them unfortunately. > There's all kinds of funny races going on when resizing consoles (due The patches above are not about resizing consoles. Even if a resize should happen in between, it's better to introduce some k= ind of big lock instead of completely disable acceleration for est. 58 other graphic card = drivers and slow them down that much that it renders them to become unusable. > to bad locking design) which then blow up, especially in less tested > code. For the sw rendering we've merged a bunch of patches, but you > pretty much have to assume that it's all fairly broken code until it's > rewritten and fully covered with tests. Shadowfb + memcpy is probably > much faster for restoring scrolling performance than anything else > really. That's maybe true for fast new machines with fast PCI busses. But have you measured that on other/older hardware too? There is a good reason why 2D acceleration was introduced. Helge