From: Jens Axboe <axboe@kernel.dk>
To: Colin King <colin.king@canonical.com>, linux-block@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block/DAC960.c: make some arrays static const, shrinks object size
Date: Tue, 21 Aug 2018 11:00:49 -0600 [thread overview]
Message-ID: <cbe876ce-8f1f-1dc3-86fb-b26278277312@kernel.dk> (raw)
In-Reply-To: <20180821091248.8669-1-colin.king@canonical.com>
On 8/21/18 3:12 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the arrays ReadCacheStatus, WriteCacheStatus and
> SenseErrors on the stack but instead make them static const. Makes
> the object code smaller by 47 bytes:
>
> Before:
> text data bss dec hex filename
> 160974 34628 832 196434 2ff52 drivers/block/DAC960.o
>
> After:
> text data bss dec hex filename
> 160671 34884 832 196387 2ff23 drivers/block/DAC960.o
>
> (gcc version 8.2.0 x86_64)
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2018-08-21 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 9:12 Colin King
2018-08-21 17:00 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbe876ce-8f1f-1dc3-86fb-b26278277312@kernel.dk \
--to=axboe@kernel.dk \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®