From: Ian McDonald <imcdnzl@gmail.com>
To: Horst von Brand <vonbrand@inf.utfsm.cl>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Breakage in net/ipv4/tcp_vegas.c
Date: Sun, 13 Nov 2005 07:35:23 +1300 [thread overview]
Message-ID: <cbec11ac0511121035w3f697824l3d1e3351e229fba4@mail.gmail.com> (raw)
In-Reply-To: <200511111336.jABDajMd019962@pincoya.inf.utfsm.cl>
On 11/12/05, Horst von Brand <vonbrand@inf.utfsm.cl> wrote:
> CC [M] net/ipv4/tcp_vegas.o
> net/ipv4/tcp_vegas.c: In function 'tcp_vegas_cong_avoid':
> net/ipv4/tcp_vegas.c:239: error: 'cnt' undeclared (first use in this function)
This has been fixed in the networking tree which I imagine Linus will
merge again soon but here is the fix before then:
Recent TCP changes broke the build.
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
diff --git a/net/ipv4/tcp_vegas.c b/net/ipv4/tcp_vegas.c
index 4376814..b7d296a 100644
--- a/net/ipv4/tcp_vegas.c
+++ b/net/ipv4/tcp_vegas.c
@@ -236,7 +236,7 @@ static void tcp_vegas_cong_avoid(struct
/* We don't have enough RTT samples to do the Vegas
* calculation, so we'll behave like Reno.
*/
- tcp_reno_cong_avoid(sk, ack, seq_rtt, in_flight, cnt);
+ tcp_reno_cong_avoid(sk, ack, seq_rtt, in_flight, flag);
} else {
u32 rtt, target_cwnd, diff;
--
Ian McDonald
http://wand.net.nz/~iam4
WAND Network Research Group
University of Waikato
New Zealand
next prev parent reply other threads:[~2005-11-12 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-11 13:36 Horst von Brand
2005-11-12 18:35 ` Ian McDonald [this message]
2005-11-12 19:43 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbec11ac0511121035w3f697824l3d1e3351e229fba4@mail.gmail.com \
--to=imcdnzl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vonbrand@inf.utfsm.cl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®