From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF771369D74 for ; Tue, 19 May 2026 13:51:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779198682; cv=none; b=dLomF5k6PoY8Cz+OwgZ7ghmyFY+R4Wpd7zf3Ba08KWqngvFXneweXdxqGC4FxrIfoiHzPqLqbZ3qGM898u17Di8/VzK53lKK8yIMeNkCgfybHW1XECWp2GIDunsnUsPPNYug4eXJUZR9zoqCnFQ9qQgWsNQqYAiDWSTZY2+CRns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779198682; c=relaxed/simple; bh=38ZFwskQQfa3ov730T1p7ug/E9VDwdczihPE2NWFdAc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qp9rJ/ZYXrbiPQ1JFQU7scoXrt1iXDIU03XF+IQvHnBS+4vNxpLdiRR/1KMelpzpdM64LTpu/BuQwhGz6VrSsfajmEbmIhSlQeSZA+BsSm+pUDux5kDPrkYOqzEPJik/ow/zT77zW58VPSsEjHYv+XY0idwI+1Tu7ZTPFbqBjH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oBuDS/Xe; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q9FEwWPj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oBuDS/Xe"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q9FEwWPj" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64J8EFMG3612440 for ; Tue, 19 May 2026 13:51:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= laQpefoN7vkeESD532Fomlmi9HvRpWwdwjP+kI9x3eo=; b=oBuDS/XeXaoSgkaE dqDSwxEx86d12NyTFJWC44Hcm7QhplTUdJHGZIj4CI4ITWHbuaeXlshNS4ipHQif 8fXBKNQ5xU1geIYbclY4kXgFkcB/HM+fEvCvdIDxH6l/Mdj79JBFbhVP4AVm3a25 Nc6hiLpzWWRgxRUZc/n/UrcjxziEBzbUgucMHwgFwn9nh608iyXCCeImOdH0TxGS zkihU4hW6QXnt5jTYoyF8Q57GKlwcxEiihfXpt1/F8FEb74c7G/K1+OJgszISqg5 VCmHt7uE4beIdA2ZUORo2A1MpPAU+ft2/VX4UxIKcnav5EuxToemRPCbYaazEk4D eGwj5Q== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8m64sc20-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 13:51:19 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-837c4eb3bdfso2385682b3a.2 for ; Tue, 19 May 2026 06:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779198678; x=1779803478; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=laQpefoN7vkeESD532Fomlmi9HvRpWwdwjP+kI9x3eo=; b=Q9FEwWPjKB7NuH3w4lqlk38zOhUJ69Wt9J9klpHgeTWtwF7YIlyZeT7PXTEdZFuG17 0rd6O32R191Y4Ip7ZJQLCHUikdtOLW3FhXHbakjq0LZBOBj8MtmJ8Nw+BQvZYPeKNUFF 8ILFL8a/+BwNcUBQXSKh3B1sc7B4ErsFClM9CvD2AvMyiUpaoCUbjGz14NoNE85/Z3OB pJ6jj9eBrYgRrOK8DKDoj8reo33ty44G1b1fV5FZ7EiJn57NFbOPe5nBPuKG5WJ2XYnN luKaVeBbmVuxYcQd/j40BzgSWeGrvYJRRe6DXoX1cY7CiTOi2YPwfFU1EvQt8ClkNVV4 0XkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779198678; x=1779803478; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=laQpefoN7vkeESD532Fomlmi9HvRpWwdwjP+kI9x3eo=; b=MLkCFJjQKPjbVVqnMe2S2/bfp9voT//dgP2Eq+0e6XkkqHczAlnNNEUCrx9TlSGo+J I3yYGuHcae0+OhxEUFrd/Ie3g/tqibSS/uoFHtoXGLCTWRvNt4/S6hHtHtfpb/1Wy3Na ctlOc8tmsiKlnFdbqxyYysSJwu/gXjLDHH3PVrijF2Qe0KnC6FNS76t9RNww7tRYG5Jk ymhHKe091LZAt8f5mXZFxVxT6kVR5LhPvqy93d761jQcxazeyOaGDx9gaW3n59Hh5kdD HQXKNScr1ErZUXFw98F9B7W9YPLOXQPuuX3yc6T2bncbodi4Q35SDUpfX8J5AFM+DKB7 SDDg== X-Forwarded-Encrypted: i=1; AFNElJ/1vf++uGt8sjae7fQkwZwpxp8USSEITCkD2wZhVVevcjf11qdTqdUssI0LWSaOQCKUVc2KY1lFWuve458=@vger.kernel.org X-Gm-Message-State: AOJu0Yx22jolqsq54ioB5xytPJ4Zv53ibxHriPil12KU3zZtUkFCN1Bz 3crM/8GHaIxkHeicR3Q6CeXlY58vhp4pe8Ur/TLCt/mjqgKQ12OeDKPYV+HjDAQbGQOUPtJm7IO kvVnr9QgegT5Ty+labLo39bpJ7BzhpCAX9rpGNdXhBn9eMepviDCyEsbYPUcrKlKJYBc= X-Gm-Gg: Acq92OHtUV5gnxN2GMvksF1MrKyn4OuyQpmEGHv4SQ2cluHR79OvEsjip/2xA6599x9 /hZ/A8M8VCWUQZ2dWCM+3P3xgxJVqbuf5Y5ILv26lVsmfNlmcLRZKcfXxnoDp8TQiAILLe4kFIu Mc+dLIs/BF+JFoUh7uCECq4mChSJSlsJcfsjjWJCcJ2NV6bG4W/jdhmpfzau8HAXdfWz1TWNnRG msvPAQJ8YEGPq3hnRARaOuNSixNZgI1xl0zN1eXPYStNg7B270NE5CLebn+96uWV8mTlsZXoQ/L l0IwSq+BIEzExyka/ANQ4TlwQk28xSozSg7s2BATYILq/Czg5cNFbLA/4Az3nxARdJuEFAuOLaL nlMOHaXuzb0C0aAKYOHxo2L7IB/dVL4UTtx5M7T67WkT/cb+MmqsaP0GudGzhdSv4sk42+WVgFr 9uVkQ1OjC9ncjjqHpQHg== X-Received: by 2002:a05:6a00:4293:b0:835:41f3:f440 with SMTP id d2e1a72fcca58-83f33bf68e4mr18608835b3a.14.1779198678371; Tue, 19 May 2026 06:51:18 -0700 (PDT) X-Received: by 2002:a05:6a00:4293:b0:835:41f3:f440 with SMTP id d2e1a72fcca58-83f33bf68e4mr18608773b3a.14.1779198677755; Tue, 19 May 2026 06:51:17 -0700 (PDT) Received: from [10.133.33.109] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19664a59sm18398076b3a.1.2026.05.19.06.51.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 06:51:17 -0700 (PDT) Message-ID: Date: Tue, 19 May 2026 21:51:11 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] cpufreq: Extract cpufreq_policy_init_qos() function To: Pierre Gondois , linux-kernel@vger.kernel.org Cc: Jie Zhan , Lifeng Zheng , Ionela Voinescu , Sumit Gupta , "Rafael J. Wysocki" , Viresh Kumar , Jonathan Corbet , Shuah Khan , Huang Rui , Mario Limonciello , Perry Yuan , K Prateek Nayak , Srinivas Pandruvada , Len Brown , Saravana Kannan , linux-pm@vger.kernel.org, linux-doc@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: <20260511135538.522653-1-pierre.gondois@arm.com> <20260511135538.522653-2-pierre.gondois@arm.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20260511135538.522653-2-pierre.gondois@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDEzNyBTYWx0ZWRfX0V2tR4dMvdhE O/OuYp2RytBV+v9kIQdOjUVklYlEC7TRYeN75FuwlIUEXiT3GyoCzP5UfTguJyqSqhHDx39r2Ux EEIZ5E6j1fPHzb7g0AelDOyuYuJAsodnJY294wCL1X8uhvn4jq0uvLuSMjC+KB/Pfo9JhcjYZFu O9HoAs5WwcypMV3H19/R7v9M6CQci183LHk2ANyJhplSWU/pFfLISyQBHZnv99ZujNVrb1BaZ6p bUc2C+6DP2T7ZuAIpSGJ98UHIc3f4dl0hqCvH26hHhXxQIJ4CBN6VKHqlyK7/4xqKrDu9+J9BO5 E7FLuE6nUMW/9edrGt7BBVpHx0LZEzc7ROyWQl42cB7uH2ndUrI9Ks1A+iNrcatHiBxQs7Uh3/3 q9lvC5Q/oLfbdO04A6y58LxRopDISLBj0pcPB+Y4LxhsETzMdGtIgffwS87H+ZWXkpQrY3o7EEh 2Tr4xD9d40IkYPfYHMQ== X-Proofpoint-GUID: dMcqb8KhMUh8rBj2q24wxAY-OsqXvbxH X-Proofpoint-ORIG-GUID: dMcqb8KhMUh8rBj2q24wxAY-OsqXvbxH X-Authority-Analysis: v=2.4 cv=J8aaKgnS c=1 sm=1 tr=0 ts=6a0c6ad7 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=7CQSdrXTAAAA:8 a=EUspDBNiAAAA:8 a=bSUqCxsoTDCc9_nI8b0A:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190137 On 5/11/2026 9:55 PM, Pierre Gondois wrote: > Extract the QoS related logic from cpufreq_policy_online() > to make the function shorter/simpler. > > The logic is placed in cpufreq_policy_init_qos() and is > now executed right after the following calls: > - cpufreq_driver->init() > - cpufreq_table_validate_and_sort() > > This helps preparing following patches that will, > in cpufreq_policy_init_qos(): > - treat the policy->min/max values set by drivers as QoS requests. > - set a default policy->min/max value to all policies. > > No functional change. > > Signed-off-by: Pierre Gondois Looks good to me apart from a minor nit inline. Reviewed-by: Zhongqiu Han > --- > drivers/cpufreq/cpufreq.c | 53 +++++++++++++++++++++++---------------- > 1 file changed, 32 insertions(+), 21 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 44eb1b7e7fc1b..034603c2af325 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -1397,6 +1397,32 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy) > kfree(policy); > } > > +static int cpufreq_policy_init_qos(struct cpufreq_policy *policy) > +{ > + int ret; > + > + if (policy->boost_supported) { > + ret = freq_qos_add_request(&policy->constraints, > + &policy->boost_freq_req, > + FREQ_QOS_MAX, > + policy->cpuinfo.max_freq); > + if (ret < 0) > + return ret; > + } > + > + ret = freq_qos_add_request(&policy->constraints, &policy->min_freq_req, > + FREQ_QOS_MIN, FREQ_QOS_MIN_DEFAULT_VALUE); > + if (ret < 0) > + return ret; > + > + ret = freq_qos_add_request(&policy->constraints, &policy->max_freq_req, > + FREQ_QOS_MAX, FREQ_QOS_MAX_DEFAULT_VALUE); > + if (ret < 0) > + return ret; > + > + return ret; Just minor nit: cpufreq_policy_init_qos() could perhaps return 0 on success. In the original inline code we only checked 'ret < 0', so positive return values were not intended to propagate as part of the API contract. Returning 'ret' here may expose a positive success code (e.g. 1) and make the helper easier to misuse (e.g. 'if (ret)' checks). Returning 0 would keep the semantics unambiguous. Alternatively, if this behavior is intentional, it might be helpful to document it with a kdoc comment (e.g. that the function may return 0 or 1 on success and callers should check 'ret < 0' for errors). > +} > + > static int cpufreq_policy_online(struct cpufreq_policy *policy, > unsigned int cpu, bool new_policy) > { > @@ -1442,6 +1468,12 @@ static int cpufreq_policy_online(struct cpufreq_policy *policy, > if (ret) > goto out_offline_policy; > > + if (new_policy) { > + ret = cpufreq_policy_init_qos(policy); > + if (ret < 0) > + goto out_offline_policy; > + } > + > /* related_cpus should at least include policy->cpus. */ > cpumask_copy(policy->related_cpus, policy->cpus); > } > @@ -1458,27 +1490,6 @@ static int cpufreq_policy_online(struct cpufreq_policy *policy, > add_cpu_dev_symlink(policy, j, get_cpu_device(j)); > } > > - if (policy->boost_supported) { > - ret = freq_qos_add_request(&policy->constraints, > - &policy->boost_freq_req, > - FREQ_QOS_MAX, > - policy->cpuinfo.max_freq); > - if (ret < 0) > - goto out_destroy_policy; > - } > - > - ret = freq_qos_add_request(&policy->constraints, > - &policy->min_freq_req, FREQ_QOS_MIN, > - FREQ_QOS_MIN_DEFAULT_VALUE); > - if (ret < 0) > - goto out_destroy_policy; > - > - ret = freq_qos_add_request(&policy->constraints, > - &policy->max_freq_req, FREQ_QOS_MAX, > - FREQ_QOS_MAX_DEFAULT_VALUE); > - if (ret < 0) > - goto out_destroy_policy; > - > blocking_notifier_call_chain(&cpufreq_policy_notifier_list, > CPUFREQ_CREATE_POLICY, policy); > } -- Thx and BRs, Zhongqiu Han