From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84294231853 for ; Thu, 3 Jul 2025 04:18:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751516308; cv=none; b=gx+ZLdC4C/b9RHlTepWDU1TUeE8BSgKoBm4sIq0MmSYoI/J42SpXJKhw54c4666vuykEYkDFN2i8VLqI/YZx/k+Sr2CiwN9E9kowChZiViUIUDdb/sy2LgB6LYUMe09OgEs5SkF8JlHzxvL7MtklbmxjrnKMn6scfr792hx3TL4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751516308; c=relaxed/simple; bh=yYuF9F6UXPe1+nRemOM3FS1DclLed2FkVUesNJnZsl4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=paijBh2Gtxygc+6X9VrvohHhFi71Z0ZGzETmyOHaiGdvyxap6jZx8AiNYAEO5CV51D5BpVK4lGHJdzgCr7gzV8SqOSVm7casUHvOO8mAs28jmwqJnYlelVRHdu50inpZhhvAphxyxXuRI3HWpkMPhpvnAXalgYQCZ11sgiT2qDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ODOEFZtG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ODOEFZtG" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 562L72tV028446 for ; Thu, 3 Jul 2025 04:18:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1NaW9HsleXJDnHysTKiBKa5wP27JduvuH7fRxzKY+H4=; b=ODOEFZtG4zyejscx uKOWP/fCjR/RvatpjE9PJ8m9hu75uZzUGzlmjrt7I+9ONy0ISBcnGDl6sktSwpRK fgpznk2h74l38h8CZ40GXIGP8FAHa/fRMyMyD8GXrfbUeilT3urXKEAhFM61Qns0 GGHnJcpCjNjKTid91ThxBJo45j8KKLFGjlak0QF3MDsrprC+pPsR6qApWbSnwc0A u8UXqLfV8ST6tzvy5udKXHnqkzBAr7azkYm2RjOPyIicfUlOpoCKsGRhVpHVxRsl 5/9HtbZo1IHMtsG45DUYRTZDvqeQmKHLFAnGHiE+YI7s6RpnoFYvTZv7JVlqrKfT TcOzhA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47j7bvy4u8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 03 Jul 2025 04:18:25 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-236725af87fso98062215ad.3 for ; Wed, 02 Jul 2025 21:18:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751516304; x=1752121104; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1NaW9HsleXJDnHysTKiBKa5wP27JduvuH7fRxzKY+H4=; b=cU7fuglvrttH2+PlNu/joBk1Z9p5j14uiy/hx0ywNYwKwV9Jb7V4D/iUeB/LJ3jyiD pHa/Sct1QPJEJ3Cy0zlM4xVvONu/KVQPCYqLTX2xhxUmZJWpW3YyG3URS6dMAniLdeyO lF78xuV25LKTpwNdAIJfq6R0cN21gTU81pxRTrdo+REihD7KdmDIsgrN0WDHiWxlpOyC kLpGm/Wh3M98BaS1Zd5l8JYKEO9iIlt8T4VzuVnmgehc11ls0ZTXZSHgVix/1SQE3mF2 R8qvqR4VcSCRfAHjwP4Ij7zAPdvuBuW3Te4aiQuEP9POm30ElzfeECDgj9hmTcqpHcKW MX3g== X-Forwarded-Encrypted: i=1; AJvYcCX4Gros5vskVs8vhZ9F2ZmujqMB5REQ7Vhccy6zX+cLYPygQCoBM0BsT1t07yl+5O0OBAU/49cfBbA4nX8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5jaMIHLYjBnG4LpdWZq7GcROKEg0/4hPr1Q13cZ0q2Nk1okUG 0PkHM1BJJeaSERweX9pc9zuiV5/EhXd0sfBZIDGLb72Ek4ho6Es2ODHpJrQFgS4kGkeWvUiiKm0 tO47zN/lSMJP+JGyUlkIOVMGOzDVa9SRD1rELKbONwEh0ISNxspefi/8Qnslbb/cTrzk= X-Gm-Gg: ASbGnctzsdbNIQhdQ9ng4hVaFvToNiD0VQpfhnOAEQU//3VrNXrKWdHiTVlVqswVTgi DcGJ5c30+lBArdUOblfzCENNBH3Di9AXEYxLWg7aYAgltJHq6AL/CCiKbjlPByPCgkkRTuuFzpp gsp2xZPmtfymdI6P5D2q7Qc2dsq/3Y67CAnVoGyh8y2tZjlamuonHuvlcEUA7O7oZ+Q/naJoSHM nkYH+Sd7A315BT0MZEJmyhJtA3slqeSyz0G6mwOd8VUUXIHXpKxyrRmWkj1e3b3j8CVjG9RgcDa FsMWB3CpRAfMkR+mCmUlnvXbxqAbmHUvcouQGvbHXVrbOylLhUqR X-Received: by 2002:a17:902:ea0d:b0:23c:6cc2:feb9 with SMTP id d9443c01a7336-23c6e5d52ffmr79875305ad.45.1751516304608; Wed, 02 Jul 2025 21:18:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEiJQOQ3rj9Z3Ib0vpUq3Vmcwr9EZOVs8di8axva0PyX0K2M8GE7BrJgKKE40SijB5rZCol7A== X-Received: by 2002:a17:902:ea0d:b0:23c:6cc2:feb9 with SMTP id d9443c01a7336-23c6e5d52ffmr79875065ad.45.1751516304213; Wed, 02 Jul 2025 21:18:24 -0700 (PDT) Received: from [10.218.37.122] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23acb2e3b40sm148262145ad.26.2025.07.02.21.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 21:18:23 -0700 (PDT) Message-ID: Date: Thu, 3 Jul 2025 09:48:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] PCI: qcom: Add support for multi-root port To: Manivannan Sadhasivam Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_mrana@quicinc.com References: <20250702-perst-v5-0-920b3d1f6ee1@qti.qualcomm.com> <20250702-perst-v5-2-920b3d1f6ee1@qti.qualcomm.com> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: jBOQV1KUU7LYYhxotyYr2e0WHACbYn7I X-Authority-Analysis: v=2.4 cv=RJCzH5i+ c=1 sm=1 tr=0 ts=68660491 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=elFezDTcsRQGgYhLSLwA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: jBOQV1KUU7LYYhxotyYr2e0WHACbYn7I X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDAzMSBTYWx0ZWRfX4kHf1CiAkVz4 aHhQbUSlNNLlHxK4ywW6r/9MV9w105Nc8nH2X6MY/Lj2FfWi5E4WJrF81D8KAtCTEpvY41RNnKO 7TGCqM/OTn3KWmkaAZ3ekbsd4K8OHdfhnHuk58KPzyev2NjX1hy5AplsFQIKpnNX3DVYxWIEpgg CQyNacMTWMwLVfA/8Wf8NkfBubZtSMQ6Salvr9I9ZFBuJkFuZkL5pMjXS9hKsZFiA2b4/wEwt4I IJevyMe2L7wu+FKRobGTmhu0sE7p+s0npkUQ7sNTRkc0pOjV35F/duhwIsx99/A1Qvty+VQX0qZ z7s9pG82O8A2MKAexJkJLEroSL3hFpXfj5xucJZFWA04vocFpxGR95ENw0Yk9/X/br10vQnYa5W uRewUteVpxThdHyDkaB7dAl+jRkz3WwCb+kZTZ2x4yiXVFHhStwe6dgIAacF0akGJckjkm9X X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_01,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=999 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030031 On 7/2/2025 9:03 PM, Manivannan Sadhasivam wrote: > On Wed, Jul 02, 2025 at 04:50:42PM GMT, Krishna Chaitanya Chundru wrote: > > [...] > >> - ret = phy_init(pcie->phy); >> - if (ret) >> - goto err_pm_runtime_put; >> + for_each_available_child_of_node(dev->of_node, of_port) { >> + ret = qcom_pcie_parse_port(pcie, of_port); >> + of_node_put(of_port); >> + if (ret) { >> + if (ret != -ENOENT) { >> + dev_err_probe(pci->dev, ret, >> + "Failed to parse port nodes %d\n", >> + ret); >> + goto err_port_del; >> + } >> + break; >> + } >> + } >> + >> + /* >> + * In the case of properties not populated in root port, fallback to the >> + * legacy method of parsing the host bridge node. This is to maintain DT >> + * backwards compatibility. >> + */ >> + if (ret) { >> + pcie->phy = devm_phy_optional_get(dev, "pciephy"); >> + if (IS_ERR(pcie->phy)) { >> + ret = PTR_ERR(pcie->phy); >> + goto err_pm_runtime_put; > > Shouldn't this and below be err_port_del? > This is a legacy way of parsing property, if the execution comes here means the port parsing has failed and ports are not created. so err_port_del will not have any effect. - Krishna Chaitanya. > - Mani >