From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F13272D77E9 for ; Mon, 8 Dec 2025 10:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765189559; cv=none; b=GwD3Oa+vvDoHx61Wzh5MjAaBg3EdE/DcDtFQzL+ahtZVwxJ6PsxflqPApPLaCmLI1mcvBSEbE72XkmDNdhIpTa8NVcAEJVpEb6Q5gh47LzyJxksMXZ87CwUw1aaT67oKRFLtmc4RWw6TgyV8Jn2KxGzwg0g4fmbRxBZk59BsSrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765189559; c=relaxed/simple; bh=CFdVGbAK5X4m8wQ3xQyQNHxuchIc/pQWBeMbX79bX/g=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=E3mtvwKLnjNl7UnOdwCoKdoszBlX0+tPYLxyFwssJx2b7hsfF8hMZ73z17V8n9m/kEGN3WVCrCsZoIEPaWBlgp5IV8O+0emi8bqzA8Lrq4kwcvf5RsTLeiWjmQP8NATjIJtRBli8xIbsPkgR4wLLE2xch7lL4IJ2aYYB2dPvOaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rp1DHBk7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L59QFXVA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rp1DHBk7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L59QFXVA" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B89FGIl3863286 for ; Mon, 8 Dec 2025 10:25:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ulpUzcOI0DOsr/m9KEAJ8744zQ8VdOfiauSWUgs8hgE=; b=Rp1DHBk7C2eRzrSv NORUK12i3AKIdww5kyw6l+rY4yA/6xy2fKPt/vXsTvikhjBXM7GqjwH6R9IYgjMd zmnb6pREVZgkC9D1e3P7Cr4vJSMjdHZzcscKmPkcw/DIV0G3fbBafiOlr1qAnBc1 q96YrCyfvhc54EuYMeCMfme1BBAk28/kXRXsc4+5h05g7BRRGDWZrn8B91YBfWw7 LWy3nlLFNUUqWO1ksXEYS+itZ7x54IHC6NpcX/QA50YmAR1xghCSdbroQ6uv00bZ j7tBp27r/27FHOhZEbRJZSPNHwvUkjidQJqtgl+21mGYPE9ZAAJnTKgSZAmg1Z4b ZfHk0Q== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4awuvg0721-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Dec 2025 10:25:56 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-7aa9f595688so6861812b3a.2 for ; Mon, 08 Dec 2025 02:25:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765189556; x=1765794356; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ulpUzcOI0DOsr/m9KEAJ8744zQ8VdOfiauSWUgs8hgE=; b=L59QFXVAR6d1HuXNFQYhflvhcSGDo6l/amq5pJ0dp4ZnYcjbHft/dJ0OtNAVDpO9BU voBDVSsGmkYxoYjcJmwDa8mudb4g6XPPFiBWbV0u6g1hszXy4vwZ6TLiQV5hQCUtEdKh LbI60JSiYaEl8p5frpO4+pB2l3dvqgvp27ZH8NruLZAaeJMxnwM3V4CS0gZFaEfpcU8M NmbZj0TbagtGcXkOY5vO3IPEAx+6sudXlM0fKhSHiyeuguy/5WtZ+qVe7LNLIS+hhYzz vYqMkLJR+8Uazaa0qScz0Xq21RZiZ9RP4IncMloDtZh653R1iXtzAH48XFBdfbsg3b9y vSig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765189556; x=1765794356; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ulpUzcOI0DOsr/m9KEAJ8744zQ8VdOfiauSWUgs8hgE=; b=Nq48j+awc1DY+4KMKAWungqMsDPY+7t9Nz+W29/Deb6DaiPe/7FCYzQoeNn7JWuH/0 JqPtDWz38KSmpERWVX8Ym3Z/Gp6LQXixDZuly5JGbzQHN89XYeYIxbKZH/2qhu81HLoA 8zMPEQrA/DfV2GIpOU4goLZ3+zUDy4c67z5sZk8geQMosj+RheItNhlex2/ywhB7jz3X trYWGA/2OnysKshg5G3R4khFHBabvMsNpjjd/A03tebkr3RoBup34FQzx1D+QwomRDW2 +ayOAe3qsofSOyfXOV8RjwVQYINgW1ixpHcwKB0RRWfTtWUcRGCotC7SIntvpS+VTDGu +HGQ== X-Forwarded-Encrypted: i=1; AJvYcCW/NAs+xNmUDFWFXEIwCPADNAKocbRqwcBLw47EqN1hEocHq5BNcv0ipd/zukkdQ1WbFYnKYuFLdsoNJkE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxg8HeQuGDWYquB6y3uPyo20hwI4TJ4/IVX0PFPeRFrmu5M2nIv bzJeOkcqoQk2QgaJnNVtk0moeWS9L3152vzyhBqlz+hBteTsm3dV9vjKSZ8seGlGFNXSaU81eRJ qVHn4Q/D2k6XDUm3VT2BODRmNglusuCoNgvNtppta2NfFji/yBk55kD/I3fZHfbo1vDQ= X-Gm-Gg: ASbGnctUrInlpDjQOWIFp39cZAUJ5wQ8cOQ9YqWaXJlUzsULtv+X3omZ8WL1C9cxNB2 KZBRauJh49Xc9hi6Hm+yzpXr2kEI+kVAPBLei3K2UwXxa67S1vomyoAN+E+FM2WJg7PMBxvYrCK uJgrmFwNEsrp4Pd1Cou4Zdp07PunaprIlp+xSbHwCKLS8X58+/A5U8M8/CXaL57PKasdjN1sbhb rsXgJ0K1wHBWHy70xOJwp42O56DVbwYD4AY1NelPbtZIxxqk96WqqwjFVVLzoS0Xdt39fU4A6vc GZtFdJgon1Nz6kVd5wTp49sYCQYGiPMKk6OJqe2JkwSbG5ICsnAdlYRUwMS7kHt8v4V1Mo73sR4 PB2cMz91xpPi/oG1E35R4EzjCLqaP971DtF8Q+X2+LV/V5WaIXI6rO3A= X-Received: by 2002:a05:6a21:85:b0:366:19e9:f43 with SMTP id adf61e73a8af0-36619e91026mr4486318637.6.1765189555518; Mon, 08 Dec 2025 02:25:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHHi4NgRf4xCP5w/2kWJWdtK5tmc7qqJ+20GvzzvL4l1ADN7TyD9p63Q+t6ddAUDt4M0XxPXQ== X-Received: by 2002:a05:6a21:85:b0:366:19e9:f43 with SMTP id adf61e73a8af0-36619e91026mr4486301637.6.1765189555057; Mon, 08 Dec 2025 02:25:55 -0800 (PST) Received: from [10.152.204.0] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bf6817395ccsm11711435a12.5.2025.12.08.02.25.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Dec 2025 02:25:54 -0800 (PST) Message-ID: Date: Mon, 8 Dec 2025 15:55:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] wifi: ath11k: fix qmi memory allocation logic for CALDB region Content-Language: en-US From: Vasanthakumar Thiagarajan To: Alexandru Gagniuc , jjohnson@kernel.org, ath11k@lists.infradead.org, "Rob Herring (Arm)" Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jeff Johnson References: <20251206175829.2573256-1-mr.nuke.me@gmail.com> <01a05a49-ae5f-a3ec-7685-02a5f7cb9652@oss.qualcomm.com> In-Reply-To: <01a05a49-ae5f-a3ec-7685-02a5f7cb9652@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDA4OCBTYWx0ZWRfX8Qpw32FqJJBe SYh5eg3v2sCvR/mRy7f4BkbujVJqSCY+vRo3zO2SaV8YPual3ibLW1DKBQJXQ/3QoHjSJvCMmq4 +M3t2H3gtW+lXdJSYNcGr5Tg4yJeIZJx6/RiIHZVio+pP8rkYdAHHQszUwxD3cdp6i1IS9nLsFJ TuWkfHhIDn2krdCf17JnJi+i+/x1K7MafJASFUDeLnuYZiDv4NoGdgs+q/BQxwFeQ4VzuznpZAe lx1RjO3HCVOcgy33Xy+8CRyFPyvILP3aPNJLHLa4LrH3lQcIT8GaZWJJ9RjyHrYj4UjtJFvuslW YvAt7rX6+SlijaRkQzt7E5QE70n+T1wy8raFwUvLFU564qC62PtEYQ4n3hNai6GSbywJ6jnM78q WRqRV0K1GnQRWoVCKnMnisShW/6GCA== X-Proofpoint-ORIG-GUID: bOfK_ijtiOzMZu7bc0yD5bjskvS3h61b X-Authority-Analysis: v=2.4 cv=cqSWUl4i c=1 sm=1 tr=0 ts=6936a7b4 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=cJq7uKxvQhbKIWGweLgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: bOfK_ijtiOzMZu7bc0yD5bjskvS3h61b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 bulkscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080088 On 12/8/2025 3:38 PM, Vasanthakumar Thiagarajan wrote: > > > On 12/6/2025 11:28 PM, Alexandru Gagniuc wrote: >> Memory region assignment in ath11k_qmi_assign_target_mem_chunk() >> assumes that: >>    1. firmware will make a HOST_DDR_REGION_TYPE request, and >>    2. this request is processed before CALDB_MEM_REGION_TYPE >> >> In this case CALDB_MEM_REGION_TYPE, can safely be assigned immediately >> after the host region. >> >> However, if the HOST_DDR_REGION_TYPE request is not made, or the > > AFAICT, this is highly unlikely as HOST_DDR_REGION_TYPE will always be before > CALDB_MEM_REGION_TYPE. > >> reserved-memory node is not present, then res.start and res.end are 0, >> and host_ddr_sz remains uninitialized. The physical address should >> fall back to ATH11K_QMI_CALDB_ADDRESS. That doesn't happen: >> >> resource_size(&res) returns 1 for an empty resource, and thus the if >> clause never takes the fallback path. ab->qmi.target_mem[idx].paddr >> is assigned the uninitialized value of host_ddr_sz + 0 (res.start). >> >> Use "if (res.end > res.start)" for the predicate, which correctly >> falls back to ATH11K_QMI_CALDB_ADDRESS. >> >> Fixes: 900730dc4705 ("wifi: ath: Use of_reserved_mem_region_to_resource() for >> "memory-region"") >> >> Cc: stable@vger.kernel.org # v6.18 >> Signed-off-by: Alexandru Gagniuc >> --- >>   drivers/net/wireless/ath/ath11k/qmi.c | 4 ++-- >>   1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c >> index aea56c38bf8f3..6cc26d1c1e2a4 100644 >> --- a/drivers/net/wireless/ath/ath11k/qmi.c >> +++ b/drivers/net/wireless/ath/ath11k/qmi.c >> @@ -2054,7 +2054,7 @@ static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base *ab) >>                   return ret; >>               } >> -            if (res.end - res.start + 1 < ab->qmi.target_mem[i].size) { >> +            if (resource_size(&res) < ab->qmi.target_mem[i].size) { >>                   ath11k_dbg(ab, ATH11K_DBG_QMI, >>                          "fail to assign memory of sz\n"); >>                   return -EINVAL; >> @@ -2086,7 +2086,7 @@ static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base *ab) >>               } >>               if (ath11k_core_coldboot_cal_support(ab)) { >> -                if (resource_size(&res)) { >> +                if (res.end > res.start) { >>                       ab->qmi.target_mem[idx].paddr = >>                               res.start + host_ddr_sz; >>                       ab->qmi.target_mem[idx].iaddr = > > The rest looks good. > > Reviewed-by: Vasanthakumar Thiagarajan > Well, since CALDB_MEM_REGION_TYPE will always come only after HOST_DDR_REGION_TYPE we'll not be running into this issue in real deployment with ath11k firmware binaries available in public.