From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 679EF3128B2 for ; Thu, 23 Apr 2026 03:28:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776914933; cv=none; b=cU1FVmMWb8v9beZMk/yx2k3XH5yOiyZIohzD9sJAULC/QjLTNsFjQ58TAToC9lXwAcV5RFIdglpoiLjBaK+PGYdg+U4Uh1o5ClqdlPXdgE0qYcrHJPIwXtPe+wrU8M8rOSgINNnmQFk6GIL6h0mo8YBWJVCPrrmGrxkkr53qRec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776914933; c=relaxed/simple; bh=Sk17jgQn0p+IPpeLlf+nKkBcgZNBQmPMRfThpI8Ovu0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EcQvci+12ffgjzB6tdFN5mxXN+PaxWjZIgnS26mIeJC/24wCY5AveCyWPH3X5zQd2nUa121DGEOwRlrLu+Ep6VnmUIOkzUAXAwDz8kJdBaueGn/8QTj4PRF8o5/Mv8/NnZYypG1GxDgmMHGu2wabo23DXAm1YUlHdtwz1z7GkDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HAncwQT1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=belAdOZn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HAncwQT1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="belAdOZn" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N2d1mZ3528257 for ; Thu, 23 Apr 2026 03:28:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Kb3paQVuF8IH5wHvAH6d5Sw/eLOL+1qrUzUoZXFmmuY=; b=HAncwQT1ulJYY4Hh 1gRECaxEMrC07fwqQfR9/rgjdI5ys/e5/XoR2qEUjI7XndBIcXuPBi2V6IwuW4ra 8KvSmQnIi0p349ZpUIipq229EiR/6w0hyYUcjn5SmpkXQscFr0P9//F3t+8dS2LA zIxJsohxewGgPDiVUF5UvCCqth3NgQAWVtOmtXqfXjRSZzESHJ3hJEzjbfdWCuNY JnE4MP1Cs0OSYbjpG3beIshwe5a6WnlJN69yl7T2YAEfcx5y1HDnAGN5QLF7FDGP 2EG4xhc6VPd/IvLXWs+xRBGlbH5TIHzokYzK7Kq4pvWBw0DfGEkeP4OiOgpc+Wgb qZ8IcQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq16wt277-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 03:28:51 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c7ba03ecdc6so447814a12.2 for ; Wed, 22 Apr 2026 20:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776914930; x=1777519730; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Kb3paQVuF8IH5wHvAH6d5Sw/eLOL+1qrUzUoZXFmmuY=; b=belAdOZny2tH0O/4v7p8aeBWjBHAwM2tDoz2QXBpnnlESa5k9KxSaK+F05sQ1axlQc MyK1s/xxmi7SxC2XkGhYjgTdO6f6ahbkhCCeI+frpVBdMmUnfMHl9VJkaAlMO3QMCKw6 g1pqiYBQ4DmCVH384hsBR1Zz0dryLtsrUxPpTo9b5r6HNPutVjUHbVoLQNYjpVgUYykR i04crVFyFWIQSriMKRa2psNOpYE6mXq3CWm2cnp/VKeTXqsWoGzwx+4c5bwnFHTzcewo dRf6JkhVGjdKPv0AZBi/r7c/xW17S526FTwfqXX3WHrcLFPwkgE1aEvw8dhUf3X8O3Vh kUPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776914930; x=1777519730; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Kb3paQVuF8IH5wHvAH6d5Sw/eLOL+1qrUzUoZXFmmuY=; b=dzLy3Gu0nDdLCh77vXU2S7a1cPaW7kFwhZFBLfzJcp8OQK04K71hqOlChbNyA9AvLk dtIV7W/qq0qIjZ5raMqLpinXQPd1G6GncZic1vYdtlUTm1yKqSKr6rN/4QqI7ZMQaJU9 aAbNcwukAY7Xym2EglwVldaF2BAFYeyA8axH15b35ViG4mNuL1lfeLl2fn9gjvqM6sbk d7ibnnlBEHwUDhOLW+Z5nc9V0pL0jpIQirgNnp+D9iPc3vBGiebbunsJbvGV3W8AYibt igxtg6av3Aynau0XMWMWjhrypYmUqSxvgvXuivVh2FObInIDOHjw80jpPLFoeZ65jaH1 2EKQ== X-Forwarded-Encrypted: i=1; AFNElJ8GriBguUVRl+XmldcTP35S8SykQnThuJIo2B4V1JnRQqNDnBTgsRP1WIa9/pHJJLt7uYcZSERDCfs0fmk=@vger.kernel.org X-Gm-Message-State: AOJu0YyxUb8SxJgWnx+l53EhcPohyyPEXIwvLEai6tiOSyj8QuYfUhZ/ 38ztVO777cLXSTnPe7EWlH7lr3DdmGt/tgPfiiuS4leg8VFUzaI5lYz9CZyf0n7fZTEroOnCDQ4 T7/+1W/jt9uTb4V4emViJ0Ew73rGH1NQ0Oqt+VchfyNmF1G7rhSyeeJ25aJVkrtt5uAA= X-Gm-Gg: AeBDiesbCidelZdwO/rnK8atw+CN/haStq5MfoAE3M8gIIcQtzHlIQ6hqXw2AgsgpdY uZMuQZXe+DVaho4+nh0AANSFT3HxT7C9CP0SvtjmEQ33dQdwKDHQEWJLjOqQ5EHO7O+TZSn3SbM guovmOCzJ5V7Ib9cNgifh7kLbWLWEbc3F4D/0YJnMQN+t3UOrLVTmA+BcHZoTFU0cEfjBe6S05J RUhRgCMbT094ipAOthOANT2W/ab3yan4341LPnj1Th48+lpFMxAMhTmKKi1nUV/NAd/N9dIH5OC kYWb+PMgzP9gk2TsGSWUROsxLTmxsqoKMnHJTHct+7tfkxOe5Ntw/pJi7QYzkAXD40rG1wlQ80V baTgS/8RDHEibQ77VnZgBewAO75lS4nU6ZiQ3fLJ65ynRT/FX0+twabXniYfiqWho5brbgwew6F XyvbrEzFf6LS+87lH7QqHgbAp4B6se X-Received: by 2002:a05:6a20:94cb:b0:39f:8aaa:face with SMTP id adf61e73a8af0-3a08d67bd3bmr28758315637.1.1776914930242; Wed, 22 Apr 2026 20:28:50 -0700 (PDT) X-Received: by 2002:a05:6a20:94cb:b0:39f:8aaa:face with SMTP id adf61e73a8af0-3a08d67bd3bmr28758290637.1.1776914929704; Wed, 22 Apr 2026 20:28:49 -0700 (PDT) Received: from [10.133.33.123] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797701f622sm13895523a12.21.2026.04.22.20.28.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 20:28:49 -0700 (PDT) Message-ID: Date: Thu, 23 Apr 2026 11:28:44 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/5] phy: qcom: edp: Add SC7280/SC8180X swing/pre-emphasis tables To: Konrad Dybcio , Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260422-edp_phy-v4-0-c38bef2d027b@oss.qualcomm.com> <20260422-edp_phy-v4-3-c38bef2d027b@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDAzMCBTYWx0ZWRfX7Ms+nnOahFUg FMQapZ58FPVj978xZEbNyHg+pCblZKz9Nu965pZxmaOEinlWt5KtP4CzCV4tDk/nK03aQInD1u2 g7ps8BOpIEBS8+UkLoVhWAu0deLdtpXPIL6/M2nUNyNv7XL1QgS+wg5q576lzEqkd4gQnSEyx49 oyjMc4BQbGtr4P6qgNxYpAiSqapHLFdNI/d2JlccC1nH7qoYIRY3joOpSxIFuk3AAeMDdou1Qfm /LL/yevujL/pmNPR6v0mVj2B7zkR2UAlYD3NBI3mYkC9/HC9Q264RXYZURd++P7YculYZMA8TmH lpEgbPTXJR7kQ6EAmlofsrlSWWCd8wKdCFAGdBT/WIrIvSmPMx+teQ5ZsJaw2YxcknCKMRdQF3V od0f4XWGX93u2tdqx9Dkf3NYccfAGTdOLApo8KSbpd3SE34vuYKIXk9Jh66d3CnD2Foe1BMBrEX iRidHBoYh31e3HCnxUQ== X-Authority-Analysis: v=2.4 cv=dL+WXuZb c=1 sm=1 tr=0 ts=69e991f3 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=Yx4QOS3gQyyNq8E9byYA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: 13UhmT_bKa2hYt-jSJKbz5SDNdyxbenM X-Proofpoint-ORIG-GUID: 13UhmT_bKa2hYt-jSJKbz5SDNdyxbenM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_04,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230030 On 4/22/2026 6:42 PM, Konrad Dybcio wrote: > On 4/22/26 8:01 AM, Yongxing Mou wrote: >> SC7280 and SC8180X previously shared the same cfg because they did not use >> swing/pre-emphasis tables. Add the corresponding tables for these >> platforms. Since they have different PHY sub-versions, their eDP/DP mode >> tables also differ, so move SC8180X to its own cfg instead of reusing the >> SC7280 one. >> >> Signed-off-by: Yongxing Mou >> --- > > > >> +static const struct qcom_edp_swing_pre_emph_cfg edp_phy_swing_pre_emph_cfg_v2 = { >> + .swing_hbr_rbr = &edp_swing_hbr_rbr, > > For eDP / low-Vdiff: > > I believe the RBR swing settings for 8180 should > instead be: > > 0x07 0x0f 0x17 0x1f (matches) Emm i see from ipcat eDP Low vdiff(Lower HBR) swing settings is 0x07 0x0f 0x16 0x1f > (the rest differs) > 0x0d 0x16 0x1e > 0x11 0x1b > 0x16 > > The preem RBR almost matches, one byte is off > (arr[0][1] = 0x12 on poipu, 0x11 on kodiak) > Thanks,, here need to be fixed. > The swing and preem settings for HBR3 look OK > > For DP / low-Vdiff: > > .swing_hbr3_hbr2 OK > .swing_hbr_rbr - I don't know. The docs are unclear whether the same > settings should be used for RBR and HBR3, but maybe? There's a > separate table for mini-DP but I doubt there's any poipu boards with > such a connector (maybe some obscure ones) > > .pre_emphasis_hbr3_hbr2 OK > .pre_emphasis_hbr_rbr same as above > Thanks for point this, so pre_emphasis_hbr_rbr same with pre_emphasis_hbr3_hbr2? I also don't get it's RBR or HBR3 from phy HPG. But now i think only eDP will be used in upstreamed poipu boards. i check the dts and not find any poipu boards will use DP mode(or mini DP).. > Konrad