mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Elson Serrao <quic_eserrao@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, <andersson@kernel.org>,
	<konrad.dybcio@linaro.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<gregkh@linuxfoundation.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/8] dt-bindings: soc: qcom: eud: Add usb role switch property
Date: Wed, 31 Jul 2024 17:16:57 -0700	[thread overview]
Message-ID: <cc02dc38-3986-4b28-a167-30150ea4cc6c@quicinc.com> (raw)
In-Reply-To: <7aec2a72-3276-4837-87fb-ac974588fd53@kernel.org>



On 7/30/2024 10:36 PM, Krzysztof Kozlowski wrote:
> On 31/07/2024 00:24, Elson Roy Serrao wrote:
>> EUD hub is physically present in between the USB connector and the
>> USB controller. So the role switch notifications originating from
>> the connector should route through EUD. Hence to interpret the usb
>> role assigned by the connector, role switch property is needed.
>>
>> Signed-off-by: Elson Roy Serrao <quic_eserrao@quicinc.com>
>> ---
>>  Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
>> index fca5b608ec63..0fa4608568d0 100644
>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
>> @@ -37,6 +37,10 @@ properties:
>>      items:
>>        - const: usb2-phy
>>  
>> +  usb-role-switch:
>> +    $ref: /schemas/types.yaml#/definitions/flag
>> +    description: Support role switch.
> 
> So both EUD and DWC3 controller (as this binding states) are role switching?
> 

Yes. EUD would receive roles from the connector and relay it to the DWC3 controller. In addition to these roles, the DWC3 controller
would also receive roles from EUD itself (related to USB attach/detach events).

Thanks
Elson 

  reply	other threads:[~2024-08-01  0:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-30 22:24 [PATCH 0/8] Enable EUD on Qualcomm sm8450 SoC Elson Roy Serrao
2024-07-30 22:24 ` [PATCH 1/8] dt-bindings: soc: qcom: eud: Add phy related bindings Elson Roy Serrao
2024-07-31  5:33   ` Krzysztof Kozlowski
2024-07-31 22:23     ` Elson Serrao
2024-08-01  7:45       ` Krzysztof Kozlowski
2025-01-27 14:40         ` Konrad Dybcio
2025-01-27 14:50           ` Konrad Dybcio
2024-07-30 22:24 ` [PATCH 2/8] dt-bindings: soc: qcom: eud: Add usb role switch property Elson Roy Serrao
2024-07-31  5:36   ` Krzysztof Kozlowski
2024-08-01  0:16     ` Elson Serrao [this message]
2024-08-01  7:46       ` Krzysztof Kozlowski
2025-01-27 14:45         ` Konrad Dybcio
2024-07-30 22:24 ` [PATCH 3/8] dt-bindings: soc: qcom: eud: Add compatible for sm8450 Elson Roy Serrao
2024-07-31  5:38   ` Krzysztof Kozlowski
2024-07-30 22:24 ` [PATCH 4/8] arm64: dts: qcom: sm8450: Add EUD node Elson Roy Serrao
2024-07-30 22:24 ` [PATCH 5/8] arm64: dts: qcom: Enable EUD on sm8450 hdk Elson Roy Serrao
2024-07-30 22:24 ` [PATCH 6/8] usb: misc: eud: Add High-Speed Phy control for EUD operations Elson Roy Serrao
2024-07-31  5:39   ` Krzysztof Kozlowski
2024-07-31 22:38     ` Elson Serrao
2024-08-01  7:45       ` Krzysztof Kozlowski
2024-07-30 22:24 ` [PATCH 7/8] usb: misc: eud: Handle usb role switch notifications Elson Roy Serrao
2024-07-31 13:06   ` Dmitry Baryshkov
2024-08-01  0:51     ` Elson Serrao
2024-08-01  8:19       ` Dmitry Baryshkov
2024-08-01 22:28   ` kernel test robot
2024-07-30 22:24 ` [PATCH 8/8] usb: misc: eud: Add compatible for sm8450 Elson Roy Serrao
2024-07-31  5:40   ` Krzysztof Kozlowski
2024-07-31 11:13 ` [PATCH 0/8] Enable EUD on Qualcomm sm8450 SoC Caleb Connolly
2024-07-31 19:58   ` Trilok Soni
2024-08-01 10:52     ` Caleb Connolly
2024-08-06 18:58       ` Trilok Soni
2024-08-28 19:31         ` Dmitry Baryshkov
2024-08-01  7:55   ` Krzysztof Kozlowski
2024-08-01 11:00     ` Caleb Connolly
2024-08-01 11:11 ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc02dc38-3986-4b28-a167-30150ea4cc6c@quicinc.com \
    --to=quic_eserrao@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®