From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Keguang Zhang <keguang.zhang@gmail.com>,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH v2] dt-bindings: mips: loongson: Add Loongson-1 based boards
Date: Tue, 21 Feb 2023 11:36:52 +0100 [thread overview]
Message-ID: <cc0c458c-8c4b-c187-8b65-5943499ddf94@linaro.org> (raw)
In-Reply-To: <20230221102605.2103657-1-keguang.zhang@gmail.com>
On 21/02/2023 11:26, Keguang Zhang wrote:
> Add two Loongson-1 based boards: LSGZ 1B and Smartloong 1C.
>
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> V1 -> V2: Add the according vendor prefix
> Change the board string to enum
> Modify the board description
Thank you for your patch. There is something to discuss/improve.
> ---
> .../devicetree/bindings/mips/loongson/devices.yaml | 12 ++++++++++++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 2 files changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> index f13ce386f42c..15a43ce51bbf 100644
> --- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> +++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> @@ -37,6 +37,18 @@ properties:
> items:
> - const: loongson,loongson64v-4core-virtio
>
> + - description: LS1B based boards
> + items:
> + - enum:
> + - loongson,lsgz-1b-dev
> + - const: loongson,ls1b
> +
> + - description: LS1C based boards
> + items:
> + - enum:
> + - loongsonclub,smartloong-1c
> + - const: loongson,ls1c
> +
> additionalProperties: true
>
> ...
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 0e57ae744199..47565ebae4d1 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -757,6 +757,8 @@ patternProperties:
> description: Lontium Semiconductor Corporation
> "^loongson,.*":
> description: Loongson Technology Corporation Limited
> + "^loongsonclub,.*":
> + description: Loongson Club
Are you sure that this is a board manufacturer?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-21 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 10:26 Keguang Zhang
2023-02-21 10:36 ` Krzysztof Kozlowski [this message]
2023-02-21 10:50 ` Kelvin Cheung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc0c458c-8c4b-c187-8b65-5943499ddf94@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=keguang.zhang@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®