From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752083AbdJETiP (ORCPT ); Thu, 5 Oct 2017 15:38:15 -0400 Received: from mout.web.de ([217.72.192.78]:50118 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbdJETiO (ORCPT ); Thu, 5 Oct 2017 15:38:14 -0400 Subject: [PATCH 2/2] powerpc/platforms/cell: Improve a size determination in three functions From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Arnd Bergmann , Benjamin Herrenschmidt , Jeremy Kerr , Michael Ellerman , Paul Mackerras Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Thu, 5 Oct 2017 21:38:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:x0CvMmsKP6Kcd83Ley1G/lL0R2LcoVMOtW3dssOn8hFGWZnh0vB NeS6p5XWQSJu52V595njfBERiZubXKjerT4FAnDSS2RVOCAx4uN4kFlL6of+i5s7y9kW8Ci 8eCOdU5UCs+d1cozwLcV+JMUAkXncJPY2Q/36NLvQmvldR63c4OREvssaJKHZ90U0N+9HyV ZZGBHuD5Nx/jPpwGNfJDA== X-UI-Out-Filterresults: notjunk:1;V01:K0:N8bMwSWB59Y=:KzkwjLsSjzs/uGTpjPnWfQ fFd3IVjfJM3y2v5nEyh4erPOpVQI8clNDpzuXC0n+GRMCheAiz5D/1N+tLbpQKZKoCm4/R1da 6YGDenV+tJmzSM2jBGpQCCyOLW23TbgYJ5woqk/pwQ1E+LnwDFruBJeTfrf+hTkU2ibOClRxm JzlGX66+AnS3CyX8YVWl0YrUWPar6oo2z4tU8cEHptwtkJ2v079evr2b3DlU/qhQXnMyEYWpu ge0JMjtctq+WDJ41o7wuQ8JNrfZl6DRtINzmpwaWryN/3bDSEXRvD3AjXUzBdbgxDmy+MMSpL X17H/ey5LFr2hmG2Rk3x1eiA/h/rp4+PHZwqgPY1qOSmPN37szFBi1oRiISYNs56H6HYo3Djw oiGialSOlulR/34tZuSE9lpVzEaNSHFFjbY2xxlqJhp0Y2nX/pwTKkEEb+sXNtYv1ZeCibGWc mKlzaGp9pyhL4ikxwXthCjIN7SL+Z58r+eQ5GNEV7e2qP2vMkpr6ZyssT5uEegkQuU9HKgTa/ kMSSrFXudizSzJesrTgzGZoPanlJAiPXvsKt9WZlqfk/0m7M6C+Nk/9c3ibAqaFZmwo1Adaka 3JG+MW45aNrVU0TgxtuaFoYBrrrBipZ9rZupxO4Do4LBJjKr89Si6J0wi4GgJjrTRDwz19EDa 7HeHTkOD5hWTAKHP6RvKHYhAJwi9tfYlO/8N46P+zO/M040JRMtuPAiy3aXuYAf4tWLGTSeb7 UhjKPgUY1ywU3tj9qsyGXOLR0klFGH3fQ/wvPQUK1JZL/ngT9uIqcdrLSS1EIx7yOZ7koQcIv LjFfB5jynqTxi6rIahVJAlMt5dLFJYvzcVTuboa0xDz3qN6L+w= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 5 Oct 2017 21:12:41 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/cell/axon_msi.c | 2 +- arch/powerpc/platforms/cell/spider-pci.c | 2 +- arch/powerpc/platforms/cell/spufs/lscsa_alloc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c index 513d13d779b3..cc4987664841 100644 --- a/arch/powerpc/platforms/cell/axon_msi.c +++ b/arch/powerpc/platforms/cell/axon_msi.c @@ -342,7 +342,7 @@ static int axon_msi_probe(struct platform_device *device) pr_devel("axon_msi: setting up dn %pOF\n", dn); - msic = kzalloc(sizeof(struct axon_msic), GFP_KERNEL); + msic = kzalloc(sizeof(*msic), GFP_KERNEL); if (!msic) goto out; diff --git a/arch/powerpc/platforms/cell/spider-pci.c b/arch/powerpc/platforms/cell/spider-pci.c index 0a9f00563144..31919ff00124 100644 --- a/arch/powerpc/platforms/cell/spider-pci.c +++ b/arch/powerpc/platforms/cell/spider-pci.c @@ -131,7 +131,7 @@ int __init spiderpci_iowa_init(struct iowa_bus *bus, void *data) pr_debug("SPIDERPCI-IOWA:Bus initialize for spider(%pOF)\n", np); - priv = kzalloc(sizeof(struct spiderpci_iowa_private), GFP_KERNEL); + priv = kzalloc(sizeof(*priv), GFP_KERNEL); if (!priv) return -1; diff --git a/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c b/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c index b847e9403566..d9de848dae47 100644 --- a/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c +++ b/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c @@ -36,7 +36,7 @@ int spu_alloc_lscsa(struct spu_state *csa) struct spu_lscsa *lscsa; unsigned char *p; - lscsa = vzalloc(sizeof(struct spu_lscsa)); + lscsa = vzalloc(sizeof(*lscsa)); if (!lscsa) return -ENOMEM; csa->lscsa = lscsa; -- 2.14.2