From: Marc Kleine-Budde <mkl@pengutronix.de>
To: angkery <angkery@163.com>,
manivannan.sadhasivam@linaro.org, thomas.kopp@microchip.com,
wg@grandegger.com, davem@davemloft.net, kuba@kernel.org
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Junlin Yang <yangjunlin@yulong.com>
Subject: Re: [PATCH] can: mcp251xfd: mcp251xfd_handle_ivmif(): fix wrong NULL pointer check
Date: Tue, 19 Jan 2021 08:54:32 +0100 [thread overview]
Message-ID: <cc10d919-4087-e61d-28c4-ccffabe7d95a@pengutronix.de> (raw)
In-Reply-To: <20210119020221.3713-1-angkery@163.com>
[-- Attachment #1.1: Type: text/plain, Size: 742 bytes --]
On 1/19/21 3:02 AM, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
>
> if alloc_can_err_skb() returns NULL, we should check skb instead of cf.
Have a look at the function, there is a check for cf several times before this.
But as cf is initialized as NULL this is should be no problem.
While in:
| ca4c6ebeeb50 can: mcp251xfd: mcp251xfd_handle_rxif_one():
| fix wrong NULL pointer check
a real problem has been fixed.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-01-19 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 2:02 angkery
2021-01-19 7:54 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc10d919-4087-e61d-28c4-ccffabe7d95a@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=angkery@163.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=thomas.kopp@microchip.com \
--cc=wg@grandegger.com \
--cc=yangjunlin@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®