From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o10.zoho.com (sender4-op-o10.zoho.com [136.143.188.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C597B36827E for ; Fri, 9 Jan 2026 18:28:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767983306; cv=pass; b=JhLIVDLPKvCpi4h6yCsTi3TQidmSrFFeoJhC+0X+LlDTjn0Ft9j1G1hT0D3kQ5zGVmySvt1XP2n06iuRbDmFfgp4Y+Q7CZel8K0oRjtj+CVGJIKkLL6dhIjFvTETFja0kwa4ZWTZ/EXX5ZsX8plfAh+Aw7aMVhel/XMMdrgpgko= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767983306; c=relaxed/simple; bh=vf+18t1t2iJMep/ahqqAufx0XkAXBscr4g95xemYq98=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=d6ypcUjJmLyeUeASsHlrK28LCDAQfg/6CDP24u+NLfV1tB6jzTn1zjcG4k6bcHNPtka8IrW1p4iJpGOY72oaXKTBMFPRC51oYFKZ3/F7140VYksFfTPaZwQAXx45Tx2T/1TSqpyu3BI6hjcVhxI6+Xqr4/YoSRwNKnMP6wt3IxM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nfraprado@collabora.com header.b=TTq2WD53; arc=pass smtp.client-ip=136.143.188.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nfraprado@collabora.com header.b="TTq2WD53" ARC-Seal: i=1; a=rsa-sha256; t=1767983273; cv=none; d=zohomail.com; s=zohoarc; b=XTfBx+aumr4r26qEMS0RwjcPnj46PAfTi08A3JujHbeFikRRVTo1EPKJSc1Dzuc7kAKCVPMoR5UlHqVmL3gWIJkcSftyOpn7IJSgRadPHgaHw2RvlHEx2YwrgIN7ByHTT3AvEaqtJuGwMi8cQxtEoEUdxtm02eruFinn7lOnBe0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767983273; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=vf+18t1t2iJMep/ahqqAufx0XkAXBscr4g95xemYq98=; b=hKMh2q5w0LGL936lnYAYGf/BrtTTYdMOn1o7pRh7IySWJk3IER6bA7bs5iOIxkWFY90VvWxUYnEGeKeszgw2RYrE3RwdzX8ZFJICihuHE0zH2gxes0MiCXU4IsqOI3QfjCQ8uBfk2FAGNALKDTE2SXRa8nsogWCsW3YHau0qA7k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nfraprado@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1767983273; s=zohomail; d=collabora.com; i=nfraprado@collabora.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Message-Id:Reply-To; bh=vf+18t1t2iJMep/ahqqAufx0XkAXBscr4g95xemYq98=; b=TTq2WD53kIq8HjDxVYzDBy3cFCtsADCb9pmD9cI6BbKE2yn9UTm+uAWXHTwtwRvw Tsg5MuB+RIfbS7sbk9EsnBlXAoaF+WIZpX2RkfmNqLGoqTNeo6BCuD8BpRWzqHeCskC iPYvw7SwJVXYjavI8h+pmYGrJqLCRif/N2UOR5Ck= Received: by mx.zohomail.com with SMTPS id 1767983272320533.4804385881307; Fri, 9 Jan 2026 10:27:52 -0800 (PST) Message-ID: Subject: Re: [PATCH RFC 0/6] AFBC fixes for MediaTek DRM From: =?ISO-8859-1?Q?N=EDcolas?= "F. R. A. Prado" To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Justin Green Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ariel.dalessandro@collabora.com, daniels@collabora.com, Nancy.Lin@mediatek.com, Jason-JH.Lin@mediatek.com Date: Fri, 09 Jan 2026 15:27:43 -0300 In-Reply-To: <20251230-mtk-afbc-fixes-v1-0-6c0247b66e32@collabora.com> References: <20251230-mtk-afbc-fixes-v1-0-6c0247b66e32@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-7 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ZohoMailClient: External On Tue, 2025-12-30 at 11:03 -0300, N=C3=ADcolas F. R. A. Prado wrote: > This series contains a handful of fixes for AFBC support on the > MediaTek > DRM driver so that it can be re-enabled. >=20 > This is sent as an RFC because there are still some issues to work > out > before the series can be merged: >=20 > 1. Patch 4, 'drm/mediatek: ovl: Disallow AFBC buffers with width over > =C2=A0=C2=A0 1920' did not behave well when tested with Weston, so a bett= er > =C2=A0=C2=A0 solution probably needs to be implemented before this can be > merged. >=20 > 2. Remaining AFBC issues: > =C2=A0=C2=A0=20 > =C2=A0=C2=A0 a. The first 4 pixel rows are always skipped in the displaye= d > output, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 that is, the first displayed pixel, on the= top-left corner, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 corresponds to 4x0. And below the end of t= he displayed output, > the > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 first 4x32 pixels are displayed. >=20 > =C2=A0=C2=A0 b. On some resolutions, there are still artifacts that look = like > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 misalignment issues, eg 1024x1080, 1080x10= 80. >=20 > =C2=A0=C2=A0 c. On some resolutions, no output at all is displayed, eg > 1920x1080. I received a suggestion that the Lx_2ND_SUBBUF bit in OVL is not needed when cropping is not enabled, and that removing it should fix the extra pixels after the image described in 2.a., and perhaps even fix AFBC not working with MT8188, though I haven't had time to test it. --=20 Thanks, N=C3=ADcolas