From: Matthias Brugger <matthias.bgg@gmail.com>
To: Matthias Kaehlcke <mka@chromium.org>, Pi-Hsun Shih <pihsun@chromium.org>
Cc: Erin Lo <erin.lo@mediatek.com>,
Nicolas Boichat <drinkcat@chromium.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM"
<linux-remoteproc@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v4 2/6] remoteproc/mediatek: add SCP support for mt8183
Date: Mon, 4 Feb 2019 19:02:17 +0100 [thread overview]
Message-ID: <cc1407f1-c236-f0af-a6c1-366aeac259f4@gmail.com> (raw)
In-Reply-To: <20190202001749.GT81583@google.com>
On 02/02/2019 01:17, Matthias Kaehlcke wrote:
> Hi Pi-Hsun,
>
> a few comments inline.
>
> It's the first time I dabble into remoteproc, I don't claim to have a
> complete understanding of the driver at this point ;-)
>
> On Thu, Jan 31, 2019 at 05:31:27PM +0800, Pi-Hsun Shih wrote:
>> From: Erin Lo <erin.lo@mediatek.com>
>>
>> Provide a basic driver to control Cortex M4 co-processor
>>
>> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
>> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
>> ---
>> Changes from v3:
>> - Fix some issue found by checkpatch.
>> - Make writes aligned in scp_ipi_send.
>>
>> Changes from v2:
>> - Squash patch 3 from v2 (separate the ipi interface) into this patch.
>> - Remove unused name argument from scp_ipi_register.
>> - Add scp_ipi_unregister for proper cleanup.
>> - Move IPI ids in sync with firmware.
>> - Add mb() in proper place, and correctly clear the run->signaled.
>>
>> Changes from v1:
>> - Extract functions and rename variables in mtk_scp.c.
>> ---
>> drivers/remoteproc/Kconfig | 9 +
>> drivers/remoteproc/Makefile | 1 +
>> drivers/remoteproc/mtk_common.h | 73 +++++
>> drivers/remoteproc/mtk_scp.c | 441 ++++++++++++++++++++++++++
>> drivers/remoteproc/mtk_scp_ipi.c | 157 +++++++++
>> include/linux/platform_data/mtk_scp.h | 135 ++++++++
>> 6 files changed, 816 insertions(+)
>> create mode 100644 drivers/remoteproc/mtk_common.h
>> create mode 100644 drivers/remoteproc/mtk_scp.c
>> create mode 100644 drivers/remoteproc/mtk_scp_ipi.c
>> create mode 100644 include/linux/platform_data/mtk_scp.h
>>
>> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
>> index f0abd260804473..ee0bda23768938 100644
>> --- a/drivers/remoteproc/Kconfig
>> +++ b/drivers/remoteproc/Kconfig
>> @@ -22,6 +22,15 @@ config IMX_REMOTEPROC
>>
>> It's safe to say N here.
>>
>> +config MTK_SCP
>> + tristate "Mediatek SCP support"
>> + depends on ARCH_MEDIATEK
>> + help
>> + Say y here to support Mediatek's SCP (Cortex M4
>> + on MT8183) via the remote processor framework.
>
> It would be good to spell out SCP somewhere, e.g.
>
> "... support Mediatek's system control processor (SCP) via ..."
>
> the example is less important IMO, though it's prefectly fine if you
> can still squeeze it in ;-)
>
In which way is this different from
drivers/soc/mediatek/mtk-scpsys.c ?
Regards,
Matthias (the other one ;)
next prev parent reply other threads:[~2019-02-04 18:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190131093131.245531-1-pihsun@chromium.org>
2019-01-31 9:31 ` [PATCH v4 1/6] dt-bindings: Add a binding for Mediatek SCP Pi-Hsun Shih
2019-01-31 9:31 ` [PATCH v4 2/6] remoteproc/mediatek: add SCP support for mt8183 Pi-Hsun Shih
2019-02-02 1:03 ` Matthias Kaehlcke
2019-02-04 17:59 ` Matthias Brugger
[not found] ` <20190202001749.GT81583@google.com>
2019-02-04 18:02 ` Matthias Brugger [this message]
2019-02-13 3:16 ` Pi-Hsun Shih
2019-02-13 3:20 ` Pi-Hsun Shih
2019-02-13 17:01 ` Matthias Kaehlcke
2019-01-31 9:31 ` [PATCH v4 3/6] rpmsg: add rpmsg support for mt8183 SCP Pi-Hsun Shih
2019-02-04 20:42 ` Matthias Kaehlcke
2019-01-31 9:31 ` [PATCH v4 4/6] mfd: add EC host command support using rpmsg Pi-Hsun Shih
2019-01-31 9:31 ` [PATCH v4 5/6] cros_ec: differentiate SCP from EC by feature bit Pi-Hsun Shih
2019-01-31 9:31 ` [PATCH v4 6/6] remoteproc/mediatek: Load ELF instead of bin file for mtk_scp Pi-Hsun Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc1407f1-c236-f0af-a6c1-366aeac259f4@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=drinkcat@chromium.org \
--cc=erin.lo@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mka@chromium.org \
--cc=ohad@wizery.com \
--cc=pihsun@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®