From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25109C43460 for ; Tue, 6 Apr 2021 21:19:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3AFC61396 for ; Tue, 6 Apr 2021 21:19:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343660AbhDFVTW (ORCPT ); Tue, 6 Apr 2021 17:19:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343630AbhDFVTU (ORCPT ); Tue, 6 Apr 2021 17:19:20 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 695FFC061756 for ; Tue, 6 Apr 2021 14:19:12 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id x16so17112929iob.1 for ; Tue, 06 Apr 2021 14:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t/Gx+NJDxxNQAlNTAP9DklegMCl81qD73OBwwEWu0F0=; b=Gqzq4ixtKE/AadMF+KHA+ZBNiLb/80N507ZBcwRHk0PaGK3Qik7UIjXaXHNMLrkYgC DmGxoK5mUqBAi8SghgSiFuH/DvqYq0P+CUXfkmgokMCd49T3ap0+QoIafGPvR3bvB6Uz teRoAONklLnsZEOmaf69pLY8vtZLr3t6FE78g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t/Gx+NJDxxNQAlNTAP9DklegMCl81qD73OBwwEWu0F0=; b=H5lOxn6H1kKh6nQiccpSNwwRz3sCrpVGkprFxKhckCmLdKQZcWeiTthhTINDJo/DYf RtfpJ/94vOsTg4AOEY3uLIA8NbHCoB1W1xfTYRu0VM+aaML6ISuBn015snd/lEI8kuts JazWQtUCtfhE2+Jk4DXNMtDrqX+dJ8xRd8iGxTsWjlnmyb5bRvszRyzN+KgSI7AJQlzS DHwAnXnFbf6Pe34lP8lyMzSzcrKjSUOy0H66kcgTTgg6jIYYpQusXMTlTfURwaYNB5cH 3D3QuFnmyjdBgD+k9yaYUP2eIDHc7g/mot9VKtFNI7+Ef7Sa+3l75A4WwZFVnDQ6zNOa d6Yg== X-Gm-Message-State: AOAM530wEUydvA2HOZ4lqtvmgGLM8JGnMWNb2jQs163pgg4Ye/C39C66 rIUrnRrppNfWJ9UXl8wKeuxrLQ== X-Google-Smtp-Source: ABdhPJzx++9dkI+upZNJ43iZ0to1iHcCFsNxPKPFqO0vLX7fU7AkSKB3iDqTr+UflBDLRBhFrK7ZlA== X-Received: by 2002:a5e:8416:: with SMTP id h22mr25368407ioj.119.1617743951799; Tue, 06 Apr 2021 14:19:11 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id x24sm14064352iob.28.2021.04.06.14.19.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Apr 2021 14:19:10 -0700 (PDT) Subject: Re: [PATCH] kunit: fix -Wunused-function warning for __kunit_fail_current_test To: Brendan Higgins , Daniel Latypov Cc: David Gow , Linux Kernel Mailing List , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Stephen Rothwell , Shuah Khan References: <20210406172901.1729216-1-dlatypov@google.com> From: Shuah Khan Message-ID: Date: Tue, 6 Apr 2021 15:19:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/21 2:50 PM, Brendan Higgins wrote: > On Tue, Apr 6, 2021 at 10:29 AM Daniel Latypov wrote: >> >> When CONFIG_KUNIT is not enabled, __kunit_fail_current_test() an empty >> static function. >> >> But GCC complains about unused static functions, *unless* they're static inline. >> So add inline to make GCC happy. >> >> Signed-off-by: Daniel Latypov >> Fixes: 359a376081d4 ("kunit: support failure from dynamic analysis tools") > Signed-off-by comes after Fixes. Also good to add Reported-by for Stephen acknowledging the reporter. I will fix this up when I apply - for future reference. > Reviewed-by: Brendan Higgins > thanks, -- Shuah