From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC7F0C433DB for ; Fri, 26 Mar 2021 17:14:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A79A619FB for ; Fri, 26 Mar 2021 17:14:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230287AbhCZRNd (ORCPT ); Fri, 26 Mar 2021 13:13:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26687 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbhCZRN2 (ORCPT ); Fri, 26 Mar 2021 13:13:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616778808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uYX3Pr+wY1U0fuqj3VKN1uau5ruRe+oCNWNth4NlHBE=; b=UoNes85ei6For+SoxPoNwPgdqmh2luxrBpbK0eIhqBuiijmDghwaKJGZyfVet5s0dAooIu /WLVgCGzgEKLOi8ByvoFc94NWA2NieRxlJA+hPryPZVAjvDrLc4OYv+8lwXUIsY/ybv15G ZB5XTKEKO3NQfOX4R86wqdI2fz/Vmz4= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-415-AWVa8_f4O6CJRvF6V8uHAw-1; Fri, 26 Mar 2021 13:13:26 -0400 X-MC-Unique: AWVa8_f4O6CJRvF6V8uHAw-1 Received: by mail-ed1-f72.google.com with SMTP id r6so1270368edh.7 for ; Fri, 26 Mar 2021 10:13:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uYX3Pr+wY1U0fuqj3VKN1uau5ruRe+oCNWNth4NlHBE=; b=FhZWc/DFUtoLwlirdLOqn5Swjqc9s95KWMjdvuNRwsUdqrS/JnMWXz7HPQrbeWRtG+ eL1zfoMw/nQvX0KVVt8ZQm4J7+zwMfsFjwyfC53CGa1gRFdgGhTndpB+3WmFegFAYA/V a6/pHXwBlNIYoiGihS5qNUYTCb3uObRn3VKd9DYaLiPCxhpoN603794tYlRPfWQ7gA0k J3sHivqAyYoimgHD8clT3F21HoKMWzIVlkitItufEbqpzA8joj37H35061Hfq3Crvq+C rYW/953FQGVa7iUhW1IPJFp/iQze+zp245Vq7qmUil3ZyRnnn1CDOmrcyahVy8MS5uv8 aXjw== X-Gm-Message-State: AOAM533eYkwxY4mrP8Mf2gWmgkwhCXqR3zL2162WWv30u3tEaZHb0r+a wXf9uyMxJmyRoJL06iVfkezPXne7t7GS2nqeanZFIqdCfUqHll/A4JKLK1XqeRyi3AHTbT3/m7e svBopa72NQb2cmPrShFK/JGI3 X-Received: by 2002:a17:906:70d:: with SMTP id y13mr16033508ejb.170.1616778805442; Fri, 26 Mar 2021 10:13:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvHb1xJA6IsY9jNQ4z7xuRprpd/9Dmex3UEJxmIg/KfdFHV+3q3yw2+p68OcaDNorC5iwIDA== X-Received: by 2002:a17:906:70d:: with SMTP id y13mr16033490ejb.170.1616778805245; Fri, 26 Mar 2021 10:13:25 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id gn19sm3918920ejc.4.2021.03.26.10.13.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Mar 2021 10:13:24 -0700 (PDT) Subject: Re: [PATCH] KVM: clean up the unused argument To: lihaiwei.kernel@gmail.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, Haiwei Li References: <20210313051032.4171-1-lihaiwei.kernel@gmail.com> From: Paolo Bonzini Message-ID: Date: Fri, 26 Mar 2021 18:13:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210313051032.4171-1-lihaiwei.kernel@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/03/21 06:10, lihaiwei.kernel@gmail.com wrote: > From: Haiwei Li > > kvm_msr_ignored_check function never uses vcpu argument. Clean up the > function and invokers. > > Signed-off-by: Haiwei Li > --- > arch/x86/kvm/x86.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) Queued, thanks. Paolo > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 012d5df..27e9ee8 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -271,8 +271,7 @@ struct kvm_stats_debugfs_item debugfs_entries[] = { > * When called, it means the previous get/set msr reached an invalid msr. > * Return true if we want to ignore/silent this failed msr access. > */ > -static bool kvm_msr_ignored_check(struct kvm_vcpu *vcpu, u32 msr, > - u64 data, bool write) > +static bool kvm_msr_ignored_check(u32 msr, u64 data, bool write) > { > const char *op = write ? "wrmsr" : "rdmsr"; > > @@ -1447,7 +1446,7 @@ static int do_get_msr_feature(struct kvm_vcpu *vcpu, unsigned index, u64 *data) > if (r == KVM_MSR_RET_INVALID) { > /* Unconditionally clear the output for simplicity */ > *data = 0; > - if (kvm_msr_ignored_check(vcpu, index, 0, false)) > + if (kvm_msr_ignored_check(index, 0, false)) > r = 0; > } > > @@ -1613,7 +1612,7 @@ static int kvm_set_msr_ignored_check(struct kvm_vcpu *vcpu, > int ret = __kvm_set_msr(vcpu, index, data, host_initiated); > > if (ret == KVM_MSR_RET_INVALID) > - if (kvm_msr_ignored_check(vcpu, index, data, true)) > + if (kvm_msr_ignored_check(index, data, true)) > ret = 0; > > return ret; > @@ -1651,7 +1650,7 @@ static int kvm_get_msr_ignored_check(struct kvm_vcpu *vcpu, > if (ret == KVM_MSR_RET_INVALID) { > /* Unconditionally clear *data for simplicity */ > *data = 0; > - if (kvm_msr_ignored_check(vcpu, index, 0, false)) > + if (kvm_msr_ignored_check(index, 0, false)) > ret = 0; > } > >