From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95FB7C433FF for ; Tue, 13 Aug 2019 19:38:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63F9F206C2 for ; Tue, 13 Aug 2019 19:38:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726403AbfHMTih (ORCPT ); Tue, 13 Aug 2019 15:38:37 -0400 Received: from mga02.intel.com ([134.134.136.20]:5176 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbfHMTih (ORCPT ); Tue, 13 Aug 2019 15:38:37 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 12:38:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,382,1559545200"; d="scan'208";a="183972065" Received: from linux.intel.com ([10.54.29.200]) by FMSMGA003.fm.intel.com with ESMTP; 13 Aug 2019 12:38:35 -0700 Received: from dalyrusx-mobl.amr.corp.intel.com (unknown [10.251.3.205]) by linux.intel.com (Postfix) with ESMTP id 361CD580372; Tue, 13 Aug 2019 12:38:34 -0700 (PDT) Subject: Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream() To: Mark Brown Cc: Srinivas Kandagatla , vkoul@kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, plai@codeaurora.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, spapothi@codeaurora.org References: <20190813083550.5877-1-srinivas.kandagatla@linaro.org> <20190813083550.5877-4-srinivas.kandagatla@linaro.org> <20190813191827.GI5093@sirena.co.uk> From: Pierre-Louis Bossart Message-ID: Date: Tue, 13 Aug 2019 14:38:53 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190813191827.GI5093@sirena.co.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/13/19 2:18 PM, Mark Brown wrote: > On Tue, Aug 13, 2019 at 02:15:18PM -0500, Pierre-Louis Bossart wrote: >> On 8/13/19 1:06 PM, Srinivas Kandagatla wrote: > >>> sorry for the confusion. It was too quick reply. :-) >>> I was suppose to say sdw_stream_add_slave() instead of set_sdw_stream(). > >> ok, so get_sdw_stream() and set_sdw_stream() are not meant to be mirrors or >> both implemented. It's just a helper to respectively get a context or set a >> context but a get-modify-set type of operation is not expected. > >> Do I get this right? > > This seems like it's going to be confusing... Indeed. I don't have a full understanding of that part to be honest, nor why we need something SoundWire-specific. We already abused the set_tdm_slot API to store an HDaudio stream, now we have a rather confusing stream information for SoundWire and I have about 3 other 'stream' contexts in SOF... I am still doing basic cleanups but this has been on my radar for a while.