From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Shuah Khan <skhan@linuxfoundation.org>,
Igor Matheus Andrade Torrente <igormtorrente@gmail.com>,
mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: em28xx: Fix possible memory leak of em28xx struct
Date: Thu, 6 May 2021 09:43:32 +0200 [thread overview]
Message-ID: <cc3a655a-e29d-34f1-a1bb-faab01a1f756@xs4all.nl> (raw)
In-Reply-To: <21f59c86-f1ae-5913-cde9-078fe4f6f752@linuxfoundation.org>
On 05/05/2021 17:54, Shuah Khan wrote:
> On 5/4/21 2:32 PM, Igor Matheus Andrade Torrente wrote:
>> The em28xx struct kref isn't being decreased after an error in the
>> em28xx_ir_init, leading to a possible memory leak.
>>
>> A kref_put and em28xx_shutdown_buttons is added to the error handler code.
>>
>> Signed-off-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
>> ---
>
> Hi Igor,
>
> Please look at Hans's response and comments to your v1 patch. v4l core
> addresses the lifetime issues now and this driver could be updated to
> use them instead if fixing the problems in this driver's resource
> lifetime mgmt code.
Actually, this patch is fine (I think, still need to review it). This is
related to the input part, not v4l2.
Regards,
Hans
>
> Please follow his review comments to address the issue based on his
> suggestions.
>
> thanks,
> -- Shuah
>
prev parent reply other threads:[~2021-05-06 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 18:32 Igor Matheus Andrade Torrente
2021-05-05 15:54 ` Shuah Khan
2021-05-06 7:43 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc3a655a-e29d-34f1-a1bb-faab01a1f756@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=igormtorrente@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®