From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Krzysztof Wilczynski <kwilczynski@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
Thierry Reding <thierry.reding@kernel.org>,
Jon Hunter <jonathanh@nvidia.com>,
Vidya Sagar <vidyas@nvidia.com>,
Niklas Cassel <cassel@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 0/5] PCI: dwc: Clean up RAS-DES and register field handling
Date: Fri, 16 Oct 2026 13:15:33 +0530 [thread overview]
Message-ID: <cc413ec5-3d69-4fee-9bad-1e6c152b789f@nvidia.com> (raw)
In-Reply-To: <179198416084.63727.13083524527951291207.b4-review@b4>
On 14/10/26 6:52 pm, Manivannan Sadhasivam wrote:
>> This series addresses review feedback around register field handling in the
>> DWC PCIe code and the Tegra194 PCIe driver.
>>
>> The first patches add shared masks for the RAS-DES event counter fields,
>> convert Tegra194 register programming to FIELD_PREP()/FIELD_MODIFY(), and
>> drop shift macros that become unused after the conversion. The final
>> patches make Tegra194 use the common RAS-DES selector definitions and
>> consolidate the event counter field definitions in the DWC header.
>>
>> There should be no functional change intended beyond making the
>> bitfield programming explicit and keeping the shared RAS-DES definitions in
>> one place.
>>
>
> Series LGTM! Please rebase on top of pci/controller/dwc branch and resend.
>
> - Mani
>
Thank you for reviewing the changes.
I rebased the changes and posted V2 at
https://patchwork.kernel.org/project/linux-pci/list/?series=1187061
- Manikanta
--
nvpublic
prev parent reply other threads:[~2026-10-16 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 7:17 Manikanta Maddireddy
2026-09-23 7:17 ` [PATCH 1/5] PCI: dwc: Add RAS event counter field masks Manikanta Maddireddy
2026-09-23 7:17 ` [PATCH 2/5] PCI: tegra194: Use FIELD_*() for register fields Manikanta Maddireddy
2026-09-23 7:17 ` [PATCH 3/5] PCI: dwc: Drop unused shift macros Manikanta Maddireddy
2026-09-23 7:17 ` [PATCH 4/5] PCI: tegra194: Use standard RAS event selector mask Manikanta Maddireddy
2026-09-23 7:17 ` [PATCH 5/5] PCI: dwc: Consolidate RAS-DES event counter fields Manikanta Maddireddy
2026-10-14 13:22 ` [PATCH 0/5] PCI: dwc: Clean up RAS-DES and register field handling Manivannan Sadhasivam
2026-10-16 7:45 ` Manikanta Maddireddy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc413ec5-3d69-4fee-9bad-1e6c152b789f@nvidia.com \
--to=mmaddireddy@nvidia.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=thierry.reding@kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®