From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F0BE3BF665; Fri, 10 Jul 2026 21:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783718801; cv=none; b=RXIs0SgYmPajxNCL+zyhD+uiGfkM9n9BV51+4n2NIZjINOMg/8RvXNOLOCYZuziwITHsOLIJ32KwEs0ibKE6aUyKffQ4ShABLdlxHl/KCWS6sazMEZenimuP/qL0l72JrxRbxThkmj/RLyB0dKdVy2arWH9yEpqvWm9UCkPAsXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783718801; c=relaxed/simple; bh=IrFMV4oGITrYeOHCrr3VqFpg6+Zsvxn5Zb91RHBDn70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CGcjbw2mJZpXf9an/968WXr3kV5WIPcgDts/j+1t5NqGnACzyRz82O/3BOvKcizs2tzThgBn3G35lxJcM8C/eXLab5BpiGixgcdnro59DjdExaI/prgltJ2JlwFWPcBO6mOAlSBokIMq5xBcaG4h8e1tIlm8gTPkV7HYTUbe39g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AXRARrC+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AXRARrC+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8FA31F01805; Fri, 10 Jul 2026 21:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783718796; bh=uD6htahkgcYYoDLNVJc8u1TF30tTz5i48QncIScBRqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=AXRARrC+LaL2nhX2ksKRfZwB8kHRcEpOYX3+RtGGqQm9aZZgWu1TyA9YvjAPqR46k 1/cNzWwdah7tBlvjZsNdYS0MuYXvp+Fufx3FhCZVO4JQL+pZuyyRe4ZSPkXUPQTJnf Oza8mXo2mINBRuejTzwnQD2vqWwMYObGwCgqREstU27AqFakgBR4zu1wQ8aC05y4uz Lbti/0oW+7K49Pe/cK87E7u4rze/YUSoQvCWOpdd2LoUsqY0Pc22ZeBva8RClbDMBl Ym2OZdumTS/+QqXP+/tXZRFaW248C7saLF3myHcbP+s7xikqCto9VkOdUWF996I7mz 7Xv1ENSQ7QPJw== Date: Fri, 10 Jul 2026 22:26:31 +0100 From: Mark Brown To: Praveen Talari Cc: Bjorn Andersson , Konrad Dybcio , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mukesh Kumar Savaliya , Konrad Dybcio Subject: Re: [PATCH v2 2/2] spi: qcom-geni: add GENI SE registers trace event on error paths Message-ID: References: <20260711-add-tracepoints-for-se-reg-dump-v2-0-ca1e9ba62359@oss.qualcomm.com> <20260711-add-tracepoints-for-se-reg-dump-v2-2-ca1e9ba62359@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Lw4bHw3gKlYqq4/a" Content-Disposition: inline In-Reply-To: <20260711-add-tracepoints-for-se-reg-dump-v2-2-ca1e9ba62359@oss.qualcomm.com> X-Cookie: No directory. --Lw4bHw3gKlYqq4/a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jul 11, 2026 at 12:18:42AM +0530, Praveen Talari wrote: > The GENI SPI driver reports various transfer failures such as command > timeouts, DMA reset timeouts, DMA transaction errors, and unexpected > interrupt conditions. However, diagnosing the root cause of these > failures is difficult as the hardware state is not captured when the > error occurs. > +#include Should this be in rivers/soc/qcom/qcom-geni-se.c (and the first patch?) - that way if another driver starts using them we won't multiply define the tracepoints. > @@ -986,10 +997,13 @@ static irqreturn_t geni_spi_isr(int irq, void *data) > writel(0, se->base + SE_GENI_TX_WATERMARK_REG); > dev_err(mas->dev, "Premature done. tx_rem = %d bpw%d\n", > mas->tx_rem_bytes, mas->cur_bits_per_word); > + trace_geni_se_regs(se); SE_GENI_TX_WATERMARK_REG is one of the registers in the tracepoint, perhaps trace before we write to clear it? --Lw4bHw3gKlYqq4/a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmpRY4YACgkQJNaLcl1U h9DaQQf/V9ofytEnsFFwGweLPOJ52okuv+hIdRB/hWRWwuNh4N45IK/PScOWQxXb AeUiovvZXlK3/96XEF4sSojfyjrd+bVUQeUdhkX6scgvwiRdjsO5wBBmBySqQmcb gVzGYB+PXa0WI86EglOIwxwin3lzxKML3gtObYNHpeU/QEMt3edwSy2lpwADQ9EG afgPZGwtHIWnqOma95DBEqT/9BQAe0rdRZPzQcNFP5+Gx0u4pJMFw9FVT/XNZ8Zb WGIb/cEZ9HPlhf67e4fm+fvug0gKkD2bsWiJpdsl5hp8q5oYO3C52c/HucOjU3Wy qAGFyGegPEjWu3n1Liy1ve5pzrzN0w== =yoWN -----END PGP SIGNATURE----- --Lw4bHw3gKlYqq4/a--