From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753847AbdJPPGd (ORCPT ); Mon, 16 Oct 2017 11:06:33 -0400 Received: from mout.web.de ([212.227.17.12]:53015 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753265AbdJPPGa (ORCPT ); Mon, 16 Oct 2017 11:06:30 -0400 Subject: [PATCH 3/4] char/snsc: Improve a size determination in two functions From: SF Markus Elfring To: kernel-janitors@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman Cc: LKML References: Message-ID: Date: Mon, 16 Oct 2017 17:06:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:XK2vqmeMT/N3LNBxWHhej0A/hdN8KY/k9tSZ/bWTo/qp995P2hR DQd1I3wrUjXMarAk6kpQF7pxgWTNRbpfFSgpIx+DrkDKi+M1VpHvireLc/TmpyIfPN/e+MV a5nsTaszu23rhWZ8+UeiGJikY3OF7CTkjzIjRE56XGJzCuFWnx9LpZoUn769NVWY0BRWtdG ul8IiUSJOzSLZn5i5L4EQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:NpzbgjfSh58=:fW4sb20aRg/8w5ZPnjY0Rn mdlFIRHOHzAGt+dzp8IhjohU/rX2b3eMsJbc5aONqC2ByDhu0ZAWrCHDrIWSjid+0nmskO5Da XhAjQ8tt2BsNh4u3Y+fV4EGrRnSYjAuzG6rfJV9GWvqyZE7R4kH85LUvT6iUqVO2CaP4C/BDj DVF3U2SqLNN7etO/HA7UmCg7PMOh1Cb+SrLuJCjz2JaU9nraIaOJbWbH3b67RzrqOu/M0lADq V/CjHOonKA7T7J8L3hHh7AIl7AcJoyfYKdHH3Typ15cDHUGzOpBt2JCIRIPy3dw9Bf9o7CVDY i7rsL/1i/Pf4JhURmoNYtIAQPumdrI81yij8A7uQgoG1FLgTbZInFiYARNmw2wrR8kTXvxH3T 9lu9AIj9s4jXoHltqhEFV0H2fmUmoZpMPRVdNwA4TsSKEo05YbeP1Ume7kIHqhac7xGITXCkS uyZ1CElJQbbHRxoZY90vsTMk9iaMK/GTC+bd2aStftmnAYJV7VoLFkQFtrrKeHfMtRy3pa+Ff KqPrhBtVk5/ZF4qHQoM3p04jFnB3A+52S9LWKf+a8vk6IrS3zG5TGUEMlh/TDlecNHZ363MCq MQ2X/SWAM2nkLo5Z6FnAp8t/JNayX0oeiTyogJ3ugaUXQmq5Df1JpY5r2rPn7LrmriYweoi2i 7ad5nRZu/mAHON3Us0Nr+cryKKfbR5fzVuAphVMVRiHrhaJTyEP7meOcsTCSGzAlkLtH+/PbU 9JNZvB0WVoSSdXdmwEge9M1nydVYwRC24fXDDUCEqkGTIdSb9SRjkS0Pj4yyTg2s5Ix2i5ycV HMI9xs58wWx+2ERl9tRCaEz7CNJ0wpKy164oL54eN3on0RTVUE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 16 Oct 2017 16:26:09 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/char/snsc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/char/snsc.c b/drivers/char/snsc.c index eefc306033ab..bec3bd966b1f 100644 --- a/drivers/char/snsc.c +++ b/drivers/char/snsc.c @@ -79,7 +79,7 @@ scdrv_open(struct inode *inode, struct file *file) scd = container_of(inode->i_cdev, struct sysctl_data_s, scd_cdev); /* allocate memory for subchannel data */ - sd = kzalloc(sizeof (struct subch_data_s), GFP_KERNEL); + sd = kzalloc(sizeof(*sd), GFP_KERNEL); if (!sd) return -ENOMEM; @@ -405,8 +405,7 @@ scdrv_init(void) geo_slab(geoid)); /* allocate sysctl device data */ - scd = kzalloc(sizeof (struct sysctl_data_s), - GFP_KERNEL); + scd = kzalloc(sizeof(*scd), GFP_KERNEL); if (!scd) continue; -- 2.14.2