mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
To: Guenter Roeck <linux@roeck-us.net>,
	"wim@iguana.be" <wim@iguana.be>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] watchdog: imx2_wdt: adds big endianness support.
Date: Tue, 3 Jun 2014 03:19:58 +0000	[thread overview]
Message-ID: <cc49edeb85294b00af2a2e6a88e542fc@BY2PR03MB505.namprd03.prod.outlook.com> (raw)
In-Reply-To: <5388975A.7040109@roeck-us.net>

> > @@ -201,6 +204,10 @@ static int __init imx2_wdt_probe(struct platform_device
> *pdev)
> >   	if (!wdev)
> >   		return -ENOMEM;
> >
> > +	big_endian = of_property_read_bool(np, "big-endian");
> > +	if (big_endian)
> > +		imx2_wdt_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
> > +
> 
> You'll need to document the use of this property in
> Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.txt.
>

Sorry for late.

Please see the next version.

Thanks,

BRs
Xiubo




> Guenter
> 
> >   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >   	base = devm_ioremap_resource(&pdev->dev, res);
> >   	if (IS_ERR(base))
> >


      reply	other threads:[~2014-06-03  3:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30  6:10 Xiubo Li
2014-05-30 14:36 ` Guenter Roeck
2014-06-03  3:19   ` Li.Xiubo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc49edeb85294b00af2a2e6a88e542fc@BY2PR03MB505.namprd03.prod.outlook.com \
    --to=li.xiubo@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®