From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C95C1F19A for ; Mon, 24 Jun 2024 07:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719213762; cv=none; b=YmFoOO2LtV3gUqMdkBZdMAd8xs0dE255psxKpAu8B82NBJPUBpZJdAnTX1c6jXrpjJngsAGKb/kAWQeUi4aN/NMVNbG8hau8dTROF79WFeJ287xf9Q2x3+5zIqH4EovHJ6e3f8dpfbe5zE2OtfjFpmbGBztZvXhkiNJE82Jyx44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719213762; c=relaxed/simple; bh=jZ8x/WkPGnEIjqc1+cqPSKViLKaJLvzVCLyIqHHVX5U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sEc8QcgbmBDdXeHH5JMN6pBW1+4k5xADUbDY8xBi7QVZBeWKjSqK8PqxJekS4HHCBuGwgwd48KeKI/C0f0uZbECYoIAFRuo7s7PHgNijPQx+mVzWneyKa9pNTL1nvqUkjHmmaWmeuJ9QTG1/QfbOxJLKFPzCXdikckZ6+mFVbB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=zrSkIsGv; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="zrSkIsGv" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a72585032f1so48374466b.3 for ; Mon, 24 Jun 2024 00:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1719213759; x=1719818559; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P49JDi1xXPAYpLbhrU13RiWekT68KiQTL8uhFa+r3Dc=; b=zrSkIsGvgHhk5b6Unez81Ifk6PzTi5zIkEHCW9UaNdHLWyy21KY6jwuZG6c9G9SKmv Natychqkyjv9UzlwDZzPU5A2jJXxfmvWzMZNHLrquQRQnZ8K4J3evnBjdGNcKeWx6//O UCkXdqmn7KtidFccWISOvgVVClWHiv7EueB1LmMVF0DLKb0sbzGcDJnbWFYrU1skD50A /J6ZEWleZk9swXNkvbQw7bhNnAtySn6aQ0XkxfnJAvqRH/ZT2GOxDCeVkwQ0CsIFIRv8 zjPwMV1AAP4kcXTBwONWHuh3tZNYnyux1MKydQbspRwPrmtePSpQO3V/zrjMa4wtJgJi MgOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719213759; x=1719818559; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P49JDi1xXPAYpLbhrU13RiWekT68KiQTL8uhFa+r3Dc=; b=s2ETiXgOaR2wslhLhwUGWuKIMbOuFShBhjIGIgQowAufIG4F0wNHc+Me12YfHBIaF9 lH0QVh1SQE9aoyDRJ5hVOwsPM0yYdisKphpcuJuy8ADlXkFk7vWbH1ltDi96kGhIK1rN fTE9onC9TFP7PR/Wl0Snlm09Z4vJK9a36wmVuzAKIFQaC1wd0IBe5JOOScXVNATFKXPU lYndZ5VE+XhfX4OxM/YG5rrinyNRAYGRRpAxozrFoqsEnAkwLBdpFvK1pBxEeNOekFlD mD1gf/PUHwFJuLc4PZEHGGURkt1b/4FLtxVXihOepUzKf1rWT9BrXnZ/+trGKfSa9d49 A16Q== X-Forwarded-Encrypted: i=1; AJvYcCWh4FSU7Fgv9s4X3cs57yNMjBFJO+qD9Xruo0hWyrrKJ7xDy6ZuyhS/3DgExbmb611abTy7mobORGwyDzKBYD5mA3xudSyBSpTwLqZ+ X-Gm-Message-State: AOJu0Yx2XCuEn7WwHVgU0SolhW/FycbF9FgeA3OZoTSInkdjIKIKhLXU Jf9tS0evyG/lOqcdxOqoQG6nxb01wsexorZL+a/UVd3qskubmXj0GkEw9nxDYpM= X-Google-Smtp-Source: AGHT+IEMa8s/IzqM0+yHmNkv5YbQAah63TcfDGwvHHxW+U4X+runaXjbqEZ9o5SWB9bNGeVYIuUvmA== X-Received: by 2002:a17:906:9c96:b0:a72:5598:f03d with SMTP id a640c23a62f3a-a725598f1dfmr116904766b.59.1719213759525; Mon, 24 Jun 2024 00:22:39 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a710595adedsm238162166b.214.2024.06.24.00.22.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 00:22:39 -0700 (PDT) Message-ID: Date: Mon, 24 Jun 2024 09:22:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/15] drm/mediatek: add MT8365 SoC support To: Chun-Kuang Hu Cc: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Jitao Shi , CK Hu , Catalin Marinas , Will Deacon , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabien Parent References: <20231023-display-support-v4-0-ed82eb168fb1@baylibre.com> <20231023-display-support-v4-12-ed82eb168fb1@baylibre.com> Content-Language: en-US From: Alexandre Mergnat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21/06/2024 17:24, Chun-Kuang Hu wrote: > Hi, Alexandre: > > 於 2024年5月23日 週四 下午8:49寫道： >> From: Fabien Parent >> >> Add DRM support for MT8365 SoC. >> >> Signed-off-by: Fabien Parent >> Reviewed-by: AngeloGioacchino Del Regno >> Signed-off-by: Alexandre Mergnat >> --- >> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >> index ce8f3cc6e853..e1c3281651ae 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >> @@ -318,6 +318,10 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = { >> .mmsys_dev_num = 2, >> }; >> >> +static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data = { >> + .mmsys_dev_num = 1, > You do not describe the pipeline information here. I think display > function would not work. Hi Chun-Kuang, I don't describe the pipeline information here because I do it in the DTS thanks to the OF graphs Angelo's serie [1]. I've tested DSI and DPI display, they work correctly ;) [1] https://lore.kernel.org/all/20240618101726.110416-1-angelogioacchino.delregno@collabora.com/ -- Regards, Alexandre