From: "Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>
To: "ZhiJie.Zhang" <zhangzhijie@loongson.cn>,
alexander.deucher@amd.com, airlied@linux.ie, daniel@ffwll.ch,
christian.koenig@amd.com
Cc: mchehab+huawei@kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: stream's id should reduced after stream destruct
Date: Mon, 22 Feb 2021 14:24:59 -0500 [thread overview]
Message-ID: <cc528ba3-490d-dc19-16d4-43c27a6af203@amd.com> (raw)
In-Reply-To: <20210220063038.1790398-1-zhangzhijie@loongson.cn>
On 2021-02-20 1:30 a.m., ZhiJie.Zhang wrote:
> Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> index c103f858375d..dc7b7e57a86c 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> @@ -137,6 +137,8 @@ static void dc_stream_destruct(struct dc_stream_state *stream)
> dc_transfer_func_release(stream->out_transfer_func);
> stream->out_transfer_func = NULL;
> }
> +
> + stream->ctx->dc_stream_id_count--;
This is supposed to be a unique identifier so we shouldn't be reusing
any old ID when creating a new stream.
Regards,
Nicholas Kazlauskas
> }
>
> void dc_stream_retain(struct dc_stream_state *stream)
>
parent reply other threads:[~2021-02-22 19:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210220063038.1790398-1-zhangzhijie@loongson.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc528ba3-490d-dc19-16d4-43c27a6af203@amd.com \
--to=nicholas.kazlauskas@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=zhangzhijie@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®