Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Krzysztof Kozlowski <krzk@kernel.org>]

On 31/08/2026 11:03, Krishna Kurapati wrote:
> 
> 
> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>>> Currently for Glymur non-multiport USB controllers, number of interrupts
>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>>> present.
>>>
>>> Mark glymur non-multiport controllers to support a maximum of 6 interrupts
>>> including the hs_phy_irq and ss_phy_irq.
>>
>> Why?
>>
>>>
>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>> ---
>>> Changes in v2:
>>> - Modified commit text indicating the issue in max interrupt-names for
>>>    Glymur non-mp controllers.
>>>
>>> Link to v1:
>>> https://lore.kernel.org/all/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com/
>>> ---
>>>   Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>>> index ea60f7220afe..3bef18f9557e 100644
>>> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>>> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>>> @@ -524,7 +524,6 @@ allOf:
>>>           compatible:
>>>             contains:
>>>               enum:
>>> -              - qcom,glymur-dwc3
>>>                 - qcom,milos-dwc3
>>>                 - qcom,x1e80100-dwc3
>>>       then:
>>> @@ -547,6 +546,7 @@ allOf:
>>>             contains:
>>>               enum:
>>>                 - qcom,eliza-dwc3
>>> +              - qcom,glymur-dwc3
>>>                 - qcom,ipq4019-dwc3
>>>                 - qcom,ipq8064-dwc3
>>>                 - qcom,kaanapali-dwc3
>>
>> This changes the ABI without an explanation.
>>
> As per the harware specification, the controllers do have both 
> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that 
> info. Will update the commit message accordingly.
> 

So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was
incomplete? Lack of context here is not helping.

If they have these IRQs but it does not matter, then it is not a good
reason to change ABI and you should just add the clock as optional to
the end. Was this binding already released? I think yes.

Best regards,
Krzysztof