From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <menage@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
"containers@lists.osdl.org" <containers@lists.osdl.org>
Subject: Re: [PATCH -mm] cgroups: fix failure path in cgroup_write_event_control()
Date: Wed, 24 Feb 2010 15:28:31 +0200 [thread overview]
Message-ID: <cc557aab1002240528t28eae36dj976525be2fcf7246@mail.gmail.com> (raw)
In-Reply-To: <4B849B73.1040106@cn.fujitsu.com>
On Wed, Feb 24, 2010 at 5:22 AM, Li Zefan <lizf@cn.fujitsu.com> wrote:
> How to reproduce:
>
> # mount -t cgroup -o memory xxx /cgroup
> # mkdir /cgroup/tmp
> # ./cgroup_event_listener /cgroup/tmp/cgroup.event_control abc
> ^C
> # rmdir /cgroup/tmp
> # cat /proc/cgroups | grep memory
> memory 2 2 1 (should be "2 1 1")
> # umount /cgroup
> (failed!)
>
> Using a single goto label to cleanup multi failure paths can
> get things wrong quite easily, while multi labels makes the
> code cleaner.
I disagree.
It's easer to make mistake on changing code with multi failure
paths, if you want to move a code within function.
next prev parent reply other threads:[~2010-02-24 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 3:22 Li Zefan
2010-02-24 13:28 ` Kirill A. Shutemov [this message]
2010-02-24 16:06 ` Paul Menage
2010-02-25 0:43 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc557aab1002240528t28eae36dj976525be2fcf7246@mail.gmail.com \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®