From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401Ab0CBN4s (ORCPT ); Tue, 2 Mar 2010 08:56:48 -0500 Received: from mail-wy0-f174.google.com ([74.125.82.174]:51690 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753075Ab0CBN4p convert rfc822-to-8bit (ORCPT ); Tue, 2 Mar 2010 08:56:45 -0500 MIME-Version: 1.0 In-Reply-To: <20100302134736.GG3212@balbir.in.ibm.com> References: <1267478620-5276-1-git-send-email-arighi@develer.com> <1267478620-5276-4-git-send-email-arighi@develer.com> <20100302134736.GG3212@balbir.in.ibm.com> Date: Tue, 2 Mar 2010 15:56:44 +0200 Message-ID: Subject: Re: [PATCH -mmotm 3/3] memcg: dirty pages instrumentation From: "Kirill A. Shutemov" To: balbir@linux.vnet.ibm.com Cc: Andrea Righi , KAMEZAWA Hiroyuki , Suleiman Souhlal , Greg Thelen , Daisuke Nishimura , Andrew Morton , containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 2, 2010 at 3:47 PM, Balbir Singh wrote: > * Andrea Righi [2010-03-01 22:23:40]: > >> Apply the cgroup dirty pages accounting and limiting infrastructure to >> the opportune kernel functions. >> >> Signed-off-by: Andrea Righi >> --- >>  fs/fuse/file.c      |    5 +++ >>  fs/nfs/write.c      |    4 ++ >>  fs/nilfs2/segment.c |   10 +++++- >>  mm/filemap.c        |    1 + >>  mm/page-writeback.c |   84 ++++++++++++++++++++++++++++++++------------------ >>  mm/rmap.c           |    4 +- >>  mm/truncate.c       |    2 + >>  7 files changed, 76 insertions(+), 34 deletions(-) >> >> diff --git a/fs/fuse/file.c b/fs/fuse/file.c >> index a9f5e13..dbbdd53 100644 >> --- a/fs/fuse/file.c >> +++ b/fs/fuse/file.c >> @@ -11,6 +11,7 @@ >>  #include >>  #include >>  #include >> +#include >>  #include >>  #include >> >> @@ -1129,6 +1130,8 @@ static void fuse_writepage_finish(struct fuse_conn *fc, struct fuse_req *req) >> >>       list_del(&req->writepages_entry); >>       dec_bdi_stat(bdi, BDI_WRITEBACK); >> +     mem_cgroup_update_stat(req->pages[0], >> +                     MEM_CGROUP_STAT_WRITEBACK_TEMP, -1); >>       dec_zone_page_state(req->pages[0], NR_WRITEBACK_TEMP); >>       bdi_writeout_inc(bdi); >>       wake_up(&fi->page_waitq); >> @@ -1240,6 +1243,8 @@ static int fuse_writepage_locked(struct page *page) >>       req->inode = inode; >> >>       inc_bdi_stat(mapping->backing_dev_info, BDI_WRITEBACK); >> +     mem_cgroup_update_stat(tmp_page, >> +                     MEM_CGROUP_STAT_WRITEBACK_TEMP, 1); >>       inc_zone_page_state(tmp_page, NR_WRITEBACK_TEMP); >>       end_page_writeback(page); >> >> diff --git a/fs/nfs/write.c b/fs/nfs/write.c >> index b753242..7316f7a 100644 >> --- a/fs/nfs/write.c >> +++ b/fs/nfs/write.c > > Don't need memcontrol.h to be included here? It's included in > Looks OK to me overall, but there might be objection using the > mem_cgroup_* naming convention, but I don't mind it very much :) > > -- >        Three Cheers, >        Balbir > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org.  For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org >