From: Guenter Roeck <linux@roeck-us.net>
To: Oleksandr Ocheretnyi <oocheret@cisco.com>
Cc: jdelvare@suse.de, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, mika.westerberg@linux.intel.com,
wim@linux-watchdog.org, wsa@kernel.org,
xe-linux-external@cisco.com
Subject: Re: [PATCH v2] iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call
Date: Thu, 12 Sep 2024 14:15:54 -0700 [thread overview]
Message-ID: <cc652ed1-32c7-4ea2-b494-698b344f24a0@roeck-us.net> (raw)
In-Reply-To: <20240912141931.2447826-1-oocheret@cisco.com>
On 9/12/24 07:19, Oleksandr Ocheretnyi wrote:
> Commit da23b6faa8bf ("watchdog: iTCO: Add support for Cannon Lake
> PCH iTCO") does not mask NMI_NOW bit during TCO1_CNT register's
> value comparison for update_no_reboot_bit() call causing following
> failure:
>
> ...
> iTCO_vendor_support: vendor-support=0
> iTCO_wdt iTCO_wdt: unable to reset NO_REBOOT flag, device
> disabled by hardware/BIOS
> ...
>
> and this can lead to unexpected NMIs later during regular
> crashkernel's workflow because of watchdog probe call failures.
>
> This change masks NMI_NOW bit for TCO1_CNT register values to
> avoid unexpected NMI_NOW bit inversions.
>
> Fixes: da23b6faa8bf ("watchdog: iTCO: Add support for Cannon Lake PCH iTCO")
> Signed-off-by: Oleksandr Ocheretnyi <oocheret@cisco.com>
> ---
Oh, and change log goes here.
Guenter
next prev parent reply other threads:[~2024-09-12 21:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 7:53 [PATCH v1] iTCO_wdt: ignore NMI_NOW bit on register comparison Oleksandr Ocheretnyi
2024-08-26 11:18 ` Mika Westerberg
2024-08-26 15:12 ` Guenter Roeck
2024-08-26 15:15 ` Guenter Roeck
2024-08-26 15:41 ` Guenter Roeck
2024-09-12 14:19 ` [PATCH v2] iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call Oleksandr Ocheretnyi
2024-09-12 21:15 ` Guenter Roeck
2024-09-12 21:15 ` Guenter Roeck [this message]
2024-09-13 19:14 ` [PATCH v3] " Oleksandr Ocheretnyi
2024-09-17 1:09 ` Guenter Roeck
2024-10-07 15:57 ` Oleksandr Ocheretnyi
2024-10-08 16:33 ` Mika Westerberg
2024-09-13 5:29 ` [PATCH v2] " kernel test robot
2024-09-13 7:58 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc652ed1-32c7-4ea2-b494-698b344f24a0@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=oocheret@cisco.com \
--cc=wim@linux-watchdog.org \
--cc=wsa@kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®