From: Matt Redfearn <matt.redfearn@mips.com>
To: James Hogan <jhogan@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>,
<stable@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] MIPS: memset.S: EVA & fault support for small_memset
Date: Tue, 17 Apr 2018 14:20:07 +0100 [thread overview]
Message-ID: <cc6ab882-6862-2cdc-fdaf-cf0d0ba22728@mips.com> (raw)
In-Reply-To: <20180416202234.GA23881@saruman>
Hi James,
On 16/04/18 21:22, James Hogan wrote:
> On Thu, Mar 29, 2018 at 10:28:23AM +0100, Matt Redfearn wrote:
>> @@ -260,6 +260,11 @@
>> jr ra
>> andi v1, a2, STORMASK
>
> This patch looks good, well spotted!
>
> But whats that v1 write about? Any ideas? Seems to go back to the git
> epoch, and $3 isn't in the clobber lists when __bzero* is called.
No idea what the original intent was, but I've verified that v1 does
indeed get clobbered if this path is hit. Patch incoming!
Thanks,
Matt
>
> Cheers
> James
>
>>
>> +.Lsmall_fixup\@:
>> + PTR_SUBU a2, t1, a0
>> + jr ra
>> + PTR_ADDIU a2, 1
>> +
next prev parent reply other threads:[~2018-04-17 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 9:28 [PATCH 0/2] MIPS: memset.S: Fix 2 issues with __clear_user Matt Redfearn
2018-03-29 9:28 ` [PATCH 1/2] MIPS: memset.S: EVA & fault support for small_memset Matt Redfearn
2018-04-16 20:22 ` James Hogan
2018-04-17 13:20 ` Matt Redfearn [this message]
2018-05-14 22:56 ` Maciej W. Rozycki
2018-03-29 9:28 ` [PATCH 2/2] MIPS: memset.S: Fix return of __clear_user from Lpartial_fixup Matt Redfearn
2018-04-16 22:13 ` James Hogan
2018-04-17 13:21 ` Matt Redfearn
2018-04-17 13:59 ` [PATCH v2] " Matt Redfearn
2018-04-17 14:52 ` [PATCH v3] " Matt Redfearn
2018-04-17 15:43 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc6ab882-6862-2cdc-fdaf-cf0d0ba22728@mips.com \
--to=matt.redfearn@mips.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome