From: Gang Li <ligang.bdlg@bytedance.com>
To: Waiman Long <longman@redhat.com>
Cc: rientjes@google.com, linux-kernel@vger.kernel.org,
Zefan Li <lizefan.x@bytedance.com>,
cgroups@vger.kernel.org
Subject: Re: Re: [PATCH v2] mm: oom: introduce cpuset oom
Date: Thu, 6 Apr 2023 21:02:17 +0800 [thread overview]
Message-ID: <cc77d706-7baf-951b-13a5-3470c2b1bba9@bytedance.com> (raw)
In-Reply-To: <342c1967-8a68-275c-042e-765d5993157c@redhat.com>
On 2023/4/5 01:24, Waiman Long wrote:
>
> You will also need to take cpuset_rwsem to make sure that cpusets are
> stable. BTW, the cpuset_cgroup_scan_tasks() name is kind of redundant. I
> will suggest you just name it as cpuset_scan_tasks(). Please also add a
mem cgroup oom use `mem_cgroup_scan_tasks`.
How about keep `cpuset_cgroup_scan_tasks` for naming consistency?
```
static void select_bad_process(struct oom_control *oc)
{
oc->chosen_points = LONG_MIN;
if (is_memcg_oom(oc))
mem_cgroup_scan_tasks(oc->memcg, oom_evaluate_task, oc);
else if (oc->constraint == CONSTRAINT_CPUSET)
cpuset_cgroup_scan_tasks(oom_evaluate_task, oc);
else {
...
}
}
```
next prev parent reply other threads:[~2023-04-06 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 11:55 Gang Li
2023-04-04 14:31 ` Michal Hocko
2023-04-04 17:24 ` Waiman Long
2023-04-06 3:04 ` Gang Li
2023-04-06 13:02 ` Gang Li [this message]
2023-04-06 15:53 ` Waiman Long
2023-04-06 3:22 ` Gang Li
2023-04-06 8:30 ` Michal Hocko
2023-04-06 8:33 ` Gang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc77d706-7baf-951b-13a5-3470c2b1bba9@bytedance.com \
--to=ligang.bdlg@bytedance.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®