From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC420C77B7A for ; Wed, 24 May 2023 13:54:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235572AbjEXNyb (ORCPT ); Wed, 24 May 2023 09:54:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235028AbjEXNy3 (ORCPT ); Wed, 24 May 2023 09:54:29 -0400 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20E1CA7; Wed, 24 May 2023 06:54:28 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 770C38467A; Wed, 24 May 2023 15:54:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1684936466; bh=H9hgBK0Z2k4KJJri9AujHyxs0n8pT/bxbNuwzwsiCD8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BKJc/stDc1RkyJLgAWaetW9Omb0UyyG8moL/uAoBsi7B6NkeSYbJmzq5bv4tjoqEI iD0CMkZAqmHD2fcHv9bxLxF+IcmC52hpehwWsB8qjwWbsNWNhvAf5dr+F4i3GL2gqd szo2JC9cePe9cIQOzIpdM9ee4rLAPgD6+CsYfyWj2KukDenhhiRtBjpjsptgFgE9uu 74HFFLZGdJsPhIKDmy/68A72hObbwJHnDturWRDNABjc3K+ociAHFCWZ/xUj32jogC KPRUxRMMBcvX5PCandiuEAiuy4aFLFKuknILFRb0Czqa1kUj1Tk1/3VoKjxI5HYWJ9 ea1pBJgPn2dOg== Message-ID: Date: Wed, 24 May 2023 15:54:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 7/8] ARM: dts: stm32: adopt generic iio bindings for adc channels on dhcor-drc Content-Language: en-US To: Olivier Moysan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue Cc: kernel@dh-electronics.com, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230524133918.1439516-1-olivier.moysan@foss.st.com> <20230524133918.1439516-8-olivier.moysan@foss.st.com> From: Marek Vasut In-Reply-To: <20230524133918.1439516-8-olivier.moysan@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/23 15:39, Olivier Moysan wrote: > Use STM32 ADC generic bindings instead of legacy bindings on > DHCOR DRC Compact board. > > The STM32 ADC specific binding to declare channels has been deprecated, > hence adopt the generic IIO channels bindings, instead. > The STM32MP151 device tree now exposes internal channels using the > generic binding. This makes the change mandatory here to avoid a mixed > use of legacy and generic binding, which is not supported by the driver. > > Signed-off-by: Olivier Moysan > --- > .../dts/stm32mp15xx-dhcor-drc-compact.dtsi | 28 ++++++++++++++++--- > 1 file changed, 24 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi > index 39af79dc654c..92d906bfd5d7 100644 > --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi > +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi > @@ -57,15 +57,35 @@ &adc { /* X11 ADC inputs */ > status = "okay"; > > adc1: adc@0 { I sent similar patch recently too: [PATCH] ARM: dts: stm32: Update to generic ADC channel binding on DHSOM systems But I needed to add #address-cells/#size-cells here and to adc@100, otherwise DTB checker was complaining . Did you run DTB check and was it OK on your side ? > - st,adc-channels = <0 1 6>; > - st,min-sample-time-nsecs = <5000>; > status = "okay"; > + channel@0 { > + reg = <0>; > + st,min-sample-time-ns = <5000>; > + }; > + channel@1 { > + reg = <1>; > + st,min-sample-time-ns = <5000>; > + }; > + channel@6 { > + reg = <6>; > + st,min-sample-time-ns = <5000>; > + }; > }; [...]