From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C57FCC433EF for ; Thu, 21 Jul 2022 11:52:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233286AbiGULws (ORCPT ); Thu, 21 Jul 2022 07:52:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232470AbiGULwq (ORCPT ); Thu, 21 Jul 2022 07:52:46 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 695E783234 for ; Thu, 21 Jul 2022 04:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658404363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kwcu/6jioYC6fESk86Od43i9Yz4XnMzrxYAr7rGMUf0=; b=KvCAcvca7CvjJoutLS0mVX0p480JE3V/4GpXRDm1i1VxG5yxvGj0Ua8rZwtu2d/CS4CuQb tHQlJbKV6wkogCcqaErHYX3ktOCvhlaAdE7nHZ6P8EEBYezr5eTDOmUYWtzrzu95nNqUnv rFZ1Ofot7M6zqRoLEGV0Mkq/xIiZhD4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-48-p3HKVR-iM02IYJH7o3thIg-1; Thu, 21 Jul 2022 07:52:39 -0400 X-MC-Unique: p3HKVR-iM02IYJH7o3thIg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92EAE3C0D869; Thu, 21 Jul 2022 11:52:38 +0000 (UTC) Received: from starship (unknown [10.40.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 11C04403D0E0; Thu, 21 Jul 2022 11:52:34 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 03/11] KVM: x86: emulator: remove assign_eip_near/far From: Maxim Levitsky To: Sean Christopherson Cc: kvm@vger.kernel.org, x86@kernel.org, Kees Cook , Dave Hansen , linux-kernel@vger.kernel.org, "H. Peter Anvin" , Borislav Petkov , Joerg Roedel , Ingo Molnar , Paolo Bonzini , Thomas Gleixner , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson Date: Thu, 21 Jul 2022 14:52:34 +0300 In-Reply-To: References: <20220621150902.46126-1-mlevitsk@redhat.com> <20220621150902.46126-4-mlevitsk@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-07-20 at 23:51 +0000, Sean Christopherson wrote: > On Tue, Jun 21, 2022, Maxim Levitsky wrote: > > Now the assign_eip_far just updates the emulation mode in addition to > > updating the rip, it doesn't make sense to keep that function. > > > > Move mode update to the callers and remove these functions. > > I disagree, IMO there's a lot of value in differentiating between near and far. > Yeah, the assign_eip_near() wrapper is kinda silly, but have that instead of > a bare assign_eip() documents that e.g. jmp_rel() is a near jump and that it's > not missing an update. > OK, I'll drop this patch then. Best regards, Maxim Levitsky