From: Markus Elfring <Markus.Elfring@web.de>
To: Siyang Liu <1972843537@qq.com>, sparclinux@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Andreas Larsson <andreas@gaisler.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] arch: fix resource leak in chmc.c
Date: Fri, 18 Jul 2025 15:43:27 +0200 [thread overview]
Message-ID: <cc7db82b-0337-4342-aeaf-ec6376cbcc74@web.de> (raw)
In-Reply-To: <tencent_C3DEC6F98F25C1BF6F35F3A1B0A629E0EA0A@qq.com>
> In the jbusmc_probe function, the device node mem_node fetched
> via of_find_node_by_path("/memory") is not properly freed
> on all code paths.
…
You may occasionally put more than 62 characters into text lines
of such a change description.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n94
* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
* Will an other subsystem specification be more appropriate?
* Would it be more helpful to refer to “jbusmc_probe()” instead of “chmc.c”
in the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2025-07-18 13:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 9:22 Jacky Liu
2025-07-18 13:25 ` Krzysztof Kozlowski
2025-07-21 2:04 ` jackysliu
2025-07-18 13:43 ` Markus Elfring [this message]
2025-07-21 3:57 ` [PATCH v2] arch: fix resource leak in jbusmc_probe() jackysliu
2025-07-21 7:18 ` Markus Elfring
2025-07-21 7:55 ` [PATCH v3] sparc: " jackysliu
2025-07-21 8:17 ` Markus Elfring
2025-07-22 6:22 ` Krzysztof Kozlowski
2025-07-21 8:25 ` [PATCH v2] arch: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7db82b-0337-4342-aeaf-ec6376cbcc74@web.de \
--to=markus.elfring@web.de \
--cc=1972843537@qq.com \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®