From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD2383161B5 for ; Mon, 26 Jan 2026 10:23:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769423038; cv=none; b=hd5tKnw15VODMhcZ7iSObjEgbcZyhso1io8WZl5vKKQxiMfjQXlOJ+gwk2nAcLqW5KSXLDhkOEOLk2OQirH9Dr3yBKEsw51YiQaQ2aNDghdV82KMMlF/5bEGvYAsB1aTtuZjLbVXh6MZlTZ8oCZ7qG2h/SZYWi6yUMXcO0VQVTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769423038; c=relaxed/simple; bh=94ux3DATjgnyZVByJTnPpMaLj5Y+euaNR6JNSuQb85A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H9v7jUh/2dKhoV/8oZIhKv4bxfd2tX2KmK89kW110Ml8wT8NHq7B9GM9pukWjb5FSzke7jEyBtAl5g05lDcRWzAfBjVNCsL9+Z1BYyIpN478PCn1iHbmnd3ok7GQF/hgtjklmLtIMRreUIzv65aHL0lglWzhCVNptogKs5QxUBw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZWv4yEiY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VvDe8sQU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZWv4yEiY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VvDe8sQU" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60Q8wtcI499513 for ; Mon, 26 Jan 2026 10:23:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GLqLV1YDeug/efmj0GLJptkf3ni7N+0r7HGaQFhUIhA=; b=ZWv4yEiYOlJL48E0 X/a13NNw9PXNE1e3doU9Y+p/3e5dbrOGNer71bxORX3dP3qzFfxHPoZMZvcWVjLz Gp8oZNUxk7e0/MwsTa1XcYUC+vlA6P2iSbrnzoY5d8apvTNm7q/vJ7qRw0RXeFIw XGYYsHLZFizjPqNU7hSuOmnFZJAvKw2B0hCv7hFKkfMzIGp4FOvdkFC6j6kHppqe 8t+H5vY6f57kxxAPYhlnKp/zyFWKXj3OWuAFxDhNiUhr43NtTwc4oTnLEfxjVRho 2hRn84PiTwvbqdVw1DASxVMjzyTLefOnUto8BQMno2TzHLwlTLybmlqbsdeYd6Ep XQrmog== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bvq9qm75d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Jan 2026 10:23:55 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c523d611ffso78076085a.2 for ; Mon, 26 Jan 2026 02:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769423035; x=1770027835; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GLqLV1YDeug/efmj0GLJptkf3ni7N+0r7HGaQFhUIhA=; b=VvDe8sQU0K0OK0qXhOd77FjOjadB4zNnsMy0zWHzZ999lbc47zYe6tQMytnQDMp05F BvuWymU6UPSmfdASDX6xzvvKWxfGmzn9ZVaMYQV4OI67eIAbuar21cYQqtzqBzHKxVIB Ay02o+kH58pHZLLTZ4VvHrFqn34AVm6cmh89Db4YmlIrZWVH0oxBjG6BOCLJ9SY1ancu lOvyLUK5P/eOfmY5nspxOa9yx+Wcr1TSZyX05h9IEc6E4WOe5rMxJFmxmZLuE2K6Di8+ bquE/1JovgyMXYDjnc/Ga2MXvI4gcufDZFX0K96LHJTeiJ+n0mWrmZqK9csAB2G/OjNY R3KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769423035; x=1770027835; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GLqLV1YDeug/efmj0GLJptkf3ni7N+0r7HGaQFhUIhA=; b=RWMulO+DwXFoUyIiSMjcxV/lVjWDiT5WkyYa15vlmIQEjDPPQpW/qzqGmwcehuKKmM ca5MvHBoPlmp/hXlcFaJkBIe22bEau3BH+SU2KLvfRzjZT/2CfIaeJpxtDf9wC7qx6Fp teMlOmvQ7RX1M7welHzvGNOvGh3Xo0VvixSQfirnGWYpKAmkhfeijSehBREqEICof9Hs 7xiYprf5siFFnm/54m/xmNrSLVd2CiiAD7tVYuTSaK8CMU2X22r4dLvZOUZhVKnLffEp bzZfkq7RmcEofSWiG1rDPbm25PEFAR6p1X3vCoo/V+UvUntmfNY8pGU+DuZprALgqpxy 4tuQ== X-Forwarded-Encrypted: i=1; AJvYcCUNgyNBZCGWn1bf8a/dK4OgeU5gNZ8MsBVx5bZIHu6gLhnzi/lO8nD5bCOQl2DTN+QG034HMkGKPxoJYaQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwzIcebD4lNxDerMSz4U4zr7fcW88KdjPTYGcZAK/DRscc9msj/ NbS7WmsVbJj/Od5T7uKHz3UFHS5CPyfRz3uf0Dy8uA3tYBBlGcbT2p4Po7JTYV9VMkiHePrGRwt R/vgq3rfzanlHuwPT8DXpqCJPnFwRxNBprrUS2z5Pjgv1z95RfMk4Qe4lIPs8gQl+ppg= X-Gm-Gg: AZuq6aLWjfjGi3fWd+5lQvuAFJGG+MMjlIaKg+EKbm8rzNWh5WxlU014D958InAnr4S lUOdRUcLuUbI/wzOmXlX0VNn1lZd1CPKEiJSRvubvuWSU23DtXWBk0Mbn5VbfJm4I/c6yzAiyTr sl+VYUjM9LLafwDNCBrfV2u9SvRgjsA0Q1RUCC8AlndDG9pIQxLOoTOwThdnlx7xTrfVB/UuvsW /RsYKwZZH0T4YzOtgX1Q4sXHvLtc7W0tqzCe0h2TMOjTHzBUYyNfNWuqpDMhX6pb0D8eKUKN2bf jdxj1orN3sZ9W8DKPY0mHxIPp9PfCoqJEdMg6fZmY90LxLIvz0xZRJ2P6JyctIGXyU1yQgf+mdb U5j5LfCoL1ToomC0vTDGl3vVg9dAOVpOLr1Zma6fCWWXjOA5veRjtFDEPNdXTymccAn4= X-Received: by 2002:a05:620a:4688:b0:8a2:568c:a88b with SMTP id af79cd13be357-8c6f9677c99mr336821185a.11.1769423035240; Mon, 26 Jan 2026 02:23:55 -0800 (PST) X-Received: by 2002:a05:620a:4688:b0:8a2:568c:a88b with SMTP id af79cd13be357-8c6f9677c99mr336819785a.11.1769423034775; Mon, 26 Jan 2026 02:23:54 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6584b92b66dsm5153265a12.20.2026.01.26.02.23.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 02:23:54 -0800 (PST) Message-ID: Date: Mon, 26 Jan 2026 11:23:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] soc: qcom: ice: Add OPP-based clock scaling support for ICE To: Dmitry Baryshkov , Abhinaba Rakshit Cc: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <20260123-enable-ufs-ice-clock-scaling-v3-0-d0d8532abd98@oss.qualcomm.com> <20260123-enable-ufs-ice-clock-scaling-v3-1-d0d8532abd98@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: JmPn15QvbKURizcV3GA66m1o5CZCmtM8 X-Proofpoint-GUID: JmPn15QvbKURizcV3GA66m1o5CZCmtM8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI2MDA4OCBTYWx0ZWRfX6IkAQNSrN5S1 JtGqBvD+GBRPFwtQ53leYNA4fdlyTSLn16bUCJe1AAkXvlDnqXI9T8VLQB6OOl35jB9g47vPnRE w8fylrqeub1YDeUevawj3NIJTWF2niRinxEvFBtz6IAv7/94kckYARovdweuCatEe6Ahnzr6clG sOkeaU95bXB34pgg9W5fJqv3W7oZ4TNhYFAMYd9G9po7cIjUFAurzR+S7YmUiMaYpMD9fEqXchN o0Zjaaaz+5WcJ9/QI0mR1a4AHzapdW8WI+VCSRnUjb450h+pPQA831G7IXhh0/HEz1STdfi4zLY jXHi9RAjUivqkwCwKFS3Pzh8SPz4631NTKi25xwCUCBlgArLMAeNGpdReNqIYvopG1jkApqx6tN nkSGN4rcYkV74ne4hbzdNFYCw4oDaGQBgoktirYxN0dmcTrbILM0L7P/PQoaHhUzHlwwGfS3E5q 3SwHFn338CKTaIg/DYQ== X-Authority-Analysis: v=2.4 cv=TsTrRTXh c=1 sm=1 tr=0 ts=697740bb cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=oXxr4s8vNUwlBxEnOasA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-26_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601260088 On 1/23/26 8:21 PM, Dmitry Baryshkov wrote: > On Fri, Jan 23, 2026 at 12:42:12PM +0530, Abhinaba Rakshit wrote: >> Register optional operation-points-v2 table for ICE device >> and aquire its minimum and maximum frequency during ICE >> device probe. >> >> Introduce clock scaling API qcom_ice_scale_clk which scale ICE >> core clock if valid (non-zero) frequencies are obtained from >> OPP-table. Disable clock scaling if OPP-table is not registered. >> >> When an ICE-device specific OPP table is available, use the PM OPP >> framework to manage frequency scaling and maintain proper power-domain >> constraints. >> >> Signed-off-by: Abhinaba Rakshit >> --- [...] >> +int qcom_ice_scale_clk(struct qcom_ice *ice, bool scale_up) >> +{ >> + int ret = 0; >> + >> + if (!ice->has_opp) >> + return ret; >> + >> + if (scale_up && ice->max_freq) >> + ret = dev_pm_opp_set_rate(ice->dev, ice->max_freq); >> + else if (!scale_up && ice->min_freq) >> + ret = dev_pm_opp_set_rate(ice->dev, ice->min_freq); > > Do we expect that there allways will be only two entries in the OPP? > If so, it should be a part of the bindings. If not, please design the > API with more flexibility in mind. hamoa: LOW_SVS: 100 MHz SVS: 201.5 MHz NOM: 403 MHz Konrad