From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933607AbdJQO3I (ORCPT ); Tue, 17 Oct 2017 10:29:08 -0400 Received: from esa2.dell-outbound.iphmx.com ([68.232.149.220]:65064 "EHLO esa2.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932730AbdJQO3G (ORCPT ); Tue, 17 Oct 2017 10:29:06 -0400 From: X-LoopCount0: from 10.166.132.195 X-IronPort-AV: E=Sophos;i="5.43,391,1503378000"; d="scan'208";a="1045473982" X-DLP: DLP_GlobalPCIDSS To: CC: , , , , , , , , , , Subject: RE: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI Thread-Topic: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI Thread-Index: AQHTRK3puFrO07UkKEesnas/bEZnH6LmbHqAgAAL+yCAAFm2gP//rO5ggADer4CAAL5yIA== Date: Tue, 17 Oct 2017 14:22:34 +0000 Message-ID: References: <20171016073307.ahdc6ogzytzwckpq@pali> <0aebeec94bad4ca9baae335ef9e591b8@ausx13mpc120.AMER.DELL.COM> <20171016133705.cf4f5jqgq4ebhfcj@pali> <20171016215647.GD14419@fury> In-Reply-To: <20171016215647.GD14419@fury> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9HETEC1024742 > -----Original Message----- > From: Darren Hart [mailto:dvhart@infradead.org] > Sent: Monday, October 16, 2017 4:57 PM > To: Limonciello, Mario > Cc: pali.rohar@gmail.com; andy.shevchenko@gmail.com; linux- > kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; luto@kernel.org; > quasisec@google.com; rjw@rjwysocki.net; mjg59@google.com; hch@lst.de; > greg@kroah.com; gnomes@lxorguk.ukuu.org.uk > Subject: Re: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI > > On Mon, Oct 16, 2017 at 01:48:05PM +0000, Mario.Limonciello@dell.com wrote: > > > -----Original Message----- > > > From: Pali Rohár [mailto:pali.rohar@gmail.com] > > > Sent: Monday, October 16, 2017 8:37 AM > > > To: Limonciello, Mario > > > Cc: dvhart@infradead.org; andy.shevchenko@gmail.com; linux- > > > kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; > luto@kernel.org; > > > quasisec@google.com; rjw@rjwysocki.net; mjg59@google.com; hch@lst.de; > > > greg@kroah.com; gnomes@lxorguk.ukuu.org.uk > > > Subject: Re: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI > > > > > > On Monday 16 October 2017 13:23:04 Mario.Limonciello@dell.com wrote: > > > > > -----Original Message----- > > > > > From: Pali Rohár [mailto:pali.rohar@gmail.com] > > > > > Sent: Monday, October 16, 2017 2:33 AM > > > > > To: Limonciello, Mario > > > > > Cc: dvhart@infradead.org; Andy Shevchenko > ; > > > > > LKML ; platform-driver- > x86@vger.kernel.org; > > > Andy > > > > > Lutomirski ; quasisec@google.com; rjw@rjwysocki.net; > > > > > mjg59@google.com; hch@lst.de; Greg KH ; Alan Cox > > > > > > > > > > Subject: Re: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI > > > > > > > > > > Hi! Just a small idea, what about including example userspace > > > > > application which would use this new API? I think such application can > > > > > be useful for documentation purpose to see how this new API should be > > > > > used. And in review process other people can point if there would be > > > > > some problems with usage. > > > > > > > > > > I do not know if it is requirement or not for introducing new kernel > > > > > API, but still example code is very useful for developers when they > > > > > would start to use this new API and correctly. > > > > > > > > > > -- > > > > > Pali Rohár > > > > > pali.rohar@gmail.com > > > > > > > > Pali, > > > > > > > > I've produced a small sample application available here: > > > > https://github.com/superm1/smbios-wmi-poc > > > > > > Simple one-file example application. Great! > > > > > > Darren, Greg, Mario, I think it would be better to have this example > > > application in tools/ or in Documentation/... What do you think? > > > > > > Looking for examples on random github repos is harder and less official > > > as part of linux source tree. > > > > > > > If others also agree, I'm fine with including it with the kernel. > > Please advise where it should be located. > > > > It was originally a POC made just for my own testing of this API. > > I will probably need to clean it up a little though for wider distribution > > to the kernel so I would prefer to send it in a follow up patch if no other > > feedback requiring changes to this series as is. > > > > One possible issue is that it currently uses glib. Is that OK? > > In my opinion, what is important is that there is an open-source > userspace consumer of the interface. I don't think it needs to be in the > kernel. If this was a more generic interface which could be tested on > any hardware, then I think a selftests target would be sensible. As it > is, this is a very specific use case, and a simple reference to the > smbios-wmi-poc project URL in documentation someplace (or even in the > dell-smbios driver comments) seems more than adequate to me. > To Pali's point I noticed stuff like this: https://github.com/torvalds/linux/blob/master/tools/laptop/freefall/freefall.c which shows how to use /dev/freefall. I don't mind to switch my tool to drop glib and bring in kernel. I'll plan to bring it in here in a separate patch: tools/wmi/dell-smbios-example.c kbuild test robot caught a few other missing includes for certain situations, so I'll be making another change set for that anyway. Thanks,