From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64E84365A08 for ; Fri, 13 Mar 2026 07:12:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773385923; cv=none; b=QVs4cNzIWh4ZwkmkQfzOgrTKJdvF7rbXOETfYmhM6YSonuNmV3ZJ5+3rKKZwgq6zKfOya/yhAFTyBjbd5+lzi+Gs/8McaRqc6hQwGwEw6qTa3z+XSd+hr1xhOKGmgY6m9KC/kB24Za67d3PnnGpdePqxO6P8Qm8UovFi24SV5vw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773385923; c=relaxed/simple; bh=D6f/BwYXcJOrXzpLqcA4NOX61Awax9Bd1wbehrI+Ae8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eP8Bq8AFAtwyhjj1XAP3ardoLXYwiLOMNMC5Da8QcfRRGlpIXkFeZKISNqpAuAEhhzMCoD6R7d0v9fnDK8M3RwsajOVUu0mwx2+cZx8i8avMiErX7n/kY7pGHS+dt2lnttVNi/piQOGBCoYyMBIRmXMqJv55tAr1fIxPMo+aLEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IMhQVKwO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f4kT8E1m; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IMhQVKwO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f4kT8E1m" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D5teCo3342531 for ; Fri, 13 Mar 2026 07:12:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oHVR46XjyvGbQEw/YQd7mH/wCqOIBJhQ6+YqoOc2ars=; b=IMhQVKwOvVzdfHGB R2Qbis7dwg7yhdh/j+9uF184x3PSMPr8SrQlnUIDMIXJsecadv7V5BiKO3wTEWem qLuwvVF3B2IzdWnv0+0jW7UFaL6faZb/xy3CeB4viCrzRR5Emlad2vjkwL2/++k8 3dPCUl3tmV/ON+WV8F5V4x0t1rwVTPXWILlK+nq3bk5anZL2/FBINez3naLiBiK5 BzuWv46GyQ5lXGiBN5Rr2Uuvj3xj825QBhqYI5YwFu4V2fdEAilxZ5cgSQjbXKxY UDMNxC6YkWCi8Glxo3BuiJ6vg/x2IyqZ4x4mXwXJ5codktAC1E/NmVvTjeRZ6598 3tDShw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w3mxg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 07:12:01 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2aebfa0af7dso96682095ad.1 for ; Fri, 13 Mar 2026 00:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773385920; x=1773990720; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oHVR46XjyvGbQEw/YQd7mH/wCqOIBJhQ6+YqoOc2ars=; b=f4kT8E1my5E+1tustQDZ2WRRx8BXGw4c0C0NLRGuR5AvL3dHMQVS+PEPgZ/UJneOGQ 2Wl/7zdX3uhln0vGKSjSHIH+VRfxvpar11qreNIuzzIUW1w6uN0wjktovm43UBC/SQPX GleR+zNQ32QVl316XPbJEcVNYB+8v77sznQtTHem0M5TiEFDbSSobJCgk+6DiBDPMqQ/ J0uLlb0bTIvZzxoxI9u4Q6WCK2iWEz2/q9Y5xzLQZS+X4YLrwX9wHwRigKKPTJfFQlnU SbsVY/XpieiJEeotsLOVWE+aVuiRL6Q04jGZSvSPDwD/HBKBY5SlkxwJtzdx05+GBpbj rEvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773385920; x=1773990720; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oHVR46XjyvGbQEw/YQd7mH/wCqOIBJhQ6+YqoOc2ars=; b=sNO2f3KXZNk9FGEpnRQhEVOXeohkZds/IawKk8WgDEps/GtdQ1XzheHtEoTfsWnHYT EAtZ060AZxibDHfVPXhEfVvamzscLdyyNzbqZCaTCRy87I7vNKGtdiG4aTrhgkeH+jFL bx0HWaG9jvvoGwphIsyTvXws2NnackTx1MwXfD5hGPW/LpZt5z3Bw/06TUb6ZvhaMQK/ KTSpLr5d5YQxLwlX4QIH/Gj+8Ssr2spDZFCNyIYbtjaFzGaO+vAFF1xIF3VqwrfINfak mQomeX28J1eMpD51ijySw4PEcdIMErXzE9WNm+6AmY01brJILyup2oY9Fz+t8IcBijo+ O4Aw== X-Forwarded-Encrypted: i=1; AJvYcCXBfrCOGucIW9FqD4DPyp98Q2B6Brp4i13LhmNzzL+u2FwnP6mGKiYHnGOykLuT+0GBlzWo++zBz40wdHI=@vger.kernel.org X-Gm-Message-State: AOJu0YwTbpK5Rx6DLoFn16p3EJC9ThRLiQ8vUV6iPzmS/LcfZVwVpDhF 7FeOV0ZeQ75US2S5yXmIdOofoJYEMqK51g4HhiBOJCZcQ0gvVC9uJbU0MqLRffrJmZzs3Un1q+C 9tBZcNsvLezE1ZnpdhlnNULE+3g/ivv3SOlfPH/GhTr+ciEVLDeor7CV6GPaVebBUbVq1Fbc0/i c= X-Gm-Gg: ATEYQzye+yREy4AQqB+RpKcE/BAz+by/u0rM1xh700HxXJuRQoIIEHPTOyvbjzRbK4D XwDWEdlQe+8JvwDh6cd5PNQSDMAeyfyEWSof954kZWiYDkv9Asg0ScXAFkJpMO5xzAVdhRdGJWs Tj471PgzIZlOJ9dzRrVERREApOTvfT+bevbHwW5UwV+qoPDipvhEJ1y/kC9MbC/BKFWJRaOKJOl 4n/swYO3U5BXayCEXvIEkUuq+5JShlHOOwEHh19yyU+J/Y3sBi8+ZTD/nxwz6WiIgZv1sJCL4gR 5V3J09Joiq/nkO/3GH3jatYAkjau81xyxGE95RT7qUzBJvB/fnHdYJ/CDygs8FvrQGWIRKB+YwG AL27N69zhAoBAlOJDKVOPJqe96WPnCw6jYTVZAIZ5TPYWlJn0f1ob X-Received: by 2002:a17:903:1987:b0:2ae:cc1d:f902 with SMTP id d9443c01a7336-2aecc1e0051mr18831175ad.25.1773385919968; Fri, 13 Mar 2026 00:11:59 -0700 (PDT) X-Received: by 2002:a17:903:1987:b0:2ae:cc1d:f902 with SMTP id d9443c01a7336-2aecc1e0051mr18830895ad.25.1773385919498; Fri, 13 Mar 2026 00:11:59 -0700 (PDT) Received: from [10.0.0.3] ([106.222.229.52]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece56cde9sm14362255ad.15.2026.03.13.00.11.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 00:11:59 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 12:41:54 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 4/8] media: qcom: iris: split HFI session ops from core ops Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260313-iris-platform-data-v4-0-14927df4906d@oss.qualcomm.com> <20260313-iris-platform-data-v4-4-14927df4906d@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260313-iris-platform-data-v4-4-14927df4906d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: H6RN4mcmbdDdKVSNU0y3LufMf90XCM4j X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b3b8c1 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ndT/fs+coltRyMHftQWjTw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=loUjW8O-33FAN067BsEA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA1NiBTYWx0ZWRfXxRofXuhpfM4W Ixz+TxV2l7SOZZvxDpeu/XNgpQhlRs7YCLP0/ybo+NSkPIT22uIn+ruIBZx3wP3DKyna0X+Qiq/ X+BxP2pOCkOeKmpVCP1PXSjEANkDKrDP+0Aixo1F9XpIQXK64o++WgBZ7XesHeWUy+q23acjPRh ERkgSHk2kGchcJbBdybERtZInyWg1jJbWop6A78HjI7xs/klNYqEb6aC/agNRUxEwaf2G1T2f0o ZBpAycAfovD+A/168mHNVPisjC+UXf8pL3wLEaXlLw2Zt3RO1XBBZP9rQ39/OnExQz30FzXbma3 SSd0KKCv6e1JRK2uQQBWkwW6M8N0jk8oV9JTgWgqztHXxXgsDPczdnjoQFsuGTwyWSS1NlXQVgy fUTPFWHTibrFn8D5T+xTZOhddMjMMjxDFpfe+NO9K7DbHFuASuy9rLBFkhQWvs0HVrRdhpVOInd c0q9A9JvAcrTIgZnEaQ== X-Proofpoint-ORIG-GUID: H6RN4mcmbdDdKVSNU0y3LufMf90XCM4j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130056 On 3/13/2026 9:00 AM, Dmitry Baryshkov wrote: > Calling HFI instance-specific ops should not require double indirection > through the core ops. Split instance-specific ops to a separate struct, > keep a pointer to it in struct iris_inst and set it directly in the > get_instance function. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_buffer.c | 4 +- > drivers/media/platform/qcom/iris/iris_common.c | 8 ++-- > drivers/media/platform/qcom/iris/iris_ctrls.c | 46 +++++++++++----------- > drivers/media/platform/qcom/iris/iris_hfi_common.h | 3 ++ > .../platform/qcom/iris/iris_hfi_gen1_command.c | 23 ++++++++--- > .../platform/qcom/iris/iris_hfi_gen2_command.c | 17 +++++--- > drivers/media/platform/qcom/iris/iris_instance.h | 4 ++ > drivers/media/platform/qcom/iris/iris_vb2.c | 2 +- > drivers/media/platform/qcom/iris/iris_vdec.c | 6 +-- > drivers/media/platform/qcom/iris/iris_venc.c | 4 +- > drivers/media/platform/qcom/iris/iris_vidc.c | 2 +- > 11 files changed, 72 insertions(+), 47 deletions(-) > Reviewed-by: Dikshita Agarwal Thanks, Dikshita