From: Neil Armstrong <neil.armstrong@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Kevin Hilman <khilman@baylibre.com>,
Nicolas Belin <nbelin@baylibre.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Tom Rix <trix@redhat.com>, Carlo Caione <ccaione@baylibre.com>,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/meson: venc: include linux/bitfield.h
Date: Fri, 2 Jun 2023 15:45:28 +0200 [thread overview]
Message-ID: <cc95cd30-ef3c-63e3-0f44-ad6338c7ed8e@linaro.org> (raw)
In-Reply-To: <20230602124539.894888-1-arnd@kernel.org>
On 02/06/2023 14:45, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without this header, the use of FIELD_PREP() can cause a build failure:
>
> drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table':
> drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
>
> Fixes: 51fc01a03442c ("drm/meson: venc: add ENCL encoder setup for MIPI-DSI output")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/meson/meson_venc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 2bdc2855e249b..3bf0d6e4fc30a 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -5,6 +5,7 @@
> * Copyright (C) 2015 Amlogic, Inc. All rights reserved.
> */
>
> +#include <linux/bitfield.h>
> #include <linux/export.h>
> #include <linux/iopoll.h>
>
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-06-02 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 12:45 Arnd Bergmann
2023-06-02 13:45 ` Neil Armstrong [this message]
2023-06-02 13:49 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc95cd30-ef3c-63e3-0f44-ad6338c7ed8e@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ccaione@baylibre.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=nbelin@baylibre.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®