From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.5 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795353177; b=CeVsD6N1GuJmZoNN99+FP9Pb3tkAHNE+vi9BBMwCkV4cZooXBifk10Y7U/EHtLvPptXN ZAAFYte4TEW5D8r6jPIHWWTNpcfVsMnz2YKv97fvFDd8ebTG6ZmIS2us5I/KemRY+l57r uAjz0GqobYc/1BXGDpDR4RlfB8A+j5nFmP/LAF1sPBtK/H0yfqjLQ7VPe70CSBCceoGxd p2Tv6YYADA465RpV94KC44kacYxx4oXyCOpFAG1cX7Ebxz3hgSF6oVcgpdxFheH5Js850 msGaGZJkAL5DQYJxqW0T8XRg7JMRalN4Xf0QvkxCk7BhzP1AmK3pGOyD1buypbyX+SQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795353177; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=nXqNVUPzypUOj6/Sw0WdN1Fosk+w9QLs84lkAIpwUVo=; b=h0NeWXtWNfruhwweRVbq0Kic2mVdpYNW+qW0HEtxoOze8j37xbAfS87MFfpGKf2DqQc3 238/6rJJnKUIzoRvxkNYG11Ds5hHr2Rsq9I0FZ+KpcgGiahGJwHgVGM7rl0LwEHp/nxH9 q1bBwjmLVDsVPg8GhLwqZWdJqtqmU0UCikwROcbhi9AcByxwuuqtXKkzTwRWbsGltkp1h TAXl/hEtWo1idNAyqJo4SP9RwmZ77JUJ1+kcZ4udynfYAlLT4aEYVcJjwf3tjRx1/QlaX XCR872YBW6wyPw0LC9lxAp+KAoiJR3+iBMHEWXrgBrMOIPnUVupNG75Fi+sj2m3fzAA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=AYfhU4ET; arc=none smtp.remote-ip=91.218.175.5 Received: from mta0.migadu.com (out-5.mta0.migadu.com [91.218.175.5]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41443606A32C for ; Sun, 22 Nov 2026 13:12:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 41443606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=AYfhU4ET X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=gyd9U5oFJdgRoHwbbh231r2ofTOvPYqIIEXaLmQ+v5o=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795353174; v=1; x=1795957974; b=AYfhU4ETlRrt4AdkOZnSkYoreUjEtvjc8B7AyNDvxgWLVGqWBW48vIXJubGbgUEMKr0oZGoz i6nyWJZni+K3TmNuvQp/g99hjdWBYSfcwhQOacTK5zU22ygpxYhXLB+Y2R53M7UZdbui1uInodU Es4Ocu8tDG7oasE/oOyvWCeA= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 4f329c19d9a8448a; Sun, 22 Nov 2026 13:12:54 +0000 X-Mizu-Trace-ID: 4f329c19d9a8448a X-Migadu-Flow: FLOW_OUT Message-ID: Date: Sun, 22 Nov 2026 14:12:48 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH rdma-rc v2] RDMA/siw: Reject a zero length WRITE segment that announces more segments To: Andrew Stellman Cc: Jason Gunthorpe , Leon Romanovsky , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261120140552.62784-1-astellman@stellman-greene.com> From: Bernard Metzler In-Reply-To: <20261120140552.62784-1-astellman@stellman-greene.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.11.2026 15:05, Andrew Stellman wrote: > siw_proc_write() returns early for a zero length tagged segment, before > it looks up the sink STag. If that first segment has the L bit clear, > the next segment is handled as a continuation of the same message and > siw reads mem->stag through rx_mem, which was never set. A remote peer > on an established siw connection can trigger this, and it panics the > host: > > Oops: general protection fault, probably for non-canonical address 0xdffffc0000000004: 0000 [#1] SMP KASAN NOPTI > KASAN: null-ptr-deref in range [0x0000000000000020-0x0000000000000027] > CPU: 1 UID: 65534 PID: 119 Comm: siw001peer Not tainted 7.4.0-rc3-gaebb72744764 #16 PREEMPT(lazy) > Hardware name: QEMU Ubuntu 24.04 PC v2 (i440FX + PIIX, arch_caps fix, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 > RIP: 0010:siw_proc_write+0x175/0x9c0 > Code: 48 c1 ea 03 80 3c 02 00 0f 85 c3 07 00 00 48 8b ab 80 04 00 00 48 b8 00 00 00 00 00 fc ff df 48 8d 7d 20 48 89 fa 48 c1 ea 03 <0f> b6 04 02 84 c0 74 08 3c 03 0f 8e 31 07 00 00 39 75 20 0f 85 4f > RSP: 0018:ff1100006cf08318 EFLAGS: 00000202 > RAX: dffffc0000000000 RBX: ff11000005880000 RCX: 0000000000000000 > RDX: 0000000000000004 RSI: 0000000000000000 RDI: 0000000000000020 > RBP: 0000000000000000 R08: ff11000005880408 R09: ff1100000588039a > R10: 0000000000000010 R11: ff11000005880398 R12: 0000000000000010 > R13: ff110000058803fc R14: 0000000000000000 R15: ff110000058803dc > FS: 00007f9054dd1740(0000) GS:ff110000da92e000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: dffffc0000000004 CR3: 0000000005703000 CR4: 0000000000751ef0 > PKRU: 55555554 > Call Trace: > > ? irqentry_exit+0x31b/0x6a0 > siw_tcp_rx_data+0x20e/0x2040 > ? __pfx_selinux_netlbl_sock_rcv_skb+0x10/0x10 > __tcp_read_sock+0x1ab/0x810 > ? __pfx_siw_tcp_rx_data+0x10/0x10 > ? __pfx___tcp_read_sock+0x10/0x10 > siw_qp_llp_data_ready+0x185/0x2e0 > ? __pfx_siw_qp_llp_data_ready+0x10/0x10 > ? tcp_try_rmem_schedule+0x17f/0x1390 > ? tcp_event_data_recv+0x36a/0x7b0 > tcp_data_queue+0x1f2d/0x4b70 > ? __pfx___mod_timer+0x10/0x10 > ? __pfx_tcp_data_queue+0x10/0x10 > ? tcp_try_undo_loss+0x6d0/0x730 > ? __pfx__raw_spin_lock_irqsave+0x10/0x10 > tcp_rcv_established+0x8a8/0x3990 > ? security_sock_rcv_skb+0x2b/0x40 > ? sk_filter_trim_cap+0x400/0x980 > ? __pfx_tcp_inbound_hash+0x10/0x10 > ? __pfx_tcp_rcv_established+0x10/0x10 > ? __pfx_sk_filter_trim_cap+0x10/0x10 > ? _raw_spin_lock+0x80/0xe0 > tcp_v4_do_rcv+0x45b/0x970 > ? tcp_v4_fill_cb+0x26/0x400 > tcp_v4_rcv+0x223d/0x3b90 > ? __pfx_tcp_v4_rcv+0x10/0x10 > ? __pfx_raw_local_deliver+0x10/0x10 > ? stack_access_ok+0xd9/0x200 > ip_protocol_deliver_rcu+0x61/0x2e0 > ip_local_deliver_finish+0x329/0x4b0 > ? __pfx__raw_spin_lock_irqsave+0x10/0x10 > ip_local_deliver+0x18f/0x2d0 > ? __pfx_ip_local_deliver+0x10/0x10 > ? __pfx___netif_receive_skb_core.constprop.0+0x10/0x10 > ? try_to_wake_up+0x239/0x17a0 > ? __asan_memset+0x23/0x50 > ? ip_rcv_core+0x4e9/0xce0 > ip_rcv+0x21a/0x270 > ? __pfx_ip_rcv+0x10/0x10 > ? __pfx_call_function_single_prep_ipi+0x10/0x10 > ? select_task_rq_fair+0xb29/0x4110 > ? __pfx_ip_rcv+0x10/0x10 > __netif_receive_skb_one_core+0x161/0x1b0 > ? __pfx___netif_receive_skb_one_core+0x10/0x10 > ? _raw_spin_lock_irq+0x81/0xe0 > ? ttwu_queue_wakelist+0x2a5/0x390 > process_backlog+0x1e5/0x5e0 > __napi_poll+0x9c/0x520 > net_rx_action+0x8d0/0xe70 > ? __pfx_net_rx_action+0x10/0x10 > ? rcu_core+0x250/0x1830 > ? clockevents_program_event+0x2ba/0x860 > handle_softirqs+0x1b3/0x600 > ? __pfx_handle_softirqs+0x10/0x10 > ? __hrtimer_rearm_deferred+0x156/0x450 > do_softirq+0x3d/0x60 > > > __local_bh_enable_ip+0x6a/0x70 > __dev_queue_xmit+0x89e/0x3170 > ? __pfx___dev_queue_xmit+0x10/0x10 > ? __pfx_selinux_ip_postroute_compat+0x10/0x10 > ? __pfx_clockevents_program_event+0x10/0x10 > ? _raw_spin_lock+0x80/0xe0 > ? irqentry_exit+0x31b/0x6a0 > ? selinux_ip_postroute+0x3e9/0x9d0 > ip_finish_output2+0x765/0x1b80 > ? __pfx_ip_finish_output2+0x10/0x10 > __ip_finish_output.part.0+0x46e/0x950 > ? selinux_ip_output+0x19/0x210 > ? __pfx___ip_finish_output.part.0+0x10/0x10 > ? nf_hook_slow+0xa7/0x1e0 > ip_output+0x260/0x4c0 > ? __pfx_ip_output+0x10/0x10 > ? __pfx_ip_finish_output+0x10/0x10 > __ip_queue_xmit+0x6f8/0x1dd0 > __tcp_transmit_skb+0x2ec9/0x4720 > ? __pfx___tcp_transmit_skb+0x10/0x10 > ? kasan_save_track+0x14/0x30 > ? __kasan_slab_alloc+0x6e/0x70 > tcp_write_xmit+0x11c9/0x78d0 > ? __pfx__copy_from_iter+0x10/0x10 > ? skb_page_frag_refill+0x55/0x390 > __tcp_push_pending_frames+0x8f/0x2f0 > tcp_sendmsg_locked+0x1741/0x3fc0 > ? __pfx_tcp_sendmsg_locked+0x10/0x10 > ? up_read+0x1f/0x1c0 > ? __pfx_lock_sock_nested+0x10/0x10 > tcp_sendmsg+0x26/0x40 > sock_write_iter+0x3ef/0x4c0 > ? __pfx_sock_write_iter+0x10/0x10 > vfs_write+0xa37/0xcd0 > ? do_sys_openat2+0xd1/0x170 > ? kmem_cache_free+0xba/0x3a0 > ? __pfx_vfs_write+0x10/0x10 > ? __pfx_do_sys_openat2+0x10/0x10 > ? fdget_pos+0x53/0x4b0 > ksys_write+0x17c/0x1c0 > ? __pfx_ksys_write+0x10/0x10 > do_syscall_64+0xdf/0x4c0 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > RIP: 0033:0x7f9054ef0574 > Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 80 3d d5 ea 0e 00 00 74 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 55 48 89 e5 48 83 ec 20 48 89 > RSP: 002b:00007fff4bb4ce88 EFLAGS: 00000202 ORIG_RAX: 0000000000000001 > RAX: ffffffffffffffda RBX: 0000000000000024 RCX: 00007f9054ef0574 > RDX: 0000000000000024 RSI: 00007fff4bb4cea0 RDI: 0000000000000003 > RBP: 0000000000000010 R08: 0000000000000073 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000001 > R13: 0000000000000000 R14: 0000000000000000 R15: 00007fff4bb4cea0 > > Modules linked in: > ---[ end trace 0000000000000000 ]--- > RIP: 0010:siw_proc_write+0x175/0x9c0 > Code: 48 c1 ea 03 80 3c 02 00 0f 85 c3 07 00 00 48 8b ab 80 04 00 00 48 b8 00 00 00 00 00 fc ff df 48 8d 7d 20 48 89 fa 48 c1 ea 03 <0f> b6 04 02 84 c0 74 08 3c 03 0f 8e 31 07 00 00 39 75 20 0f 85 4f > RSP: 0018:ff1100006cf08318 EFLAGS: 00000202 > RAX: dffffc0000000000 RBX: ff11000005880000 RCX: 0000000000000000 > RDX: 0000000000000004 RSI: 0000000000000000 RDI: 0000000000000020 > RBP: 0000000000000000 R08: ff11000005880408 R09: ff1100000588039a > R10: 0000000000000010 R11: ff11000005880398 R12: 0000000000000010 > R13: ff110000058803fc R14: 0000000000000000 R15: ff110000058803dc > FS: 00007f9054dd1740(0000) GS:ff110000da92e000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: dffffc0000000004 CR3: 0000000005703000 CR4: 0000000000751ef0 > PKRU: 55555554 > Kernel panic - not syncing: Fatal exception in interrupt > Kernel Offset: 0xb200000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) > > A zero length DDP message consists of exactly one segment (RFC 5041, > section 5.2), so terminate the connection with a tagged buffer error > when a zero length first segment announces more segments. > > The issue was found by Claude Opus 5.5 running Quality Playbook, an > LLM-driven code review tool: > https://github.com/andrewstellman/quality-playbook > The fix and this changelog were drafted with the same tool and reviewed > by me. > > Fixes: 8b6a361b8c48 ("rdma/siw: receive path") > Signed-off-by: Andrew Stellman > --- > v2: Include the full dmesg trace, as Leon asked. No code change. > v1: https://lore.kernel.org/linux-rdma/20261120000829.64597-1-astellman@stellman-greene.com/ > > Tested in QEMU with KASAN on v7.4-rc3. The patch applies unchanged to > rdma for-rc. With this patch siw sends a TERMINATE and closes the > connection, a normal two segment WRITE is still placed, and rping over > siw works. > A reproducer is available on request. > > drivers/infiniband/sw/siw/siw_qp_rx.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/sw/siw/siw_qp_rx.c b/drivers/infiniband/sw/siw/siw_qp_rx.c > index e5b641c8d694..9b7e52906764 100644 > --- a/drivers/infiniband/sw/siw/siw_qp_rx.c > +++ b/drivers/infiniband/sw/siw/siw_qp_rx.c > @@ -550,8 +550,16 @@ int siw_proc_write(struct siw_qp *qp) > int bytes, rv; > > if (srx->state == SIW_GET_DATA_START) { > - if (!srx->fpdu_part_rem) /* zero length WRITE */ > + if (!srx->fpdu_part_rem) { /* zero length WRITE */ > + /* A zero length DDP message is a single segment. */ > + if (unlikely(frx->first_ddp_seg && frx->more_ddp_segs)) { > + siw_init_terminate(qp, TERM_ERROR_LAYER_DDP, > + DDP_ETYPE_TAGGED_BUF, > + DDP_ECODE_T_INVALID_STAG, 0); > + return -EINVAL; > + } > return 0; > + } > > rv = siw_write_check_ntoh(srx, frx); > if (unlikely(rv)) { > > base-commit: e7732ec135b501e87ab060d992b3b5f2ec4396c9 Thank you Andrew, you're reminding me of things I was once actively involved in specifying! Acked-by: Bernard Metzler