From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099E12FDC38 for ; Tue, 13 Jan 2026 09:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768296078; cv=none; b=JZ4ZkHtf+Z1WDF7U3VZIxt9fa9rv5tP86HNRDQJxgg3NY2QvwKLrH6hF7qaiS2TOdQ9AndiacmDHjJBvEYo+fwgw5Z3HEyyulNiEzsvw5QE20WB9q2/Zc5w4Std6iul99VpZCoB78X6S4HVrZJWYy+dKgcRo2qiO6CI/sHLOoyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768296078; c=relaxed/simple; bh=Rlr7mwtBcyRz8AkxKQslsvs/sH2b9falE/D2Iy0kM+k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IhFSFIdF33BcT7zBWPCrFzA5PEns/22XCRcyMbOxMkAsqa3hbM/tQsTHtmdYGDsy9PTdeEYGEpzI5jx9sjECdVEYGrsApQPy6VatjaG96hDWr+vj2xDJpnHFE1UxbxjuteL7VyMFoJQ/O3go2pBvXXsdtcFkSFFcE8oMeVxf+NU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dRW2bO/8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A9qASAvw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dRW2bO/8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A9qASAvw" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60D59B3u2835285 for ; Tue, 13 Jan 2026 09:21:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 31iZECsNCqRxKyUF60JhJXKKA5LmDwD9E8aM+9WSyhw=; b=dRW2bO/8s05UmtjR OYxMOjjRBu6n7jyCQG9i01cM3IpVTtmbwGOpGM48h3TDAXOoCV/SM75zNhBnUIDG umESGNQc8aiPzoXl8TSEQOcQV4Tn4Z+ShGffjKbV+Qywi/BEACAU27mwh+5CLR68 VsPq28xd601r6BMC9DTf478YxsiLqm7jW+j6iymjuKya0//hNuGaBYrfFzyTBEZy LzaS5bL8I61p2RvxMxXMIBqey3Fsukc21kdItvb6rX8zRhn5h3B1ZAnsOTjckU5H 4TSahgKEaZ7mY9aKwBgBwMXX/GIkJTqRfYdDZttX8B9iia3KdmrL5ZpSXwWDejnS FEOzAw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnfn9rqcs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 09:21:02 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-88fce043335so30026506d6.2 for ; Tue, 13 Jan 2026 01:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768296062; x=1768900862; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=31iZECsNCqRxKyUF60JhJXKKA5LmDwD9E8aM+9WSyhw=; b=A9qASAvwAog5Oza0MRI6YJhAlHQJwbCvNMhN/yY3BNS/fmKTJLFG/EhyYaITT+gYx8 VCaNGnJgKOf3KELFQ7RJJIlVaEtcopFzPehbjTFghOjjh1zeKM4m5x8LNVSzS6WkYfLA ukF3rrBMqT1S42SCIoU31rOoBNhS1zWPqhBxrCdc58Il6ziaX5K/QAdyJwPk3L/s+xZX rrn3WCn8rITCbzTHO7qONTf0wNeHINpK2OnfTKj/hYhcTgkkAcCpwdg6mpCCQOsMIMzD xoNLCC+NrMyEbHvQMLGjE4KfdJI6t5wzx/mArqwZwQW1u7iSAvv3RRUsKEVZPXxXcbi0 Ofbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768296062; x=1768900862; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=31iZECsNCqRxKyUF60JhJXKKA5LmDwD9E8aM+9WSyhw=; b=vyGUU4JUpIVksx7xBLsHuaBST3Fa54cGBGjgEtBvAE7313g2HQ3yz9ML9SJhmUDvaO nW3TX14b8LoIgIAb1DmRGNnaZHAMZSINqAjxF65XJyoVKic0Z0KCw7MQYIg/JJm0Tpny xfmIgOoFCXVNcxw4aoQKQMnIZyiGgcXYQbHyXWhKtkWugGQnPQvRMVKOgRTJRw3UPyfb snDRIkA6wzuav/UYAkc+fuG08kdy7NAvUUpy8a1Nk5xk0mfWgo2mLpr4SMiA9kaLPx9N JBlo96sg6W1M8jYW4+jKvqpupW5V1T/vEYzSathaUZDGl1AZjdK2i5yCoFUQJB0i3aFS /7cw== X-Forwarded-Encrypted: i=1; AJvYcCVc06C9zeKhUTwooriEpxI1l0eVHX4Zkg/GOsRI5JkYxWRjck/WMlX7s5ZJwcQSdU73kbOwgQFjn+bjKw0=@vger.kernel.org X-Gm-Message-State: AOJu0YwqfQtU9t9WyxLbYzP8v54eLO2px9NvhGkSgTGw6zhAWGsovKdb qqRuTw40C6mzEDmUnzc9ww2kHiDNX7eP1HnBChPS0mbsIyjRjTPGr61QrzcvpZnDZuFXSOnZ3un m/G+FYtHbsPvtegYX1QyyUu6oiBAa/8douFjy1uAIHi5cyS08XtS2NT/FNjuiPbauLQ8= X-Gm-Gg: AY/fxX5EkCG3gJA2NObquLGAK0Uq1va5Z2tzFNbHidupGi2YOA41QpTShZL6qkwBFKH Z353ea6JhdhrjbdhwSvZjRPsaMq+QG0ckx/z2p3Dump7WOBbAj0KsuZK8WMNSo7aq9ztBzmO+nE 5qaaXKXUa2JnEyAAjSpcyPI96C9uZbBh3virqdGsntoktZRUW4wQT7KXsawQZ4Fo/qX829fD72P ps2Da6yrKuXrOPos5XWSdQQfptNw7rCi11DAuRysMk9u6rtHoP5RP9yJI8SXBgCCVa7/F9e2mKJ recoSuYMNljPYQdv5pIdf/dUI6EBw+z53gHzZA6Rk4cezu4Z2wMQIbxbHEF91eNvf1zVuKjDnev XlMWCs8AbR/5KBqnMxCobuIPljjDyaf7aJ6J8LJ5qyfXp8K0DvXS78w5lRilqxaslGrY= X-Received: by 2002:a05:620a:40c2:b0:8a3:d644:6930 with SMTP id af79cd13be357-8c3893a11a8mr2125837585a.5.1768296061990; Tue, 13 Jan 2026 01:21:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4OnuSeA6QbV367W40dl4Ix9iFHMALktInIMXZY6erSj9Muhf4uN+sZ1f+zqQ5eVe104M4Vg== X-Received: by 2002:a05:620a:40c2:b0:8a3:d644:6930 with SMTP id af79cd13be357-8c3893a11a8mr2125835185a.5.1768296061436; Tue, 13 Jan 2026 01:21:01 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507b8c4479sm19863659a12.1.2026.01.13.01.20.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 01:21:00 -0800 (PST) Message-ID: Date: Tue, 13 Jan 2026 10:20:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sm8750: Enable download mode register write To: Mukesh Ojha , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260112151725.2308971-1-mukesh.ojha@oss.qualcomm.com> <433fc01b-0e59-49bf-afdc-a23e815cc563@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <433fc01b-0e59-49bf-afdc-a23e815cc563@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Kc60uw2KSIEFsjo--fUuOdnPz1g9QWUO X-Proofpoint-ORIG-GUID: Kc60uw2KSIEFsjo--fUuOdnPz1g9QWUO X-Authority-Analysis: v=2.4 cv=HN/O14tv c=1 sm=1 tr=0 ts=69660e7e cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=_yhzRq-LgXqgePbigCEA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDA3OCBTYWx0ZWRfXyKcgRDopJm6c TvHr2APRJqxojVb2xp0WWD7BFsUMB8B5HiveIjqzpuCTqd/rFh0WGT94FUnHX7QY5Z1X5OGGhF/ GgnmZAcjQepgAdMJSXPxTR/hJvtC7VEPzTIVayRHUN58YbFjJyOTw1Xag502/rtirQdj4DdcqwW 7XVufnmQQI5UV0kG3CrblclKnXLsPOyU9p5xbQkRzj86dYAoGPQhBzJIsAJbt19bkLAxnpvG5Qz Te4OTzCjV3qPpNQd5aeRLMKsRDH43Qm/sDoaLA3Fj99q2OZydr3U95r9tERFdIPvovJwvAEpuuN MwmDTALunnTG1Jij010lkmMG8EWHk0YNKA2IicQxCuiIrqrOy6jHRU5OX0/Sd8asMa3i66qNYIW G2jHcanNwDJI9p80BdsULBLGWGzzL+nao8u2AJo3bYJ2XVjYSAQzVEs8ZsrLjvT+G+SIVA6+zaf ZZub1UDXJ25xayyTAAQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_01,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130078 On 1/13/26 10:16 AM, Konrad Dybcio wrote: > On 1/12/26 4:17 PM, Mukesh Ojha wrote: >> Enable download mode setting for sm8750 which can help collect >> ramdump for this SoC. >> >> Signed-off-by: Mukesh Ojha >> --- > > Reviewed-by: Konrad Dybcio Actually no, we have a mess to undo.. There's already this node: tcsrcc: clock-controller@f204008 { compatible = "qcom,sm8750-tcsr", "syscon"; reg = <0x0 0x0f204008 0x0 0x3004>; clocks = <&rpmhcc RPMH_CXO_CLK>; #clock-cells = <1>; #reset-cells = <1>; }; That's located at the rear end of TLMM (someone had a funny idea to move registers around when designing this specific SoC) Problem is, those registers aren't actually "TCSRCC", not even "TCSR" Physically, they belong to the TLMM register window (which starts at the base it promises under the TLMM node today and is 0xf0_0000-long. What we should have done for a fairer representation is make TLMM a clock provider on this specific platform qcom,sm8750-tcsr binds the tcsrcc driver, so we can't describe the actual TCSR (as in this patch).. we'll have to break something.. Konrad