mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Thorsten Blum <blum@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Dexuan Cui <decui@microsoft.com>,
	"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
	Michael Kelley <mhklinux@outlook.com>,
	"Pratyush Yadav (Google)" <pratyush@kernel.org>,
	Yunhong Jiang <yunhong.jiang@linux.intel.com>
Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/realmode: Consolidate real-mode blob size calculation
Date: Thu, 19 Nov 2026 11:56:23 -0800	[thread overview]
Message-ID: <ccac3b29-c427-452e-af25-0bb0cacba9c5@intel.com> (raw)
In-Reply-To: <20261113233306.4295-3-blum@kernel.org>

On 11/13/26 15:33, Thorsten Blum wrote:
> rmpiggy.S page-aligns both real_mode_blob and real_mode_blob_end. Their
> difference is therefore already page-aligned and does not require
> ALIGN() or PAGE_ALIGN().
> 
> Since the real-mode blob size is calculated in three different places,
> add the real_mode_blob_size() helper and use it in
> real_mode_size_needed(), setup_real_mode(), and
> set_real_mode_permissions().
> 
> No functional change.

Hi Thorsten,

For me, it's a pass on patches like these. They have a real risk of
causing regressions and don't meaningfully make the code more maintainable.

So, it's all downside.

These are hurting the kernel more than helping at the moment. Please stop.

      reply	other threads:[~2026-11-19 19:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 23:33 Thorsten Blum
2026-11-19 19:56 ` Dave Hansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccac3b29-c427-452e-af25-0bb0cacba9c5@intel.com \
    --to=dave.hansen@intel.com \
    --cc=blum@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=decui@microsoft.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhklinux@outlook.com \
    --cc=mingo@redhat.com \
    --cc=pratyush@kernel.org \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=rppt@kernel.org \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    --cc=yunhong.jiang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®