From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5CD12E7387; Fri, 26 Jun 2026 18:07:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782497271; cv=none; b=O+yQYn+2YXoWqub9F8sUJNedzhwqZ4Osk9jGGNUk3pIjZ7RWAey05lnSevGku6W0mz1MzkN7nObuLAL8UFfu97yyZIBXOMBlCBs65bJZUpv8xjfwO6Z/y/GqoQkf7amRNpCAmDUz+htfUq1Q0WpaEtcZDoVcLM10anWs775LBfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782497271; c=relaxed/simple; bh=ys8pZnHEjHgFatX9LMEUtN2KZV1NBedtHIziH13eoJk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y1DX+TsHEj4TQ9oqjk5/rYkHydR2Vt0WsoUaRXY3u+oH7MFxpwqwGtIEqNyTrmD2XOymhb0T427dd3/F32HOdof6noZQkZazuL8fiNKnVGplP6znZVkD209kupdfSBwfvd9wALDC6iiAG/8mqqZgha3p+IOzq/t+KJjyeTm1jPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UQKUT1uS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UQKUT1uS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 973BB1F000E9; Fri, 26 Jun 2026 18:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782497270; bh=VL1nHVZPTfavofIwp9gpOh3SmHbzNBRcvKHEMSpIbFg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=UQKUT1uS4wbGc81aYsivha4ghMYSw+zS2A8Jw6cgXRoAyLdFw8mG3RmH/1Xv+Pgaf x9LWCsRJVv0e9Lw/naxu8UwhIPNcs5FxQRe+mfzcKy+ZXZJGzqLU2mMVGWflgoVYGQ JKhokP3ca0R+GBKN0omFwlcWHWatUxW4GvRUTJoz874+WDh4fJI4+6hugg1t2d5NK/ xr7JHoupim3OF7y7fwAoLtYJ2eG6t6en2p8qhnGFipIgTU5/2a5CJaG7pgmQw3mAvs UA/v05PIUZxOY1lID555z4QY9Z2Jg+37m8pl+Xpzdja0ojRAM9j2knyU/yvyB2SaYf xXWTb52WhTDOw== Message-ID: Date: Fri, 26 Jun 2026 20:07:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 12/13] mm: Move __alloc_pages() to mm/internal.h Content-Language: en-US To: "David Hildenbrand (Arm)" , Brendan Jackman , Brendan Jackman , Andrew Morton , Suren Baghdasaryan , Michal Hocko , Johannes Weiner , Zi Yan , Muchun Song , Oscar Salvador , Lorenzo Stoakes , "Liam R. Howlett" , Mike Rapoport , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Cc: "Harry Yoo (Oracle)" , Gregory Price , Alexei Starovoitov , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev References: <20260622-alloc-trylock-v2-0-31f31367d420@google.com> <20260622-alloc-trylock-v2-12-31f31367d420@google.com> <41e92bab-6882-401a-8de9-154adbdcfb36@kernel.org> <521f8943-bfc3-4414-a630-634712c709e4@kernel.org> From: "Vlastimil Babka (SUSE)" Autocrypt: addr=vbabka@kernel.org; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSNWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBrZXJuZWwub3JnPsLBsAQTAQoAWhYhBKlA1DSZLC6OmRA9UCJPp+fM gqZkBQJqFFy6GxSAAAAAAAQADm1hbnUyLDIuNSsxLjEyLDIsMgIbAwUJGtCBUAULCQgHAwUV CgkICwUWAgMBAAIeBQIXgAAKCRAiT6fnzIKmZJIUEADFx/tREzUImHrEwVHeSvDFmA7tJysI UVrlvrM09E7GIuzphzv7jYmo8n3ANpCczLEVr4G0syYQdTigaZgv3+FQDIIzhKih1IHhu1Ei XHlywNWKnQxxQEUNi5Mwx43wQz5XVw9F1A7gtKBKNtfogO511hAbrzagrYajyQacEJ/+sfhZ 9Da8ltHIXD8pcYaHUfQgEusCgmEd9+KrUwrTbckFKmYq5chuE6yJ4J0EmWknL096jIE6CnzF FRslQ3B1UKDjxVsm1ZHfir5NeWszLkTvGFsddFaWTgh8UycESG6VQzKXjjewXu2pG7YQYRpj QKm1W5X2TkwWkXRBZTmfmbhxIUMh3+zf5wQ463rSmDN/8v81tdqBtAW6rH/kzg1GvkaTHXn0 507yEHFzBksk2viAuIxxr7km8+/KARYLIdGtx30EG8cKzAUZOK6WqxtNCsXUJNrVE8CWrCaD icoNu7Fs1c5hmPHdSTnU48ce67449DdnO4neLSNhRiGlMHJgfJUmgrxu/hcYeOZ3haWmEQ2w uW1Mh01OHi8QZHCEyAbABrPs9GUgccc/4eYXX9hIgxfSkYzn8f+8NuIFPWl/0uTvjgqU29FQ SbzOLxHq9439Ox40G5mS5eZXRGxITYR+6TXvRGI6P/264jvflnr/pDGUttaikU+0W+1uxgKH cmYbEc7ATQRbGTU1AQgAn0H6UrFiWcovkh6EXVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQ La1PQDUi6j00ChlcR66g9/V0sPIcSutacPKfdKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMh FmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCTsTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sf bAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZOrIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq +aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahKtQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4n jQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJksLo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8A CgkQIk+n58yCpmS2PA//bqN1LfcotmArgElsa+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKY HR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVd SXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi 4U9F/trLten/x7bpphDSnDMKJtITbtzATT1Dq7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O4 0PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwgBF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O 2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9YplavCMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/P wIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dq NcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudLvPA/SK8sKoM01IRxSihev/S/5WLazXB1PGem OCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLV jXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4pYekxJujNeEDkUlky0Y= In-Reply-To: <521f8943-bfc3-4414-a630-634712c709e4@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/22/26 16:30, David Hildenbrand (Arm) wrote: > On 6/22/26 15:07, Brendan Jackman wrote: >> On Mon Jun 22, 2026 at 12:24 PM UTC, David Hildenbrand (Arm) wrote: >>> On 6/22/26 12:01, Brendan Jackman wrote: >>>> It's no longer used outside of mm/. >>>> >>>> Since this means __alloc_pages_noprof() is no longer visible from gfp.h, >>>> this also means moving the definition of alloc_pages_node_noprof into >>>> the .c file. >>>> >>>> Signed-off-by: Brendan Jackman >>>> --- >>>> Documentation/admin-guide/cgroup-v1/cpusets.rst | 2 +- >>>> Documentation/admin-guide/mm/transhuge.rst | 2 +- >>>> include/linux/gfp.h | 16 +--------------- >>>> mm/internal.h | 4 ++++ >>>> mm/page_alloc.c | 11 +++++++++++ >>>> 5 files changed, 18 insertions(+), 17 deletions(-) >>> >>> Do we want some mm/page_alloc.h , to start splitting up mm/internal.h >> >> Don't see why not, if people are on board I'm happy to do that for v3. >> >> (I just realised I put __alloc_pages_noprof() at the bottom of the file, >> while it should be next to __alloc_frozen_pages etc, should fix that in >> case we don't end up going for the separated header). >> >> So what would go in the new header... >> >> - All the buddy alloc/free entry points >> - ALLOC_ flags >> - alloc_context >> - buddy_order*(), page_is_buddy(), find_buddy_page_pfn() and >> __find_buddy_pfn() >> - post_alloc_hook(), free_pages_prepare() >> - zone_pcp_*() >> - find_suitable_fallback() >> - free_area_empty() >> >> Anything else? Or anything on that list that should stay in >> mm/internal.h? > > Above looks like a decent start :) Thanks! Ack!