From: Ayushi Makhija <quic_amakhija@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: <konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<dmitry.baryshkov@linaro.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<quic_rajeevny@quicinc.com>, <quic_vproddut@quicinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: sm8750-mtp: Set sufficient voltage for panel nt37801
Date: Thu, 26 Mar 2026 15:06:52 +0530 [thread overview]
Message-ID: <ccb11c2a-4cf1-4486-be71-d4bcc983cee6@quicinc.com> (raw)
In-Reply-To: <acHwvzjcvqNxUjm3@baldur>
On 3/24/2026 7:34 AM, Bjorn Andersson wrote:
> On Mon, Mar 23, 2026 at 03:52:29PM +0530, Ayushi Makhija wrote:
>> The NT37801 Sepc V1.0 chapter "5.7.1 Power On Sequence" states
>> VDDI=1.65V~1.95V, so set sufficient voltage for panel nt37801.
>>
>
> Please add Fixes: tag.
>
Hi Bjorn,
Sure, will add in new patchset.
>> Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com>
>
> Please start using your oss.qualcomm.com address.
>
>> ---
>> arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
>> index 3837f6785320..6ba4e69bf377 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
>> @@ -462,7 +462,7 @@ vreg_l11b_1p0: ldo11 {
>>
>> vreg_l12b_1p8: ldo12 {
>> regulator-name = "vreg_l12b_1p8";
>> - regulator-min-microvolt = <1200000>;
>> + regulator-min-microvolt = <1650000>;
>
> Are you sure it's not supposed to be 1.8V, given the name of the rail?
>
> Regards,
> Bjorn
There was already discussion regarding the minimum voltage for this regulator on sm8550 target
on other upstream patch.
Link: https://lore.kernel.org/all/aQQdQoCLeKhYtY7W@yuanjiey.ap.qualcomm.com/
This values is according to the NT37801 panel sec
"The NT37801 Sepc V1.0 chapter "5.7.1 Power On Sequence" states
VDDI=1.65V~1.95V."
Thanks,
Ayushi
>> regulator-max-microvolt = <1800000>;
>> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> regulator-allow-set-load;
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2026-03-26 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 10:22 Ayushi Makhija
2026-03-23 12:25 ` Konrad Dybcio
2026-03-23 22:12 ` Dmitry Baryshkov
2026-03-24 2:04 ` Bjorn Andersson
2026-03-26 9:31 ` Ayushi Makhija
2026-03-26 9:36 ` Ayushi Makhija [this message]
2026-03-26 15:58 ` Bjorn Andersson
2026-04-09 5:44 ` Ayushi Makhija
2026-04-09 13:35 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccb11c2a-4cf1-4486-be71-d4bcc983cee6@quicinc.com \
--to=quic_amakhija@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rajeevny@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®