From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21BB3C25B6B for ; Wed, 25 Oct 2023 10:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234531AbjJYK1R (ORCPT ); Wed, 25 Oct 2023 06:27:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232082AbjJYK1P (ORCPT ); Wed, 25 Oct 2023 06:27:15 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 22DB893; Wed, 25 Oct 2023 03:27:13 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 506412F4; Wed, 25 Oct 2023 03:27:54 -0700 (PDT) Received: from [10.57.2.113] (unknown [10.57.2.113]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 337073F738; Wed, 25 Oct 2023 03:27:10 -0700 (PDT) Message-ID: Date: Wed, 25 Oct 2023 11:27:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] coresight-tpdm: Correct the property name of MSR number To: Tao Zhang , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski Cc: Jinlong Mao , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Song Chai , linux-arm-msm@vger.kernel.org, andersson@kernel.org References: <1698128353-31157-1-git-send-email-quic_taozha@quicinc.com> Content-Language: en-GB From: Suzuki K Poulose In-Reply-To: <1698128353-31157-1-git-send-email-quic_taozha@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Please always run a checkpatch on your patch before submission. (And of course test your patch properly for all the functionality that it introduces. We don't have the hardware for testing all of this. So, there is only so much we could do with the eyes) On 24/10/2023 07:19, Tao Zhang wrote: > Correct the property name of the DSB MSR number that needs to be > read in TPDM driver. The right property name is > "qcom,dsb-msrs-num". > > Fixes： 90a7371cb08d ("coresight-tpdm: Add nodes for dsb msr support") > Signed-off-by: Tao Zhang > --- > drivers/hwtracing/coresight/coresight-tpdm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c > index b25284e..97654aa 100644 > --- a/drivers/hwtracing/coresight/coresight-tpdm.c > +++ b/drivers/hwtracing/coresight/coresight-tpdm.c > @@ -892,7 +892,7 @@ static int tpdm_probe(struct amba_device *adev, const struct amba_id *id) > > if (drvdata && tpdm_has_dsb_dataset(drvdata)) > of_property_read_u32(drvdata->dev->of_node, > - "qcom,dsb_msr_num", &drvdata->dsb_msr_num); > + "qcom,dsb-msrs-num", &drvdata->dsb_msr_num); > > /* Set up coresight component description */ > desc.name = coresight_alloc_device_name(&tpdm_devs, dev); checkpatch complains: ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 90a7371cb08d ("coresight-tpdm: Add nodes for dsb msr support")' #13: Fixes： 90a7371cb08d ("coresight-tpdm: Add nodes for dsb msr support") total: 1 errors, 0 warnings, 8 lines checked Suzuki