From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932135AbeARARs (ORCPT <rfc822;w@1wt.eu>);
        Wed, 17 Jan 2018 19:17:48 -0500
Received: from mail-pg0-f66.google.com ([74.125.83.66]:42375 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754621AbeARARq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 17 Jan 2018 19:17:46 -0500
X-Google-Smtp-Source: ACJfBotFEuIhOR49ECSNQD8xh8RzyM82EncKFVHj9Qs2Z6X51rE0AG+zdfOeP4eZAcwVTEPIlH03sA==
Subject: Re: [PATCH net-next] net: core: Expose number of link up/down
 transitions
To: Jiri Pirko <jiri@resnulli.us>, Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, edumazet@google.com, andrew@lunn.ch,
        cphealy@gmail.com, David Decotigny <decot@googlers.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
        Alexei Starovoitov <ast@fb.com>,
        Roopa Prabhu <roopa@cumulusnetworks.com>,
        Mahesh Bandewar <maheshb@google.com>,
        Vlad Yasevich <vyasevich@gmail.com>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Jonas Bonn <jonas@southpole.se>,
        stephen hemminger <stephen@networkplumber.org>,
        Hans Liljestrand <ishkamiel@gmail.com>,
        "Reshetova, Elena" <elena.reshetova@intel.com>,
        Kirill Tkhai <ktkhai@virtuozzo.com>, Andrey Vagin <avagin@openvz.org>,
        Florian Westphal <fw@strlen.de>, Xin Long <lucien.xin@gmail.com>,
        Matthias Schiffer <mschiffer@universe-factory.net>,
        Jiri Benc <jbenc@redhat.com>, open list <linux-kernel@vger.kernel.org>
References: <20180117230704.21949-1-f.fainelli@gmail.com>
 <20180117235207.GC26967@nanopsycho>
From: David Ahern <dsahern@gmail.com>
Message-ID: <ccb70b0f-81c0-46ce-12aa-a74b2e6832e8@gmail.com>
Date: Wed, 17 Jan 2018 16:17:43 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20180117235207.GC26967@nanopsycho>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/17/18 3:52 PM, Jiri Pirko wrote:
> Thu, Jan 18, 2018 at 12:06:57AM CET, f.fainelli@gmail.com wrote:
>> From: David Decotigny <decot@googlers.com>
>>
>> Expose the number of times the link has been going UP or DOWN, and
>> update the "carrier_changes" counter to be the sum of these two events.
>> While at it, also update the sysfs-class-net documentation to cover:
>> carrier_changes (3.15), count_link_up (4.16) and count_link_down (4.16)
>>
>> Signed-off-by: David Decotigny <decot@googlers.com>
> 
> [...]
> 
> 
>> @@ -161,6 +161,8 @@ enum {
>> 	IFLA_EVENT,
>> 	IFLA_NEW_NETNSID,
>> 	IFLA_IF_NETNSID,
>> +	IFLA_COUNT_LINK_UP,
>> +	IFLA_COUNT_LINK_DOWN,
> 
> 
> 	IFLA_LINK_UP_COUNT,
> 	IFLA_LINK_DOWN_COUNT,
> 
> would sound a bit nicer to me.

given existing IFLA_LINK_* attributes how about
IFLA_CARRIER_{UP,DOWN}_COUNT?